https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43397 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43397 --- Comment #2 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 204332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204332&action=edit Bug 43397: SIP accounts with a blank AE field template send an empty patron name Bug 37893 moved SIP accounts from SIPconfig.xml into the database. The new SIP account editor initializes every text field to an empty string rather than null, so an account created through the staff interface gets ae_field_template = '' instead of NULL which is defined and so the empty template is used thus giving an empty AE field in responses for newly created accounts! Test Plan: 1) Create a SIP account in the staff interface leaving the AE field template blank 2) Restart all the things! 3) Send a patron status or patron information request for a valid patron 4) Note the AE field in the response is empty 5) Apply this patch 6) Restart all the things! 7) Repeat the request, note the AE field now contains the patron's name! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43397 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43397 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204331|0 |1 is obsolete| | Attachment #204332|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43397 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207235&action=edit Bug 43397: SIP accounts with a blank AE field template send an empty patron name Bug 37893 moved SIP accounts from SIPconfig.xml into the database. The new SIP account editor initializes every text field to an empty string rather than null, so an account created through the staff interface gets ae_field_template = '' instead of NULL which is defined and so the empty template is used thus giving an empty AE field in responses for newly created accounts! Test Plan: 1) Create a SIP account in the staff interface leaving the AE field template blank 2) Restart all the things! 3) Send a patron status or patron information request for a valid patron 4) Note the AE field in the response is empty 5) Apply this patch 6) Restart all the things! 7) Repeat the request, note the AE field now contains the patron's name! Signed-off-by: Rae Schumann <rschumann@utah.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43397 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43397 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208135&action=edit Bug 43397: Add unit tests Signed-off-by: Rae Schumann <rschumann@utah.gov> Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43397 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Pushed to main for 26.11 with consent from Pedro whilst he's on annual leave -- You are receiving this mail because: You are watching all bug changes.