[Bug 43288] New: Change amount missing from printed fee receipts (change_given/change param mismatch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 Bug ID: 43288 Summary: Change amount missing from printed fee receipts (change_given/change param mismatch) Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk Target Milestone: --- members/pay.tt, members/paycollect.tt, and members/boraccount.tt all open members/printfeercpt.pl with a change_given= query parameter after taking a payment (for the FinePaymentAutoPopup auto-printed receipt, and for the manual Print action). However printfeercpt.pl only ever reads a 'change' param into its GetPreparedLetter substitute hash: substitute => { tendered => scalar $input->param('tendered'), change => scalar $input->param('change') } This matches the default ACCOUNT_CREDIT/CREDIT_PAYMENT notice templates, which use [% change | $Price %] (not change_given). Since nothing ever sends a change= param, the Change line on every printed fee receipt is silently blank. This isn't new: installer/data/mysql/db_revs/220600072.pl shows Koha previously migrated stored ACCOUNT_CREDIT letter content from [% change_given to [% change, so 'change' is the established name on the notice-template side. This patch fixes the three query strings that build the printfeercpt.pl URL to send change= instead of change_given=, rather than touching printfeercpt.pl or notice content. The change_given variable name is left alone everywhere else (hidden form fields, JS locals, Perl params) - this is purely about the query key at the printfeercpt.pl boundary. Test plan: 1. Set the FinePaymentAutoPopup system preference to "show" 2. Take a payment for a patron (via members/pay.pl or members/paycollect.pl) for less than the full amount tendered, so change is generated 3. Note the auto-popped-up receipt's Change line is blank 4. Apply the patch 5. Repeat step 2 6. Note the Change line now shows the correct amount 7. Repeat via the boraccount.pl account tab's Print action for a payment with change -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203578&action=edit Bug 43288: Fix change amount missing from printed fee receipts pay.tt, paycollect.tt and boraccount.tt all open printfeercpt.pl with a change_given= query parameter after a payment, but printfeercpt.pl only ever reads a 'change' param into its GetPreparedLetter substitute hash - matching the ACCOUNT_CREDIT/CREDIT_* default notice templates, which use [% change | $Price %], not [% change_given | $Price %]. As a result the change amount is silently blank on every printed fee receipt that shows it, regardless of FinePaymentAutoPopup. Rather than touch printfeercpt.pl or the notice content (both already agree on 'change', matching a similar migration Koha did once before in installer/data/mysql/db_revs/220600072.pl going the same direction), fix the three query strings that build the printfeercpt.pl URL to send change= instead of change_given=. The change_given variable name is kept everywhere else (form fields, JS locals, Perl params) since this is purely about the query key at the printfeercpt.pl boundary. Test plan: 1) Set FinePaymentAutoPopup to 'show' 2) Take a payment for a patron via members/pay.pl or members/paycollect.pl that generates change (fine amount not evenly covered by cash tendered) 3) Note the auto-popped-up receipt shows the change amount (before this patch, the Change line was always blank) 4) Repeat via the boraccount.pl > printfeercpt.pl print receipt route -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 --- Comment #2 from Juliet Heltibridle <jheltibridle@rcplib.org> ---
Test plan: 1) Set FinePaymentAutoPopup to 'show' 2) Take a payment for a patron via members/pay.pl or members/paycollect.pl that generates change (fine amount not evenly covered by cash tendered) 3) Note the auto-popped-up receipt shows the change amount (before this patch, the Change line was always blank)
This part works as expected, the change was shown when using members/pay.pl or members/paycollect.pl
4) Repeat via the boraccount.pl > printfeercpt.pl print receipt route
This part does not show the change amount on the receipt. It doesn't look like the link in the drop-down is passing the 'tendered' and 'change' parameters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203578|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 204789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204789&action=edit Bug 43288: Fix change amount missing from printed fee receipts pay.tt, paycollect.tt and boraccount.tt all open printfeercpt.pl with a change_given= query parameter after a payment, but printfeercpt.pl only ever reads a 'change' param into its GetPreparedLetter substitute hash - matching the ACCOUNT_CREDIT/CREDIT_* default notice templates, which use [% change | $Price %], not [% change_given | $Price %]. As a result the change amount is silently blank on every printed fee receipt that shows it, regardless of FinePaymentAutoPopup. Rather than touch printfeercpt.pl or the notice content (both already agree on 'change', matching a similar migration Koha did once before in installer/data/mysql/db_revs/220600072.pl going the same direction), fix the three query strings that build the printfeercpt.pl URL to send change= instead of change_given=. The change_given variable name is kept everywhere else (form fields, JS locals, Perl params) since this is purely about the query key at the printfeercpt.pl boundary. Test plan: 1) Set FinePaymentAutoPopup to 'show' 2) Take a payment for a patron via members/pay.pl or members/paycollect.pl that generates change (fine amount not evenly covered by cash tendered) 3) Note the auto-popped-up receipt shows the change amount (before this patch, the Change line was always blank) 4) Repeat via the boraccount.pl > printfeercpt.pl print receipt route Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes pop-up printable release notes| |payment receipts for | |payments made by patrons | |(when the | |FinePaymentAutoPopup system | |preference is set to "Do"). | | | |If change is given for a | |payment, the line "Change | |given" on the printable | |receipt was missing. CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. You may have to allow pop-up windows in your browser (if you have disabled this). 2. Before the patch, the receipt did not have a "Change given:" line (near the bottom, before the "Account balance as on date:" line). 3. After the patch, it now has this line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204789|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 206704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206704&action=edit Bug 43288: Fix change amount missing from printed fee receipts pay.tt, paycollect.tt and boraccount.tt all open printfeercpt.pl with a change_given= query parameter after a payment, but printfeercpt.pl only ever reads a 'change' param into its GetPreparedLetter substitute hash - matching the ACCOUNT_CREDIT/CREDIT_* default notice templates, which use [% change | $Price %], not [% change_given | $Price %]. As a result the change amount is silently blank on every printed fee receipt that shows it, regardless of FinePaymentAutoPopup. Rather than touch printfeercpt.pl or the notice content (both already agree on 'change', matching a similar migration Koha did once before in installer/data/mysql/db_revs/220600072.pl going the same direction), fix the three query strings that build the printfeercpt.pl URL to send change= instead of change_given=. The change_given variable name is kept everywhere else (form fields, JS locals, Perl params) since this is purely about the query key at the printfeercpt.pl boundary. Test plan: 1) Set FinePaymentAutoPopup to 'show' 2) Take a payment for a patron via members/pay.pl or members/paycollect.pl that generates change (fine amount not evenly covered by cash tendered) 3) Note the auto-popped-up receipt shows the change amount (before this patch, the Change line was always blank) 4) Repeat via the boraccount.pl > printfeercpt.pl print receipt route Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43288 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org