[Bug 30941] New: Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Bug ID: 30941 Summary: Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 135937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135937&action=edit Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) Test plan: 1. Configure the default MARC framework to use those value builders: - unimarc_field_146b for 146$b - unimarc_field_146c for 146$c - unimarc_field_146d for 146$d - unimarc_field_146e for 146$e - unimarc_field_146f for 146$f 2. Verify that they all work correctly according to https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135937|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 136000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136000&action=edit Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) Test plan: 1. Configure the default MARC framework to use those value builders: - unimarc_field_146b for 146$b - unimarc_field_146c for 146$c - unimarc_field_146d for 146$d - unimarc_field_146e for 146$e - unimarc_field_146f for 146$f 2. Verify that they all work correctly according to https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.... Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): 1. I didn't check the "Category of instrument or voice" fully against https://www.iflastandards.info/unimarc/terms/mop 2. Everything else seemed to work as expected. This may require someone who is ore familiar with UNIMARC to sign off as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds value release notes| |builders for UNIMARC 146$b, | |$c, $d, $e, and $f. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136000|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139478&action=edit Bug 30941: (QA follow-up) Add exec flag to scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139478|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139483&action=edit Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) Test plan: 1. Configure the default MARC framework to use those value builders: - unimarc_field_146b for 146$b - unimarc_field_146c for 146$c - unimarc_field_146d for 146$d - unimarc_field_146e for 146$e - unimarc_field_146f for 146$f 2. Verify that they all work correctly according to https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.... Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139484&action=edit Bug 30941: (QA follow-up) Add exec flag to scripts Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 139488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139488&action=edit Bug 30941: (QA follow-up) Import methods explicitly By explicitly importing the Koha::I18N methods, I get rid of this error: kohadev-koha@kohadevbox:/kohadevbox/koha$ qa -c 2 --run-tests testing 2 commit(s) (applied to 9b2bf04 '09 Bug 30507: Value builder for field') Processing files before patches |========================>| 12 / 12 (100.00%) An error occurred : Inconsistent hierarchy during C3 merge of class 'Koha::I18N': current merge results [ Koha::I18N, ] merging failed on 'Exporter' at /kohadevbox/qa-test-tools/koha-qa.pl line 112. This happens because the Koha::I18N library is exporting all its methods explicitly and, by design, the __ methods used in value builders cannot determine which of the imported methods to use i.e. if Koha::I118N::__ or Koha::CodeList::Unimarc::MediumOfPerformance:__ Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 139497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139497&action=edit Bug 30941: (QA follow-up) Only export what is needed Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be in 22.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org