[Bug 36665] New: Autolocation and IP Recognition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Bug ID: 36665 Summary: Autolocation and IP Recognition Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: olivier.delangle@univ-amu.fr QA Contact: testopia@bugs.koha-community.org Since the modification of the Autolocation syspref functionality, the previous feature is no longer possible. A new syspref should be implemented to restore it, meaning: for terminals with IPs declared for the branch, the connection to the professional interface defaults to the IP's branch rather than the member's affiliated branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 olivier.delangle@univ-amu.fr changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26176 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 olivier.delangle@univ-amu.fr changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35890 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- At a glance, it looks like AutoLocation is working the same. Can you be more specific about the issue you're having? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Wait... I think I understand you. You mean you weren't using AutoLocation to try to restrict logins? You were just trying to use AutoLocation to force the branch of the session to the branch of the physical location (as designated by the IP address). So arguably that desired functionality would be AutoLocation and the restricting by IP address would be renamed as per bug 26176. -- That's an interesting idea. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #3 from olivier.delangle@univ-amu.fr --- That's right. This feature allowed individuals not affiliated with the library to work there without having to switch branch with each session. This is particularly useful, of course, in networks composed of multiple libraries. It was indeed very useful and practical. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Depends on| |35918 Severity|enhancement |critical --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I am raising the severity here. Before bug 35918 if a library specified IPs in the branches table a user would be logged in to the correct branch based on their IP when AutoLocation was disabled Now, this does not happen. If AutoLocation is enabled, the user can only log in if their current IP matches the branch in their account. This is a huge behavior change and negatively affects large consortia where staff travel between branches Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35918 [Bug 35918] Incorrect library used when AutoLocation configured using the same IP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |Main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166889&action=edit Bug 36665: Add option to set the staff user's logged in branch based on their current ip This patch adds a new system preference StaffLoginBranchBasedOnIP which restores the behaviour before bug 35918 of using the current IP to determine the user's logged in branchcode To test: 1 - Get your current ip 2 - Set that IP for a library in the administration section 3 - Find a user account assigned to a different library that can login to staff side 4 - Login to staff as that user, select 'My library' 5 - You are logged in to the user's branch 6 - Apply patch, restart all 7 - Log out and back in, selecting 'My library' 8 - You are logged in to the user's branch 9 - Enable new system preference StaffLoginBranchBasedOnIP 9 - Log out and back in, selecting a different branch, noting the new warning below the library selection 10 - You are logged in to the branch with the matching IP 11 - Log out and back in, selecting 'My library' 10 - You are logged in to the branch with the matching IP 11 - Change your logged in branch 12 - Verify the selection sticks and you can perform staff actions in the chosen branch 13 - Change the IP of the library to one that doesn't match yours 14 - Verify you can log out and log back in and that selected branch is respected when your IP doesn't match library IP -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166889|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166904&action=edit Bug 36665: Add option to set the staff user's logged in branch based on their current ip This patch adds a new system preference StaffLoginBranchBasedOnIP which restores the behaviour before bug 35918 of using the current IP to determine the user's logged in branchcode To test: 1 - Get your current ip 2 - Set that IP for a library in the administration section 3 - Find a user account assigned to a different library that can login to staff side 4 - Login to staff as that user, select 'My library' 5 - You are logged in to the user's branch 6 - Apply patch, restart all 7 - Log out and back in, selecting 'My library' 8 - You are logged in to the user's branch 9 - Enable new system preference StaffLoginBranchBasedOnIP 9 - Log out and back in, selecting a different branch, noting the new warning below the library selection 10 - You are logged in to the branch with the matching IP 11 - Log out and back in, selecting 'My library' 10 - You are logged in to the branch with the matching IP 11 - Change your logged in branch 12 - Verify the selection sticks and you can perform staff actions in the chosen branch 13 - Change the IP of the library to one that doesn't match yours 14 - Verify you can log out and log back in and that selected branch is respected when your IP doesn't match library IP Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Just quickly looked at the code but are you sure the auth failed condition ($auth_state ne 'failed') shouldn't be included as well for StaffLoginBranchBasedOnIP? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #7)
Just quickly looked at the code but are you sure the auth failed condition ($auth_state ne 'failed') shouldn't be included as well for StaffLoginBranchBasedOnIP?
I don't think it matters - at this point in the code valid credentials were passed ( $return > 0 ) We would prevent the login if permissions are wrong , or for autlocation - for wrong permissions I think it is correct to still set the branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166904|0 |1 is obsolete| | --- Comment #9 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166941&action=edit Bug 36665: Add option to set the staff user's logged in branch based on their current ip This patch adds a new system preference StaffLoginBranchBasedOnIP which restores the behaviour before bug 35918 of using the current IP to determine the user's logged in branchcode To test: 1 - Get your current ip 2 - Set that IP for a library in the administration section 3 - Find a user account assigned to a different library that can login to staff side 4 - Login to staff as that user, select 'My library' 5 - You are logged in to the user's branch 6 - Apply patch, restart all 7 - Log out and back in, selecting 'My library' 8 - You are logged in to the user's branch 9 - Enable new system preference StaffLoginBranchBasedOnIP 9 - Log out and back in, selecting a different branch, noting the new warning below the library selection 10 - You are logged in to the branch with the matching IP 11 - Log out and back in, selecting 'My library' 10 - You are logged in to the branch with the matching IP 11 - Change your logged in branch 12 - Verify the selection sticks and you can perform staff actions in the chosen branch 13 - Change the IP of the library to one that doesn't match yours 14 - Verify you can log out and log back in and that selected branch is respected when your IP doesn't match library IP Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Summary|Autolocation and IP |Auto location and IP |Recognition |recognition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. At least since bug 35918 we took care of having the selected library at the beginning on the array and so this library will be picked first if matched. I think we should improve the syspref's description to clarify what "first" really means here. For discussion: shouldn't we list patron's library as well? uniq(selected_library, patron's library, other libraries) 2. I think AutoLocation should be renamed, we are adding more confusion about its purpose with this new syspref. 3. We should have all this code inside a `if ($type ne 'opac')` block. It seems that we don't use this branch or branchname TT var in the OPAC but it would be better to not pass it at all it seems (existed prior to this patch). I understand that you consider this critical and that you even bypass proper QA but maybe those remarks can be addressed on a separate bug, or at least we need plans for the next steps? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26176 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26176 [Bug 26176] AutoLocation is badly named -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have to admit, I am not sure I understand all the comments. So I will just ask: Nick and Joubu - is this ready for push? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #12 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #10)
1. At least since bug 35918 we took care of having the selected library at the beginning on the array and so this library will be picked first if matched. I think we should improve the syspref's description to clarify what "first" really means here. For discussion: shouldn't we list patron's library as well? uniq(selected_library, patron's library, other libraries)
Looking into the code, it seems 35918 uses the patron's library OR the selected library first, but it looks like the rest of the array is still taken unordered from the hash? I will file a follow-up bug for this
2. I think AutoLocation should be renamed, we are adding more confusion about its purpose with this new syspref.
We have bug 26176 open for this, I will look into supplying a patch
3. We should have all this code inside a `if ($type ne 'opac')` block. It seems that we don't use this branch or branchname TT var in the OPAC but it would be better to not pass it at all it seems (existed prior to this patch).
That makes sense, I went about restoring the previous functionality as closely as possible, but can provide a follow-up here to wrap the opac test around all the code
I understand that you consider this critical and that you even bypass proper QA but maybe those remarks can be addressed on a separate bug, or at least we need plans for the next steps?
I am not sure what steps here bypassed proper QA? A QA team member signed off the bug - we then got a sign off from a community member (we attached the sign off as they had issues using the sandboxes) and upgraded, with their permission, the QA team members SO to QA. That discussion could have been included on the bug, but I thought it was straightforward enough to simply reorder the sign offs. I will file to follow-ups, but if you think this needs more attention feel free to change the status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166941|0 |1 is obsolete| | --- Comment #13 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166963&action=edit Bug 36665: Add option to set the staff user's logged in branch based on their current ip This patch adds a new system preference StaffLoginBranchBasedOnIP which restores the behaviour before bug 35918 of using the current IP to determine the user's logged in branchcode To test: 1 - Get your current ip 2 - Set that IP for a library in the administration section 3 - Find a user account assigned to a different library that can login to staff side 4 - Login to staff as that user, select 'My library' 5 - You are logged in to the user's branch 6 - Apply patch, restart all 7 - Log out and back in, selecting 'My library' 8 - You are logged in to the user's branch 9 - Enable new system preference StaffLoginBranchBasedOnIP 9 - Log out and back in, selecting a different branch, noting the new warning below the library selection 10 - You are logged in to the branch with the matching IP 11 - Log out and back in, selecting 'My library' 10 - You are logged in to the branch with the matching IP 11 - Change your logged in branch 12 - Verify the selection sticks and you can perform staff actions in the chosen branch 13 - Change the IP of the library to one that doesn't match yours 14 - Verify you can log out and log back in and that selected branch is respected when your IP doesn't match library IP Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #14 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166964&action=edit Bug 36665: (follow-up) Wrap code block in type ne 'opac' conditional -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a new release notes| |system preference | |"StaffLoginBranchBasedOnIP" | |which, when enabled, will | |set the logged in | |branchcode to a branch with | |an IP setting matching the | |current users IP. This | |preference will be | |overridden if | |"AutoLocation" is enabled, | |as that preference will | |enforce the user selecting | |a branch that matches their | |current IP or signing into | |their homebranch from the | |correct IP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the|This patch adds a new |This patch adds a new release notes|system preference |system preference |"StaffLoginBranchBasedOnIP" |"StaffLoginBranchBasedOnIP" |which, when enabled, will |which, when enabled, will |set the logged in |set the logged in library |branchcode to a branch with |to the library with an IP |an IP setting matching the |setting matching the |current users IP. This |current users IP. This |preference will be |preference will be |overridden if |overridden if |"AutoLocation" is enabled, |"AutoLocation" is enabled, |as that preference will |as that preference will |enforce the user selecting |enforce the user selecting |a branch that matches their |a library that matches |current IP or signing into |their current IP or signing |their homebranch from the |into their home library |correct IP. |from the correct IP. --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This adds strings as it adds a new system preference - I'd still make an exception, but since it's a bit of a "risky area" and we don't want to break something else - could we get another sign-off? (must not be from QA team, but testing the different pref combinations would be great) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36908 [Bug 36908] Clarify and standardize the behavior of AutoLocation/ StaffLoginBranchBasedOnIP system preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Nick Clemens (kidclamp) from comment #12)
(In reply to Jonathan Druart from comment #10)
I understand that you consider this critical and that you even bypass proper QA but maybe those remarks can be addressed on a separate bug, or at least we need plans for the next steps?
I am not sure what steps here bypassed proper QA? A QA team member signed off the bug - we then got a sign off from a community member (we attached the sign off as they had issues using the sandboxes) and upgraded, with their permission, the QA team members SO to QA. That discussion could have been included on the bug, but I thought it was straightforward enough to simply reorder the sign offs. I will file to follow-ups, but if you think this needs more attention feel free to change the status.
Personally if I add my signoff on a bug I don't necessarily do a proper code review. If I do signoff bug, don't swap it for a QA stamp :) Thanks for the follow-up bugs! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- What's now the expected behaviour for AutoLocation? In my understanding AutoLocation is now only used for IP restriction. So I think there is a bug. * AutoLocation = yes, StaffLoginBranchBasedOnIP = no * set CPL's IPto your IP and use koha/CPL to login but select another library => CPL is used (expected: the selected library) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #18 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #17)
What's now the expected behaviour for AutoLocation? In my understanding AutoLocation is now only used for IP restriction.
So I think there is a bug.
* AutoLocation = yes, StaffLoginBranchBasedOnIP = no * set CPL's IPto your IP and use koha/CPL to login but select another library => CPL is used (expected: the selected library)
Does the user have 'loggedinlibrary' permission? Without that the chosen branch is not respected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #19 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #17)
What's now the expected behaviour for AutoLocation? In my understanding AutoLocation is now only used for IP restriction.
If AutoLocation is enabled: If the user has loggedinlibrary permission: If the chosen branch has an ip: the user will be denied login unless IP matches they will be logged in to chosen library if IP matches If the chosen branch has no ip: the user will be logged in at chosen branch If no library is chosen: If the user's branch has an ip: the user will be denied login unless IP matches they will be logged in to homebranch if matches If the user's branch has no IP: the user will be signed in to their homebranch If the user does not have loggedinlibrary permission: Their chosen branch will be ignored - i.e. choosing or not, homebranch will be used If their homebranch has an IP: they will be denied login unless IP matches they will be logged in to their homebranch if IP matches If their homebranch has no IP: they will be logged in to their homebranch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Nick Clemens (kidclamp) from comment #19)
(In reply to Jonathan Druart from comment #17)
What's now the expected behaviour for AutoLocation? In my understanding AutoLocation is now only used for IP restriction.
I am using koha/superlibrarian/CPL CPL has an IP, IPT has not. I select IPT on the login screen.
If AutoLocation is enabled: # Yes, turned ON If the user has loggedinlibrary permission: # Yes, koha is superlibrarian If the chosen branch has no ip: # IPT has no IP the user will be logged in at chosen branch
=> KO I am logged in at CPL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We are running out of time and it feels like there are still some question marks. Could we aim for this and the follow-ups to make it into 24.05.01 maybe? (if RMaint agrees?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Set to Failed QA, to keep overview of my queue. Waiting for Nick. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #23 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #20)
(In reply to Nick Clemens (kidclamp) from comment #19)
(In reply to Jonathan Druart from comment #17)
What's now the expected behaviour for AutoLocation? In my understanding AutoLocation is now only used for IP restriction.
I am using koha/superlibrarian/CPL CPL has an IP, IPT has not. I select IPT on the login screen.
If AutoLocation is enabled: # Yes, turned ON If the user has loggedinlibrary permission: # Yes, koha is superlibrarian If the chosen branch has no ip: # IPT has no IP the user will be logged in at chosen branch
=> KO I am logged in at CPL
I had that wrong: You aren't blocked from signing in because IPT has no IP, but when AutoLocation is checked then you are assigned to the matching branch - this is true before and after my patch - i.e. I am not changing behaviour. I think we should expand this case into tests on bug 36908 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- As we are splitting the 2 "features" on this one (36665) I think we should deal with that here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- I am not blocking this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #26 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 167035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167035&action=edit Bug 36665: (follow-up) Allow choosing a branch with no IP when using AutoLocation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167035|0 |1 is obsolete| | --- Comment #27 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 167036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167036&action=edit Bug 36665: (follow-up) Allow choosing a branch with no IP when using AutoLocation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166963|0 |1 is obsolete| | Attachment #166964|0 |1 is obsolete| | Attachment #167036|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 167037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167037&action=edit Bug 36665: Add option to set the staff user's logged in branch based on their current ip This patch adds a new system preference StaffLoginBranchBasedOnIP which restores the behaviour before bug 35918 of using the current IP to determine the user's logged in branchcode To test: 1 - Get your current ip 2 - Set that IP for a library in the administration section 3 - Find a user account assigned to a different library that can login to staff side 4 - Login to staff as that user, select 'My library' 5 - You are logged in to the user's branch 6 - Apply patch, restart all 7 - Log out and back in, selecting 'My library' 8 - You are logged in to the user's branch 9 - Enable new system preference StaffLoginBranchBasedOnIP 9 - Log out and back in, selecting a different branch, noting the new warning below the library selection 10 - You are logged in to the branch with the matching IP 11 - Log out and back in, selecting 'My library' 10 - You are logged in to the branch with the matching IP 11 - Change your logged in branch 12 - Verify the selection sticks and you can perform staff actions in the chosen branch 13 - Change the IP of the library to one that doesn't match yours 14 - Verify you can log out and log back in and that selected branch is respected when your IP doesn't match library IP Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 167038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167038&action=edit Bug 36665: (follow-up) Wrap code block in type ne 'opac' conditional Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 167039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167039&action=edit Bug 36665: (follow-up) Allow choosing a branch with no IP when using AutoLocation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com --- Comment #32 from Laura O'Neil <laura@bywatersolutions.com> --- Can this be backported to 23.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26176 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26176 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26176 [Bug 26176] AutoLocation is badly named -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #33 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 167117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167117&action=edit Bug 36665: (follow-up) Default preference to enabled While this is a new preference, this was the standard behavior for a long time. I think we should default to enabled to restore previous behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #34 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Moving to PQA for attention on follow-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds a new |This patch adds a new release notes|system preference |system preference |"StaffLoginBranchBasedOnIP" |"StaffLoginLibraryBasedOnIP |which, when enabled, will |" which, when enabled, will |set the logged in library |set the logged in library |to the library with an IP |to the library with an IP |setting matching the |setting matching the |current users IP. This |current users IP. This |preference will be |preference will be |overridden if |overridden if |"AutoLocation" is enabled, |"AutoLocation" is enabled, |as that preference will |as that preference will |enforce the user selecting |enforce the user selecting |a library that matches |a library that matches |their current IP or signing |their current IP or signing |into their home library |into their home library |from the correct IP. |from the correct IP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.06 released in| | --- Comment #36 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 I had to remove from DBRev : -use Koha::Installer::Output qw(say_warning say_failure say_success say_info); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #37 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/975 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #38 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 Bug 36665 depends on bug 35918, which changed state. Bug 35918 Summary: Incorrect library used when AutoLocation configured using the same IP https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35918 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org