[Koha-bugs] [Bug 36665] Autolocation and IP Recognition

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665 --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #7)

Just quickly looked at the code but are you sure the auth failed condition ($auth_state ne 'failed') shouldn't be included as well for StaffLoginBranchBasedOnIP?

I don't think it matters - at this point in the code valid credentials were passed ( $return > 0 ) We would prevent the login if permissions are wrong , or for autlocation - for wrong permissions I think it is correct to still set the branch -- You are receiving this mail because: You are watching all bug changes.