[Bug 39874] New: Template error prevents authority merging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 Bug ID: 39874 Summary: Template error prevents authority merging Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org Depends on: 39325 Bug 39325 renamed the variable used inside of the FOREACH, but one of the instances was unchanged: [% FOREACH line IN result %] <tr data-authid="[% result.authid | html %]"> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 [Bug 39325] Run codespell successfully on the whole codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182261&action=edit Bug 39874: Correct template variable name to fix authority merging This patch correct a template variable name so that the authority record ID is correctly included in the search results table markup. To test, apply the patch and go to Authorities. - Perform a search which will return more than one result. - On one of the results, click Actions -> Merge. - An message should appear at the top, "Merging with authority..." and the authority record ID should be shown in parentheses. - Pick another record in the results list to merge, click Actions -> Merge. - You should be redirected to the "Merging records" page, with the correct two records shown under "Merge reference." Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182261|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 182275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182275&action=edit Bug 39874: Correct template variable name to fix authority merging This patch correct a template variable name so that the authority record ID is correctly included in the search results table markup. To test, apply the patch and go to Authorities. - Perform a search which will return more than one result. - On one of the results, click Actions -> Merge. - An message should appear at the top, "Merging with authority..." and the authority record ID should be shown in parentheses. - Pick another record in the results list to merge, click Actions -> Merge. - You should be redirected to the "Merging records" page, with the correct two records shown under "Merge reference." Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes merging release notes| |authority records. It was | |not possible to merge | |authority records after bug | |39325 (this only affects | |Koha 25.05/main). CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Thanks Owen for fixing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182275|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182278&action=edit Bug 39874: Correct template variable name to fix authority merging This patch correct a template variable name so that the authority record ID is correctly included in the search results table markup. To test, apply the patch and go to Authorities. - Perform a search which will return more than one result. - On one of the results, click Actions -> Merge. - An message should appear at the top, "Merging with authority..." and the authority record ID should be shown in parentheses. - Pick another record in the results list to merge, click Actions -> Merge. - You should be redirected to the "Merging records" page, with the correct two records shown under "Merge reference." Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 [Bug 25318] Convert authorities_js.inc to JavaScript file with translatable strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 39325 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #7 from David Nind <david@davidnind.com> --- Bug fix. No change required to the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 Bug 39874 depends on bug 39325, which changed state. Bug 39325 Summary: Run codespell successfully on the whole codebase https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org