[Bug 38461] New: Table features needs to be covered by e2e tests - Cypress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Bug ID: 38461 Summary: Table features needs to be covered by e2e tests - Cypress Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 36640 We need UI tests for the table features. We have different kinds of table and a lot of features that must be covered by tests. 3 types of table: * Tables using the REST API (kohaTable) * Tables not using the REST API (KohaTable) * Tables using dataTables constructor directly (should be removed by bug 38255) Features: * Save state * Copy shareable link * Save configuration state on page change * Save search state on page change: * Export * Search (and the 'Clear filters' button) * Columns filters * External filters * etc. Specific tables: * Patrons search * Items list (catalogue/detail.pl) * Items search * Pending requests (should not be different but it is) * Libraries ("classic" using kohaTable) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38503 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 [Bug 38503] Add a Cypress task to generate objects based on its swagger def spec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38506 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38506 [Bug 38506] Patrons search - get libraries and categories from the REST API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174877&action=edit Bug 38461: Add tests for 'Clear filter' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174878&action=edit Bug 38461: Use buildSampleObjects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174877|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175004&action=edit Bug 38461: Add tests for 'Clear filter' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174878|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175005&action=edit Bug 38461: Use buildSampleObjects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175006&action=edit Bug 38461: Columns - All, is_hidden by default, then shown by user -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175007&action=edit Bug 38461: Save state ON/OFF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175008&action=edit Bug 38461: Refactoring - build_libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175009&action=edit Bug 38461: Refactoring - mock_table_settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175010&action=edit Bug 38461: Shareable link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175011&action=edit Bug 38461: Jump to the configuration page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- I am getting random failures, Cypress bugs? Test "Shareable link": * "Write permission denied" (not allowed to write to navigator.clipboard) * "Document is not focused" when trying to click on the "Copy shareable link" button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175015&action=edit Bug 38461: Fix ramdom failures All this is weird. I found this an implemented it: https://stackoverflow.com/questions/69425289/javascript-prompt-cause-documen... It was still not enough for reduced the failures. The wait and adding the focus to the window seems ok. If I remove one of those 3 hacks, I still get failures... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #12)
Created attachment 175015 [details] [review] Bug 38461: Fix ramdom failures
All this is weird. I found this an implemented it: https://stackoverflow.com/questions/69425289/javascript-prompt-cause- document-is-not-focused It was still not enough for reduced the failures. The wait and adding the focus to the window seems ok. If I remove one of those 3 hacks, I still get failures...
Ho well, I just got the error now.. " > Document is not focused." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175016&action=edit Bug 38461: Bypass the clipboard for tests There are known bugs with Cypress trying to play with the clipboard, and I don't manage to make the tests pass consistently (also tried realClick from cypress-real-events) Here I am suggesting to not click on the button, but simply retrieve the url (which needs a bit of work in the existing code). We don't test the "Copied!" tooltip and the behaviour of the button, but at least the tests pass! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|38506 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38506 [Bug 38506] Patrons search - get libraries and categories from the REST API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38506 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175179&action=edit Bug 38461: Add tests for catalogue/detail/holdings_table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Obviously more tests are always needed, but this can go as it for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #17 from David Nind <david@davidnind.com> --- I'm not sure if I tested this correctly, but the tests no longer pass for me: 1. Before the patch, the current tests pass: yarn cypress run --spec t/cypress/integration/KohaTable_spec.ts 2. Apply the patch and restart everything. 3. Run: yarn install 4. Rerun the tests - 1 test is failing: 1) Hit all tables catalogue/detail/holdings_table correctly init: ReferenceError: restdefaultpagesize is not defined at Context.eval (webpack://koha/./t/cypress/integration/KohaTable_spec.ts:487:23) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175004|0 |1 is obsolete| | --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175223&action=edit Bug 38461: Add tests for 'Clear filter' Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175005|0 |1 is obsolete| | --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175224&action=edit Bug 38461: Use buildSampleObjects Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175006|0 |1 is obsolete| | --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175225&action=edit Bug 38461: Columns - All, is_hidden by default, then shown by user Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175007|0 |1 is obsolete| | --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175226&action=edit Bug 38461: Save state ON/OFF Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175008|0 |1 is obsolete| | --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175227&action=edit Bug 38461: Refactoring - build_libraries Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175009|0 |1 is obsolete| | --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175228&action=edit Bug 38461: Refactoring - mock_table_settings Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175010|0 |1 is obsolete| | --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175229&action=edit Bug 38461: Shareable link Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175011|0 |1 is obsolete| | --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175230&action=edit Bug 38461: Jump to the configuration page Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175015|0 |1 is obsolete| | --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175231&action=edit Bug 38461: Fix ramdom failures All this is weird. I found this an implemented it: https://stackoverflow.com/questions/69425289/javascript-prompt-cause-documen... It was still not enough for reduced the failures. The wait and adding the focus to the window seems ok. If I remove one of those 3 hacks, I still get failures... Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175016|0 |1 is obsolete| | --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175232&action=edit Bug 38461: Bypass the clipboard for tests There are known bugs with Cypress trying to play with the clipboard, and I don't manage to make the tests pass consistently (also tried realClick from cypress-real-events) Here I am suggesting to not click on the button, but simply retrieve the url (which needs a bit of work in the existing code). We don't test the "Copied!" tooltip and the behaviour of the button, but at least the tests pass! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175179|0 |1 is obsolete| | --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175233&action=edit Bug 38461: Add tests for catalogue/detail/holdings_table Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #29 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175234&action=edit Bug 38461: Fix multiple case changes that broke variables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor@tuxayo.net --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! :) 25 runs without issue with the default electron browser. And with Bug 38503 with the patches that remove @vue/cli-service and babel. Further reinforcing the idea that there is no dependency on them. It also worked with @vue/cli-service and babel. ------- There were very weird issues with variables being lowercased and thus not matching there declaration. That's the commit I added. Are the patches here the latest version you have locally Jonathan? (in case there is commit mixup) @David: that's the issue you encountered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Nind from comment #17)
1) Hit all tables catalogue/detail/holdings_table correctly init: ReferenceError: restdefaultpagesize is not defined at Context.eval (webpack://koha/./t/cypress/integration/KohaTable_spec.ts:487:23)
Victor fixed it in the last patch. Not sure what happened here. My editor did something wrong when saving the file it seems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175234|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175235&action=edit Bug 38461: Fix multiple case changes that broke variables Amended-by: Jonathan Druart - "x-base-total-count": baseTotalCount, - "x-total-count": baseTotalCount, + "X-Base-Total-Count": baseTotalCount, + "X-Total-Count": baseTotalCount, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #33 from Victor Grousset/tuxayo <victor@tuxayo.net> --- About comment 11 and it's consequences, I did some experiments: (to hopefully not end up with the same kind of struggles as with Selenium) I tried to change the browser: With Firefox 128 with the fixes for random failures still applied Run 1: One column hidden by default: TypeError: win is undefined at ./t/cypress/integration/KohaTable_spec.ts/</ (webpack://koha/./t/cypress/integration/KohaTable_spec.ts:58:12) Input search bar and clear filter : AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Showing 1 to 20 of 42 entries' within the element: <div.dt-info> but never did. at ./t/cypress/integration/KohaTable_spec.ts/</</ (webpack://koha/./t/cypress/integration/KohaTable_spec.ts:370:56) Run 2: AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Showing 1 to 20 of 42 entries' within the element: <div.dt-info> but never did. at ./t/cypress/integration/KohaTable_spec.ts/</</ (webpack://koha/./t/cypress/integration/KohaTable_spec.ts:370:56) Looks like it consistently not pass and has some random failure of it's own. ----- With Chromium 120 with the fixes for random failures still applied: 2 passes at least. With Chromium 120 with the 2 patches reverted: In 3 runs, that same error: Shareable link: AssertionError: Timed out retrying after 10000ms: Expected to find element: `.tooltip`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/KohaTable_spec.ts:278:23) So it doesn't pass consistently either. Next lead: update Cypress, it's a bit old. And so is Electron. But before that, I still can't reproduce the comment 11 issues. I'm at 105 runs. So far I got these unrelated issues: -------------------------------------------------------------------- 1) kohaTable (using REST API) Simple tables "before each" hook for "Jump to the configuration page": CypressError: Cypress detected that you returned a promise from a command while also invoking one or more cy commands in that promise. The command that returned the promise was:
`cy.visit()`
The cy command you invoked inside the promise was:
`cy.login()`
Because Cypress commands are already promise-like, you don't need to wrap them or return your own promise. Cypress will resolve your command with whatever the final Cypress command yields. The reason this is an error instead of a warning is because Cypress internally queues commands serially whereas Promises execute as soon as they are invoked. Attempting to reconcile this would prevent Cypress from ever resolving. https://on.cypress.io/returning-promise-and-commands-in-another-command Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `kohaTable (using REST API)` at cy.<computed> [as login] (http://localhost:8081/__cypress/runner/cypress_runner.js:137643:64) From Your Spec Code: at eval (webpack://koha/./t/cypress/integration/KohaTable_spec.ts:282:24) ---------------------------------------------------- 1) Hit all tables catalogue/detail/holdings_table correctly init: CypressError: The following error originated from your test code, not from Cypress. It was caused by an unhandled promise rejection.
Timed out after waiting `60000ms` for your remote page to load.
Your page did not fire its `load` event within `60000ms`. You can try increasing the `pageLoadTimeout` value in `kohadevbox/koha/cypress.config.ts` to wait longer. Browsers will not fire the `load` event until all stylesheets and scripts are done downloading. When this `load` event occurs, Cypress will continue running commands. When Cypress detects uncaught errors originating from your test code it will automatically fail the current test. at timedOutWaitingForPageLoad (http://localhost:8081/__cypress/runner/cypress_runner.js:129355:64) at <unknown> (http://localhost:8081/__cypress/runner/cypress_runner.js:130329:16) at tryCatcher (http://localhost:8081/__cypress/runner/cypress_runner.js:1807:23) at <unknown> (http://localhost:8081/__cypress/runner/cypress_runner.js:4186:41) at tryCatcher (http://localhost:8081/__cypress/runner/cypress_runner.js:1807:23) at Promise._settlePromiseFromHandler (http://localhost:8081/__cypress/runner/cypress_runner.js:1519:31) at Promise._settlePromise (http://localhost:8081/__cypress/runner/cypress_runner.js:1576:18) at Promise._settlePromise0 (http://localhost:8081/__cypress/runner/cypress_runner.js:1621:10) at Promise._settlePromises (http://localhost:8081/__cypress/runner/cypress_runner.js:1697:18) at _drainQueueStep (http://localhost:8081/__cypress/runner/cypress_runner.js:2407:12) at _drainQueue (http://localhost:8081/__cypress/runner/cypress_runner.js:2400:9) at Async._drainQueues (http://localhost:8081/__cypress/runner/cypress_runner.js:2416:5) at Async.drainQueues (http://localhost:8081/__cypress/runner/cypress_runner.js:2286:14) From Your Spec Code: at Context.eval (webpack://koha/./t/cypress/integration/KohaTable_spec.ts:518:19) From Your Spec Code: at Context.eval (webpack://koha/./t/cypress/integration/KohaTable_spec.ts:518:19) ---------------------------------------------------- "before each" hook for "Jump to the configuration page": Timed out retrying after 10000ms + expected - actual -'Session timed out › Log in to Koha › Koha' +'Koha staff interface' at Context.eval (webpack://koha/./t/cypress/integration/KohaTable_spec.ts:56:19) ---------------------------------------------------- Is there hope that none of our different issues happen in CI? So we could try our chances without the commits - Fix ramdom failures (2.89 KB, patch) - Bypass the clipboard for tests to keep the test code the simplest. And add them if the CI shows the same errors. -------------------- I almost forgot: you could try updating cypress&electron and it might help to get away with the simplest version of these patches. And it needs updates anyway because Electron 106 would be Chromium from September 27, 2022 -------------------------- Hopefully there are some things helpful in all this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #34 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #31)
(In reply to David Nind from comment #17)
1) Hit all tables catalogue/detail/holdings_table correctly init: ReferenceError: restdefaultpagesize is not defined at Context.eval (webpack://koha/./t/cypress/integration/KohaTable_spec.ts:487:23)
Victor fixed it in the last patch. Not sure what happened here. My editor did something wrong when saving the file it seems.
Thanks Jonathan, and Victor! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #35 from Victor Grousset/tuxayo <victor@tuxayo.net> --- 535 runs in total without any relevant error it seems >_< (without "Fix ramdom failures" and "Bypass the clipboard for tests") Turns out a slow PC isn't enough to reproduce all the random fails :( One more new wack error: Timeout in localhost?! --------------------------- Shareable link: CypressError: `cy.visit()` failed trying to load: http://localhost:8081/cgi-bin/koha/admin/branches.pl We attempted to make an http request to this URL but the request failed without a response. We received this error at the network level:
Error: ESOCKETTIMEDOUT
Common situations why this would fail: - you don't have internet access - you forgot to run / boot your web server - your web server isn't accessible - you have weird network configuration settings on your computer at <unknown> (http://localhost:8081/__cypress/runner/cypress_runner.js:130312:74) at visitFailedByErr (http://localhost:8081/__cypress/runner/cypress_runner.js:129704:12) at <unknown> (http://localhost:8081/__cypress/runner/cypress_runner.js:130311:11) at tryCatcher (http://localhost:8081/__cypress/runner/cypress_runner.js:1807:23) at Promise._settlePromiseFromHandler (http://localhost:8081/__cypress/runner/cypress_runner.js:1519:31) at Promise._settlePromise (http://localhost:8081/__cypress/runner/cypress_runner.js:1576:18) at Promise._settlePromise0 (http://localhost:8081/__cypress/runner/cypress_runner.js:1621:10) at Promise._settlePromises (http://localhost:8081/__cypress/runner/cypress_runner.js:1697:18) at _drainQueueStep (http://localhost:8081/__cypress/runner/cypress_runner.js:2407:12) at _drainQueue (http://localhost:8081/__cypress/runner/cypress_runner.js:2400:9) at Async._drainQueues (http://localhost:8081/__cypress/runner/cypress_runner.js:2416:5) at Async.drainQueues (http://localhost:8081/__cypress/runner/cypress_runner.js:2286:14) From Your Spec Code: at Context.eval (webpack://koha/./t/cypress/integration/KohaTable_spec.ts:239:19) --------------------------- And I got again the "Cypress detected that you returned a promise from a command while also invoking one or more cy commands in that promise. " ------ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #36 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Anyway, tldr it works and can be QAed. And there is hope to try updating cypress&electron (old from September 2022) to help to get away with the simplest version of these patches. But I can't try that so only can Jonathan or someone else getting also the issues from comment 11 (without the 2 relevant patches) --- Now that I think of it, my failed attempts with firefox and chromium are invalid because I kept a cypress older than the browsers... ---- minor errata: In a previous comment I copy pasted "Fix ramdom failures (2.89 KB, patch)" the last part is a mistake and not an emphasis the size of the patch. It's not relevant. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #37 from Victor Grousset/tuxayo <victor@tuxayo.net> --- additional info: still works if forgetting to upgrade node from 18 to 22. That's still a good opportunity to upgrade though. (to test, edit version in /etc/apt/sources.list.d/nodesource.list and then `sudo apt update;sudo install nodejs`) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #38 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #33)
Is there hope that none of our different issues happen in CI? So we could try our chances without the commits - Fix ramdom failures (2.89 KB, patch) - Bypass the clipboard for tests to keep the test code the simplest. And add them if the CI shows the same errors.
No, I don't want random failures. I need those tests to provide more DT enhancements, I don't want to fight random failures. I will deal with them later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175231|0 |1 is obsolete| | Attachment #175232|0 |1 is obsolete| | Attachment #175233|0 |1 is obsolete| | Attachment #175235|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175289&action=edit Bug 38461: Fix random failures All this is weird. I found this and implemented it: https://stackoverflow.com/questions/69425289/javascript-prompt-cause-documen... It was still not enough to reduce the failures. The wait and adding the focus to the window seems ok. If I remove one of those 3 hacks, I still get failures... Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #40 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175290&action=edit Bug 38461: Bypass the clipboard for tests There are known bugs with Cypress trying to play with the clipboard, and I don't manage to make the tests pass consistently (also tried realClick from cypress-real-events) Here I am suggesting to not click on the button, but simply retrieve the url (which needs a bit of work in the existing code). We don't test the "Copied!" tooltip and the behaviour of the button, but at least the tests pass! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #41 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175291&action=edit Bug 38461: Add tests for catalogue/detail/holdings_table Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175292&action=edit Bug 38461: Fix multiple case changes that broke variables Amended-by: Jonathan Druart - "x-base-total-count": baseTotalCount, - "x-total-count": baseTotalCount, + "X-Base-Total-Count": baseTotalCount, + "X-Total-Count": baseTotalCount, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #43 from Jonathan Druart <jonathan.druart@gmail.com> --- (fixed typos) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #44 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Test plan: 1. Apply patches and dependencies 2. Install node dependencies that come from bug 38503 sudo yarn install --modules-folder /kohadevbox/node_modules 3. cypress run --spec t/cypress/integration/KohaTable_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175223|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176082&action=edit Bug 38461: Add tests for 'Clear filter' Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175224|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176083&action=edit Bug 38461: Use buildSampleObjects Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175225|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176084&action=edit Bug 38461: Columns - All, is_hidden by default, then shown by user Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175226|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176085&action=edit Bug 38461: Save state ON/OFF Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175227|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176086&action=edit Bug 38461: Refactoring - build_libraries Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175228|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176087&action=edit Bug 38461: Refactoring - mock_table_settings Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175229|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176088&action=edit Bug 38461: Shareable link Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175230|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176089&action=edit Bug 38461: Jump to the configuration page Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175289|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176090&action=edit Bug 38461: Fix random failures All this is weird. I found this and implemented it: https://stackoverflow.com/questions/69425289/javascript-prompt-cause-documen... It was still not enough to reduce the failures. The wait and adding the focus to the window seems ok. If I remove one of those 3 hacks, I still get failures... Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175290|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176091&action=edit Bug 38461: Bypass the clipboard for tests There are known bugs with Cypress trying to play with the clipboard, and I don't manage to make the tests pass consistently (also tried realClick from cypress-real-events) Here I am suggesting to not click on the button, but simply retrieve the url (which needs a bit of work in the existing code). We don't test the "Copied!" tooltip and the behaviour of the button, but at least the tests pass! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175291|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176092&action=edit Bug 38461: Add tests for catalogue/detail/holdings_table Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175292|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176093&action=edit Bug 38461: Fix multiple case changes that broke variables Amended-by: Jonathan Druart - "x-base-total-count": baseTotalCount, - "x-total-count": baseTotalCount, + "X-Base-Total-Count": baseTotalCount, + "X-Total-Count": baseTotalCount, Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #57 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Code flows nicely and it's great to see the tests being added.. minor refactoring inline makes reasonable sense. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Table features needs to be |Table features needs to be |covered by e2e tests - |covered by e2e tests using |Cypress |Cypress -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #59 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176793&action=edit Bug 38461: Do not rely on biblio_id=1 It might not exist! This code is not trivial and should ideally be moved to somewhere it could be reused easily. But good enough for now to fix the failing tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up patch "Do not rely on biblio_id=1" pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #61 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176846&action=edit Bug 38461: (follow-up) Do not rely on biblio_id=1 19:05:50 koha_1 | "error": "Basic authentication disabled" We don't need to pass the auth in this request, we are authenticated already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bug 38461: (follow-up) Do not rely on biblio_id=1 pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #63 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176902&action=edit Bug 38461: (follow-up 2) Do not rely on biblio_id=1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #64 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #63)
Created attachment 176902 [details] [review] Bug 38461: (follow-up 2) Do not rely on biblio_id=1
There were 2 occurrences of authentication, sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed Status|Pushed to main |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #65 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (follow-up 2) pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Bug 38461 depends on bug 36640, which changed state. Bug 36640 Summary: Upgrade DataTables from 1.13.6 to 2.x https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #66 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 --- Comment #67 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 182697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182697&action=edit [24.11.x] Bug 38461: (follow-up) Fix tests This patch does two things: * Fixes a backport issue with 38461, making `mock_table_settings` have the right function signature, and accept (and use) the `table_settings_var` parameter. * Makes the scope for the `items_table_settings` variable be the window object, so it is accessible to Cypress for manipulation/mocking. This is done by changing `let` for `var` [1] To test: 1. Run: $ ktd --shell k$ run_cypress --spec t/cypress/integration/KohaTable_spec.ts => FAIL: Tests fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D [1] If you are curious about it, change it back to `let` and run the tests. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |tomascohen@gmail.com --- Comment #68 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- @PaulD you will need to backport the last patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #69 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #68)
@PaulD you will need to backport the last patch.
I see it is in 24.11.x : 7193d89c0a Bug 38461: (follow-up) Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #70 from David Nind <david@davidnind.com> --- No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461 Bug 38461 depends on bug 38503, which changed state. Bug 38503 Summary: Add a Cypress task to generate objects based on its swagger def spec https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38503 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org