[Bug 12598] New: Allow tools/import_borrowers.pl to be used from the command line.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Bug ID: 12598 Summary: Allow tools/import_borrowers.pl to be used from the command line. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Many libraries have the need to automate the importing of patrons into Koha from external sources. It would be nice if we could use Koha's own import_borrowers.pl to do that from the command line, in the same way as tools/export.pl can be used from both the staff interface and the command line. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29807&action=edit Bug 12598 - Allow tools/import_borrowers.pl to be used from the command line. Many libraries have the need to automate the importing of patrons into Koha from external sources. It would be nice if we could use Koha's own import_borrowers.pl to do that from the command line, in the same way as tools/export.pl can be used from both the staff interface and the command line. Test Plan: 1) Apply this patch 2) Test importing patrons from staff interface, no changes should be noted. 3) Test importing patrons from command line, options are availble with --help. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29807|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29808&action=edit Bug 12598 - Allow tools/import_borrowers.pl to be used from the command line. Many libraries have the need to automate the importing of patrons into Koha from external sources. It would be nice if we could use Koha's own import_borrowers.pl to do that from the command line, in the same way as tools/export.pl can be used from both the staff interface and the command line. Test Plan: 1) Apply this patch 2) Test importing patrons from staff interface, no changes should be noted. 3) Test importing patrons from command line, options are availble with --help. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29808|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29809&action=edit Bug 12598 - Allow tools/import_borrowers.pl to be used from the command line. Many libraries have the need to automate the importing of patrons into Koha from external sources. It would be nice if we could use Koha's own import_borrowers.pl to do that from the command line, in the same way as tools/export.pl can be used from both the staff interface and the command line. Test Plan: 1) Apply this patch 2) Test importing patrons from staff interface, no changes should be noted. 3) Test importing patrons from command line, options are availble with --help. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 5633 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I think this is a duplicate to bug 5633. There it was pointed out that normal scripts should not be command line scripts at the same time. Could you move this functionality into a separate command line script? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29809|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29939&action=edit Bug 12598 - Allow tools/import_borrowers.pl to be used from the command line. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #5)
Hi Kyle, I think this is a duplicate to bug 5633.
There it was pointed out that normal scripts should not be command line scripts at the same time. Could you move this functionality into a separate command line script?
I was not aware of that. Thanks for letting me know! Here is a new variant that is command line only and lives in misc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |bgkriegel@gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi, testing $ misc/import_borrowers.pl --help Can't locate object method "new" via package "CGI" at misc/import_borrowers.pl line 47 Why use CGI on a command line version? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #8)
Hi, testing
$ misc/import_borrowers.pl --help Can't locate object method "new" via package "CGI" at misc/import_borrowers.pl line 47
Why use CGI on a command line version?
That's a leftover, I'll remove that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29939|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30755&action=edit Bug 12598 - Allow tools/import_borrowers.pl to be used from the command line. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30755|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30780&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Summary|Allow |New |tools/import_borrowers.pl |misc/import_borrowers.pl |to be used from the command |command line tool |line. | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, I am sorry but this patch c/p almost all the code from tools/import_borrowers.pl. I am not sure this is the right way to do. The script should also use Pod2Usage (instead of the print_help routine). I am completely aware of the quantity of work to provide to reach a correct quality of core here: refactoring, unit tests, etc. But I am pretty sure this script should not be pushed as it. I let this bug report in the NQA queue in order to get more feedback. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #12)
Kyle, I am sorry but this patch c/p almost all the code from tools/import_borrowers.pl. I am not sure this is the right way to do.
That is why my initial patch allowed the existing tools/import_borrowers.pl script to be used from the command line. However, I was told that is no longer allowed ( tools/export.pl has this behavior ), though it is not stated in the coding guidelines.
The script should also use Pod2Usage (instead of the print_help routine).
Is this in the coding guidelines?
I am completely aware of the quantity of work to provide to reach a correct quality of core here: refactoring, unit tests, etc.
Not sure why this would be required for code we already know works... While I agree in general, this is proven code, and your proposal would add an order of magnitude to the development with no real gains. I would much prefer we allow tools/import_borrowers.pl to be used from the command line for this exact reason.
But I am pretty sure this script should not be pushed as it.
I would respectfully disagree ; ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #13)
That is why my initial patch allowed the existing tools/import_borrowers.pl script to be used from the command line. However, I was told that is no longer allowed ( tools/export.pl has this behavior ), though it is not stated in the coding guidelines.
We all know it's a very bad idea. tools/export.pl is the perfect example, it's a pain to maintain it.
The script should also use Pod2Usage (instead of the print_help routine).
Is this in the coding guidelines?
I don't know, all new scripts in misc use Pod2Usage. I think it's a good way to follow, don't you think?
I am completely aware of the quantity of work to provide to reach a correct quality of core here: refactoring, unit tests, etc.
Not sure why this would be required for code we already know works...
If the code is moved to a new subroutine, it will require to be covered by UT.
While I agree in general, this is proven code, and your proposal would add an order of magnitude to the development with no real gains. I would much prefer we allow tools/import_borrowers.pl to be used from the command line for this exact reason.
The gain is the "maintainability" (this word exist?) of the code. In the current state, the code is duplicated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #14)
(In reply to Kyle M Hall from comment #13)
That is why my initial patch allowed the existing tools/import_borrowers.pl script to be used from the command line. However, I was told that is no longer allowed ( tools/export.pl has this behavior ), though it is not stated in the coding guidelines.
We all know it's a very bad idea. tools/export.pl is the perfect example, it's a pain to maintain it.
The script should also use Pod2Usage (instead of the print_help routine).
Is this in the coding guidelines?
I don't know, all new scripts in misc use Pod2Usage. I think it's a good way to follow, don't you think?
Agreed, but I've already implemented it a different way. Please suggest to the RM that this be put in the coding guidelines. We can vote on it at the next meeting.
I am completely aware of the quantity of work to provide to reach a correct quality of core here: refactoring, unit tests, etc.
Not sure why this would be required for code we already know works...
If the code is moved to a new subroutine, it will require to be covered by UT.
I do agree, but I think it's a heavy load to put on one developer. Put it this way, I'd be willing to move the code to shared subroutines if someone else would volunteer to write unit tests.
While I agree in general, this is proven code, and your proposal would add an order of magnitude to the development with no real gains. I would much prefer we allow tools/import_borrowers.pl to be used from the command line for this exact reason.
The gain is the "maintainability" (this word exist?) of the code. In the current state, the code is duplicated.
Yep, that's the correct word. And that is why I prefer to have tools/import_borrowers.pl work from the command line. I think it's the best compromise. I don't think these changes introduce any serious maintenance issues. If you inspect the code the changes are almost entirely if/else's for passing output messages to the template or to the command line depending on how it is run. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dschust1@gmail.com --- Comment #16 from Magnus Enger <magnus@enger.priv.no> --- *** Bug 3340 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: I agree with Jonathan that we should move shared code into a module. That should not be so much work. If you would not have unit tests rightaway, I could live with that argumenting that we do not have these unit tests at this moment also and you are just moving code. If you could write them or at least a simple start, you would receive bonus points of course ;) Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30780|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35557&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35558&action=edit Bug 12598 - Tidy import_borrowers.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35559&action=edit Bug 12598 - Move importing code to a subroutine -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35560&action=edit Bug 12598 - Update command line script to use patron import subroutine -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13607 CC| |magnus@enger.priv.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35557|0 |1 is obsolete| | Attachment #35558|0 |1 is obsolete| | Attachment #35559|0 |1 is obsolete| | Attachment #35560|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35848&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35849&action=edit Bug 12598 - Tidy import_borrowers.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35850&action=edit Bug 12598 - Move importing code to a subroutine -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35851&action=edit Bug 12598 - Update command line script to use patron import subroutine -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13704 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35964&action=edit Bug 12598 - Move Koha::Patrons::Import to Koha::Borrower::Import -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13717 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #27 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 36684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36684&action=edit [SIGNED-OFF] Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #28 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 36685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36685&action=edit [SIGNED-OFF] Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #29 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 36687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36687&action=edit [SIGNED-OFF] Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #30 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 36688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36688&action=edit [SIGNED-OFF] Bug 12598 - Move Koha::Patrons::Import to Koha::Borrower::Import Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35848|0 |1 is obsolete| | Attachment #35849|0 |1 is obsolete| | Attachment #35850|0 |1 is obsolete| | Attachment #35851|0 |1 is obsolete| | Attachment #35964|0 |1 is obsolete| | --- Comment #31 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 36690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36690&action=edit [SIGNED-OFF] Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36690|0 |1 is obsolete| | --- Comment #32 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 36692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36692&action=edit [SIGNED-OFF] Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36684|0 |1 is obsolete| | --- Comment #33 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 36693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36693&action=edit [SIGNED-OFF] Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36685|0 |1 is obsolete| | --- Comment #34 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 36694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36694&action=edit [SIGNED-OFF] Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36687|0 |1 is obsolete| | --- Comment #35 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 36695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36695&action=edit [SIGNED-OFF] Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36688|0 |1 is obsolete| | --- Comment #36 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 36696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36696&action=edit [SIGNED-OFF] Bug 12598 - Move Koha::Patrons::Import to Koha::Borrower::Import Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |benjamin.rokseth@kul.oslo.k | |ommune.no --- Comment #37 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Sorry for the initial screw-up on the order of sign-offs. This is absolutely a valuable addition for automated setups! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch fails the QA script: 1) FAIL Koha/Borrower/Import.pm FAIL critic Package declaration must match filename at line 1, column 1. Correct the filename or package statement. OK forbidden patterns OK pod OK valid 2) Patch removes the recently added matching option on userid: - <option value="userid">Username</option> 3) Is the copyright for the new file import_borrowers.pl correct? +# Copyright 2007 Liblime +# Parts copyright 2010 BibLibre +# Parts copyright 2014 ByWater Solutions 4) c is used for csv file here, but as confirm in other scripts. Again... not sure what we finally agreed to, but should we change this and maybe implement a 'confirm'? Can you please fix? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36692|0 |1 is obsolete| | Attachment #36693|0 |1 is obsolete| | Attachment #36694|0 |1 is obsolete| | Attachment #36695|0 |1 is obsolete| | Attachment #36696|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39124&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39125&action=edit Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39126&action=edit Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39127&action=edit Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39128&action=edit Bug 12598 [QA Followup] * Fix copyright on import_borrowers.pl * Changes -c --csv to -f --file * Adds -c --confirm option * Renames misc/import_borrowers.pl to misc/import_patrons.pl * Restore userid matchpoint option -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #44 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, Would you mind if I squash the patches? Don't you think it would make more sense to have Koha::Import::Patrons instead of Koha::Patrons::Import? I can imagine easily a Koha::Import module with some useful subroutines to import some kind of stuffs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #44)
Kyle,
Would you mind if I squash the patches?
Don't you think it would make more sense to have Koha::Import::Patrons instead of Koha::Patrons::Import? I can imagine easily a Koha::Import module with some useful subroutines to import some kind of stuffs.
Squash away! I have no problem if you want to change the namespace. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #46 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #45)
I have no problem if you want to change the namespace.
Do you agree with my thought or you just said that to make me happy? :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #46)
(In reply to Kyle M Hall from comment #45)
I have no problem if you want to change the namespace.
Do you agree with my thought or you just said that to make me happy? :)
Lol! Why not both? I have no strong opinion on the matter so if you think a different namespace would be better I'm fine with that. If you submit a patch to change the namespace I'd be more than happy to sign it off! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Alan <aschrock@eunc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aschrock@eunc.edu --- Comment #48 from Alan <aschrock@eunc.edu> --- Hi All, When do you anticipate this being available for use? We had used the command line tool in the past, so now are in a mode of manual uploads until this is ready. Thanks for all of the work you are doing! Alan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, could you please rebase this patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39124|0 |1 is obsolete| | Attachment #39125|0 |1 is obsolete| | Attachment #39126|0 |1 is obsolete| | Attachment #39127|0 |1 is obsolete| | Attachment #39128|0 |1 is obsolete| | --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41790&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41791&action=edit Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41792&action=edit Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41793&action=edit Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41794&action=edit Bug 12598 [QA Followup] * Fix copyright on import_borrowers.pl * Changes -c --csv to -f --file * Adds -c --confirm option * Renames misc/import_borrowers.pl to misc/import_patrons.pl * Restore userid matchpoint option -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41790|0 |1 is obsolete| | Attachment #41791|0 |1 is obsolete| | Attachment #41792|0 |1 is obsolete| | Attachment #41793|0 |1 is obsolete| | Attachment #41794|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44065&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44066&action=edit Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44067&action=edit Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #58 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44068&action=edit Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44069&action=edit Bug 12598 [QA Followup] * Fix copyright on import_borrowers.pl * Changes -c --csv to -f --file * Adds -c --confirm option * Renames misc/import_borrowers.pl to misc/import_patrons.pl * Restore userid matchpoint option -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #60 from Kyle M Hall <kyle.m.hall@gmail.com> --- I would really like to see this qa'ed for a fast push after the 3.22 release. The longer this sits here the more likely the new subroutine will fall out of sync with the current import code in master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org