http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch fails the QA script: 1) FAIL Koha/Borrower/Import.pm FAIL critic Package declaration must match filename at line 1, column 1. Correct the filename or package statement. OK forbidden patterns OK pod OK valid 2) Patch removes the recently added matching option on userid: - <option value="userid">Username</option> 3) Is the copyright for the new file import_borrowers.pl correct? +# Copyright 2007 Liblime +# Parts copyright 2010 BibLibre +# Parts copyright 2014 ByWater Solutions 4) c is used for csv file here, but as confirm in other scripts. Again... not sure what we finally agreed to, but should we change this and maybe implement a 'confirm'? Can you please fix? -- You are receiving this mail because: You are watching all bug changes.