[Bug 7295] New: list of librarian managing a basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Bug #: 7295 Summary: list of librarian managing a basket Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions AssignedTo: claire.hernandez@biblibre.com ReportedBy: claire.hernandez@biblibre.com QAContact: ian.walls@bywatersolutions.com Blocks: 7163 User management in basket : add a list of librarians ""using"" a given basket. Any librarian can add himself to the ""user list"". Add filter to users to basket list display (BibLibre MT6531) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|claire.hernandez@biblibre.c |julian.maurice@biblibre.com |om | --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 9309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9309&action=edit More granular permissions for baskets Add branch info to baskets Add a list of borrowers that are allowed to manage a basket (one list for each basket). Add a new subpermission: acquisition => order_manage_all If user is superlibrarian, or if he has permission acquisition = 1(GranularPermissions = OFF), or subpermission acquisition => order_manage_all (GranularPermissions = ON), he's authorised to manage all baskets. Depending on syspref AcqViewBaskets: 'all': user can manage all baskets 'branch': user can manage baskets of his branch (the basket branch is taken into account, not the branch of the basket's creator). If basket branch is not defined, all user can manage this basket. 'user': user can manage baskets he created, and baskets he's in their user list There are unit tests in t/Acquisition/CanUserManageBasket.t, which require Test::MockModule You can edit basket's branch and users list in basket modification page (acqui/basket.pl). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7290 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7292 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Test in a sandbox : - add premission order_manage to a patron - create basket and add a user list with this patron - syspref AcqViewBaskets: 'all' => Patron can see and add command in all basket - add premission order_manage to a patron - create basket and add a user list with this patron - syspref AcqViewBaskets: 'user' => Patron can see and add command only in the basket where he's in the user list - add premission order_manage to a patron of library A - create basket and add a branch : library A - syspref AcqViewBaskets: 'user' => Patron can see and add command only in the basket where the branxh A is added - add premission order_manage to a patron of library A - create baskets - syspref AcqViewBaskets: 'branch' => Patron can see and add command all baskets of the library A - add premission order_manage_all to a patron of library A - create baskets - syspref AcqViewBaskets: 'branch' => Patron can see the list of baskets but can't click view and go on the details (http://pro.test1.biblibre.com/cgi-bin/koha/acqui/basket.pl?basketno=2) : access denied : Error: You do not have permission to access this page. Click to log out In all this test, the button "close this basket" have disappeared from the details page of basket :http://pro.test1.biblibre.com/cgi-bin/koha/acqui/basket.pl?basketno=2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- You still needs the order_manage permission to access pages. order_manage_all is just an additional permission to grant more rights. So you have to check both. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9309|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 9943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9943&action=edit More granular permissions for baskets Patch rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #5 from Michael Davis <m.r.davis@cranfield.ac.uk> --- Created attachment 10227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10227&action=edit Attachment to Bug 7295 - list of librarian managing a basket Bug 7295: More granular permissions for baskets Add branch info to baskets Add a list of borrowers that are allowed to manage a basket (one list for each basket). Add a new subpermission: acquisition => order_manage_all rebase If user is superlibrarian, or if he has permission acquisition = 1 (GranularPermissions = OFF), or subpermission acquisition => order_manage_all (GranularPermissions = ON). He's authorised to manage all baskets. Depending on syspref AcqViewBaskets: 'all': user can manage all baskets 'branch': user can manage baskets of his branch (the basket branch is taken into account, not the branch of the basket's creator). If basket branch is not defined, all user can manage this basket. 'user': user can manage baskets he created, and baskets he's in their user list There are unit tests in t/Acquisition/CanUserManageBasket.t, which require Test::MockModule You can edit basket's branch and users list in basket modification page (acqui/basket.pl) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Michael Davis <m.r.davis@cranfield.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I started testing this today, here are some first notes: 1) The list of libraries is not ordered by description but code. 2) I think it should not be possible to change the branch, when independantbranches is turned on? 3) Why is the default of the branch "no branch"? Shouldn't it be the branch of the basket creator or the branch the staff member is currently logged in at? 4) We keep adding lots of functionality and options to acquisitons. This is good, but also adds a lot of complexity. I think most libraries don't need this granular level of control, so perhaps we should think about moving some of the new features into system preferences. For this feature I think it would be great if unique ids could be added to the <li> elements on the basket summary page. This way both options can be hidden, if a library does not want to use them. 5) The descriptions of the permissions are not very clear and don't show up next to each other in my installation. I am not sure what can be done about this. There is also bug 3849 about this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10227|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 10885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10885&action=edit Bug 7295 - list of librarian managing a basket Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 10886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10886&action=edit Follow-up: Several fixes - List of libraries in basket.pl is now sorted by branch name, not code - When IndependantBranches is ON, user has only the possibility to set basket branch to its own branch, or to no branch at all. - When basket do not belong to any branch, selected branch by default is connection branch (was 'no branch') - added id attributes to both added li elements - change description of 'order_manage_all' permission to make it clearer. - remove Test::MockModule dependency -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Katrin. I believe that all your recommendations have been taken into account. At least I hope :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10885|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11282&action=edit Bug 7295: More granular permissions for baskets Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10886|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11283&action=edit Bug 7295: Follow-up: Several fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #12 from Melia Meggs <melia@bywatersolutions.com> --- I am trying to test this patch but have a few questions. With superlibrarian permissions and AcqViewBasket set to "Show baskets in system, regardless of owner," I get a message in red telling me that I am not authorized to access BasketA. I tried it logged in from the branch that matches the basket, as well as logged in from a different branch, but I get the same message either way. I expected to be able to see and manage all baskets with these permissions... Am I missing something? Also, some of the acq permissions seem a little bit confusing to me: order_manage - Manage orders & basket order_receive - Manage orders & basket These two permissions have the exact same description. Do I need them both to be able to manage baskets? order_manage_all - Manage all orders and baskets, regardless of restrictions on them Would this one override the AcqViewBasket sys pref? For example, if I have the order_manage_all permission, but AcqViewBasket is set to "Show baskets from staff member's library," should I be able to see and manage ALL baskets, or only see and manage the baskets from my library? What if AcqViewBasket is set to "Show baskets in system, regardless of owner" but the order_manage_all permission is not checked? What should happen then? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- If you are superlibrarian, or have the permissions 'order_manage' and 'order_manage_all' (or 'acquisition' if GranularPermissions syspref is not set), you do not need any other permission, and the value of AcqViewBaskets is not important. So you shouldn't see this message, but I'm not able to reproduce. Are you logged in with the mysql user? Did you run updatedatabase.pl? Can you check the log files while testing to see if something goes wrong? To clarify things a little bit: order_manage allows you to manage (create/modify/delete) baskets and orders order_receive allows you to receive these orders. Yes, order_manage_all override AcqViewBasket syspref. If ON, you will be able to manage all baskets. If OFF and AcqViewBasket syspref is set to "Show baskets in system...", you will be able to manage all baskets too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11282|0 |1 is obsolete| | --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13210&action=edit Bug 7295: More granular permissions for baskets Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11283|0 |1 is obsolete| | --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13211&action=edit Bug 7295: Follow-up: Several fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13210|0 |1 is obsolete| | --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 14515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14515&action=edit Bug 7295: More granular permissions for baskets Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13211|0 |1 is obsolete| | --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 14516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14516&action=edit Bug 7295: Follow-up: Several fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14515|0 |1 is obsolete| | --- Comment #18 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16398&action=edit Bug 7295: More granular permissions for baskets Rebased patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14516|0 |1 is obsolete| | --- Comment #19 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16399&action=edit Bug 7295: Follow-up: Several fixes Rebased patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16474&action=edit Bug 8037 - Add holds and funds to items already received in parcel.pl Adds a column to indicate holds on recieved items, as well as adding a new column for fund and showing the subtotals per fund above the total subtotal. Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #22 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- comment 21 is not for this patch (8037) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16474|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16398|0 |1 is obsolete| | --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16497&action=edit [SIGNED-OFF] Bug 7295: More granular permissions for baskets Add branch info to baskets Add a list of borrowers that are allowed to manage a basket (one list for each basket). Add a new subpermission: acquisition => order_manage_all If user is superlibrarian, or if he has permission acquisition = 1 (GranularPermissions = OFF), or subpermission acquisition => order_manage_all (GranularPermissions = ON). He's authorised to manage all baskets. Depending on syspref AcqViewBaskets: 'all': user can manage all baskets 'branch': user can manage baskets of his branch (the basket branch is taken into account, not the branch of the basket's creator). If basket branch is not defined, all user can manage this basket. 'user': user can manage baskets he created, and baskets he's in their user list There are unit tests in t/Acquisition/CanUserManageBasket.t, which require Test::MockModule You can edit basket's branch and users list in basket modification page (acqui/basket.pl) Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16399|0 |1 is obsolete| | --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16498&action=edit [SIGNED-OFF] Bug 7295: Follow-up: Several fixes - List of libraries in basket.pl is now sorted by branch name, not code - When IndependantBranches is ON, user has only the possibility to set basket branch to its own branch, or to no branch at all. - When basket do not belong to any branch, selected branch by default is connection branch (was 'no branch') - added id attributes to both added li elements - change description of 'order_manage_all' permission to make it clearer. - remove Test::MockModule dependency Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Julian, I am looking at this now and have the tests complaining - can you please provide a follow-up? * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: simple-quote string (129) Thx! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Very small thing, also for a follow up: When adding basket managers there is a little note about permissions (+1 for that :) ), but the granular permissions preference it mentions has been removed from the codebase. We are now always using granular permissions by default. Only staff with superlibrarian or acquisitions permissions (or order_manage permission if granular permissions are enabled) are returned in the search results -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I have found 2 things that I think need to be fixed: 1) System preference AcqViewBaskets is set to "from staff member's library only". On master this means, that the user can only see baskets, that have been created by staff from his home library. With your patches applied the system preference is (I think) looking at the newly created branch column in the basket table. For older baskets they are all set to "no branch" - so all baskets in the system suddenly show up. 2) System preference AcqViewBaskets is set to "from staff member's library only". I have an order created at library A - on the managers list is a staff member from library B, but he can't see the order until I give permissions to manage _all_ orders. Should the manager's list override pref/permission? I am not sure about this, but maybe if it's not possible to overwrite we should not allow adding the user to the manager's list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille@gmail.com --- Comment #28 from Koha Team AMU <koha.aixmarseille@gmail.com> --- First : thanks Katrin for your "things". Your second question is a good one. For Koha Team Lyon 3, the managers should see the basket, so the manager's list override pref/permission. For us, we could change one's branch. According Pierre Angot, for a budget, we can already mix owner and library or user (Koha 3.10). We would like to test it but something went wrong. Secondly, problem on the sandbox : Something went wrong ! Applying: Bug 7295: More granular permissions for baskets Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7295: More granular permissions for baskets When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 7295 - list of librarian managing a basket -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #29 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 17358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17358&action=edit Bug 7295 [follow-up] More granular permissions for baskets - updatedatabase.pl now fills the new aqbasket.branch with branchcode of basket owner (aqbasket.authorisedby). So the behavior is unchanged if you have set your syspref AcqViewBaskets to 'branch' - If AcqViewBaskets='branch', prevent librarian to add users that are not from the same branch than the basket. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16497|0 |1 is obsolete| | --- Comment #30 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 17359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17359&action=edit [SIGNED-OFF] Bug 7295: More granular permissions for baskets Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16498|0 |1 is obsolete| | --- Comment #31 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 17360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17360&action=edit [SIGNED-OFF] Bug 7295: Follow-up: Several fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17358|0 |1 is obsolete| | --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 17361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17361&action=edit Bug 7295 [follow-up] More granular permissions for baskets - updatedatabase.pl now fills the new aqbasket.branch with branchcode of basket owner (aqbasket.authorisedby). So the behavior is unchanged if you have set your syspref AcqViewBaskets to 'branch' - If AcqViewBaskets='branch', prevent librarian to add users that are not from the same branch than the basket. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #33 from Julian Maurice <julian.maurice@biblibre.com> --- This last patch should fix problems raised by Katrin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17359|0 |1 is obsolete| | Attachment #17360|0 |1 is obsolete| | Attachment #17361|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17706&action=edit Bug 7295: More granular permissions for baskets Add branch info to baskets Add a list of borrowers that are allowed to manage a basket (one list for each basket). Add a new subpermission: acquisition => order_manage_all If user is superlibrarian, or if he has permission acquisition = 1 (GranularPermissions = OFF), or subpermission acquisition => order_manage_all (GranularPermissions = ON). He's authorised to manage all baskets. Depending on syspref AcqViewBaskets: 'all': user can manage all baskets 'branch': user can manage baskets of his branch (the basket branch is taken into account, not the branch of the basket's creator). If basket branch is not defined, all user can manage this basket. 'user': user can manage baskets he created, and baskets he's in their user list There are unit tests in t/Acquisition/CanUserManageBasket.t, which require Test::MockModule You can edit basket's branch and users list in basket modification page (acqui/basket.pl) Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17707&action=edit Bug 7295: Follow-up: Several fixes - List of libraries in basket.pl is now sorted by branch name, not code - When IndependantBranches is ON, user has only the possibility to set basket branch to its own branch, or to no branch at all. - When basket do not belong to any branch, selected branch by default is connection branch (was 'no branch') - added id attributes to both added li elements - change description of 'order_manage_all' permission to make it clearer. - remove Test::MockModule dependency Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17708&action=edit Bug 7295 [follow-up] More granular permissions for baskets - updatedatabase.pl now fills the new aqbasket.branch with branchcode of basket owner (aqbasket.authorisedby). So the behavior is unchanged if you have set your syspref AcqViewBaskets to 'branch' - If AcqViewBaskets='branch', prevent librarian to add users that are not from the same branch than the basket. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17706|0 |1 is obsolete| | --- Comment #37 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18338&action=edit [SIGNED-OFF] Bug 7295: More granular permissions for baskets Add branch info to baskets Add a list of borrowers that are allowed to manage a basket (one list for each basket). Add a new subpermission: acquisition => order_manage_all If user is superlibrarian, or if he has permission acquisition = 1 (GranularPermissions = OFF), or subpermission acquisition => order_manage_all (GranularPermissions = ON). He's authorised to manage all baskets. Depending on syspref AcqViewBaskets: 'all': user can manage all baskets 'branch': user can manage baskets of his branch (the basket branch is taken into account, not the branch of the basket's creator). If basket branch is not defined, all user can manage this basket. 'user': user can manage baskets he created, and baskets he's in their user list There are unit tests in t/Acquisition/CanUserManageBasket.t, which require Test::MockModule You can edit basket's branch and users list in basket modification page (acqui/basket.pl) Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17707|0 |1 is obsolete| | --- Comment #38 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18339&action=edit [SIGNED-OFF] Bug 7295: Follow-up: Several fixes - List of libraries in basket.pl is now sorted by branch name, not code - When IndependantBranches is ON, user has only the possibility to set basket branch to its own branch, or to no branch at all. - When basket do not belong to any branch, selected branch by default is connection branch (was 'no branch') - added id attributes to both added li elements - change description of 'order_manage_all' permission to make it clearer. - remove Test::MockModule dependency Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17708|0 |1 is obsolete| | --- Comment #39 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 18340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18340&action=edit [SIGNED-OFF] Bug 7295 [follow-up] More granular permissions for baskets - updatedatabase.pl now fills the new aqbasket.branch with branchcode of basket owner (aqbasket.authorisedby). So the behavior is unchanged if you have set your syspref AcqViewBaskets to 'branch' - If AcqViewBaskets='branch', prevent librarian to add users that are not from the same branch than the basket. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18338|0 |1 is obsolete| | Attachment #18339|0 |1 is obsolete| | Attachment #18340|0 |1 is obsolete| | --- Comment #40 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19751&action=edit Bug 7295: More granular permissions for baskets Add branch info to baskets Add a list of borrowers that are allowed to manage a basket (one list for each basket). Add a new subpermission: acquisition => order_manage_all If user is superlibrarian, or if he has permission acquisition = 1 (GranularPermissions = OFF), or subpermission acquisition => order_manage_all (GranularPermissions = ON). He's authorised to manage all baskets. Depending on syspref AcqViewBaskets: 'all': user can manage all baskets 'branch': user can manage baskets of his branch (the basket branch is taken into account, not the branch of the basket's creator). If basket branch is not defined, all user can manage this basket. 'user': user can manage baskets he created, and baskets he's in their user list There are unit tests in t/Acquisition/CanUserManageBasket.t, which require Test::MockModule You can edit basket's branch and users list in basket modification page (acqui/basket.pl) Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #41 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19752&action=edit Bug 7295: Follow-up: Several fixes - List of libraries in basket.pl is now sorted by branch name, not code - When IndependantBranches is ON, user has only the possibility to set basket branch to its own branch, or to no branch at all. - When basket do not belong to any branch, selected branch by default is connection branch (was 'no branch') - added id attributes to both added li elements - change description of 'order_manage_all' permission to make it clearer. - remove Test::MockModule dependency Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #42 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19753&action=edit Bug 7295 [follow-up] More granular permissions for baskets - updatedatabase.pl now fills the new aqbasket.branch with branchcode of basket owner (aqbasket.authorisedby). So the behavior is unchanged if you have set your syspref AcqViewBaskets to 'branch' - If AcqViewBaskets='branch', prevent librarian to add users that are not from the same branch than the basket. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #43 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased first patch for trivial updatedatabase conflict. This was already mentioned before (from koha-qa): FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 138) Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19753|0 |1 is obsolete| | --- Comment #44 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 19754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19754&action=edit Bug 7295 [follow-up] More granular permissions for baskets Replace simple-quoted string by double-quoted string -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19751|0 |1 is obsolete| | --- Comment #45 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20769&action=edit Bug 7295: More granular permissions for baskets Add branch info to baskets Add a list of borrowers that are allowed to manage a basket (one list for each basket). Add a new subpermission: acquisition => order_manage_all If user is superlibrarian, or if he has permission acquisition = 1 (GranularPermissions = OFF), or subpermission acquisition => order_manage_all (GranularPermissions = ON). He's authorised to manage all baskets. Depending on syspref AcqViewBaskets: 'all': user can manage all baskets 'branch': user can manage baskets of his branch (the basket branch is taken into account, not the branch of the basket's creator). If basket branch is not defined, all user can manage this basket. 'user': user can manage baskets he created, and baskets he's in their user list There are unit tests in t/Acquisition/CanUserManageBasket.t, which require Test::MockModule You can edit basket's branch and users list in basket modification page (acqui/basket.pl) Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19752|0 |1 is obsolete| | --- Comment #46 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20770&action=edit Bug 7295: Follow-up: Several fixes - List of libraries in basket.pl is now sorted by branch name, not code - When IndependantBranches is ON, user has only the possibility to set basket branch to its own branch, or to no branch at all. - When basket do not belong to any branch, selected branch by default is connection branch (was 'no branch') - added id attributes to both added li elements - change description of 'order_manage_all' permission to make it clearer. - remove Test::MockModule dependency Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19754|0 |1 is obsolete| | --- Comment #47 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20771&action=edit Bug 7295 [follow-up] More granular permissions for baskets Replace simple-quoted string by double-quoted string Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_14_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #48 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Julian! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org