[Bug 13497] New: The pref AddPatronLists should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Bug ID: 13497 Summary: The pref AddPatronLists should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13458 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34817&action=edit Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Does not apply: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34817|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36021&action=edit Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 36053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36053&action=edit [Signed-off] Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. I could not verify step 1/, because at least one Patron category can not be deleted (Staff, since I'm logged in as a Staff patron and you can not delete categories that are in use). Tested 0/ and 2/ Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36021|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36053|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36360&action=edit [PASSED QA] Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. I could not verify step 1/, because at least one Patron category can not be deleted (Staff, since I'm logged in as a Staff patron and you can not delete categories that are in use). Tested 0/ and 2/ Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Current patch-complexity: Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I am happy with the patch, but I am having some doubts if we understand how this was meant to work correctly. Would you mind sending a short email to the Koha mailing list asking people about removing it/a use case where this is needed for? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #6)
Hi Jonathan,
I am happy with the patch, but I am having some doubts if we understand how this was meant to work correctly. Would you mind sending a short email to the Koha mailing list asking people about removing it/a use case where this is needed for?
I am not sure it's necessary, the pref has been introduced by bug 1782, the default value is categorycode, and it does not work if category_type if defined. Actually I think this pref should have never been created, and it does not make sense since you need to set the borrowers.categorycode with a valid category code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I guess I am just worried I misunderstood how it should work - looked for other related bugs, but had not much luck. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9314 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9314 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13970 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36360|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37755&action=edit Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. I could not verify step 1/, because at least one Patron category can not be deleted (Staff, since I'm logged in as a Staff patron and you can not delete categories that are in use). Tested 0/ and 2/ Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 37758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37758&action=edit Bug 13497: (Maniac followup) spell category in english Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org