http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, I misunderstood - this is about baskets in acquisitions. If you try to reopen a basket, a javascript alert is triggered. But when you close a basket, there is a non-javascript alert. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37574&action=edit Bug 9333: Remove useless JS code - confirm close basket On closing a basket, the librarian is redirect to a new page for the confirmation, the JavaScript confirmation is useless. This code is never triggered and can be removed. Test plan: Without this patch, confirm you don't get a JavaScript confirmation popup on closing a basket With this patch, confirm you don't get any JavaScript error on closing/reopening a basket. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37574|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37596&action=edit Bug 9333: Remove useless JS code - confirm close basket On closing a basket, the librarian is redirect to a new page for the confirmation, the JavaScript confirmation is useless. This code is never triggered and can be removed. Test plan: Without this patch, confirm you don't get a JavaScript confirmation popup on closing a basket With this patch, confirm you don't get any JavaScript error on closing/reopening a basket. NOTE: acqui/basket.tt is only used by acqui/basket.pl git grep "confirm_close" | grep -v "\.po:" doesn't show anything else. Reopening only works on basketgroups, not baskets. Unable to trigger any errors as expected and desired. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37596|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37654&action=edit [PASSED QA] Bug 9333: Remove useless JS code - confirm close basket On closing a basket, the librarian is redirect to a new page for the confirmation, the JavaScript confirmation is useless. This code is never triggered and can be removed. Test plan: Without this patch, confirm you don't get a JavaScript confirmation popup on closing a basket With this patch, confirm you don't get any JavaScript error on closing/reopening a basket. NOTE: acqui/basket.tt is only used by acqui/basket.pl git grep "confirm_close" | grep -v "\.po:" doesn't show anything else. Reopening only works on basketgroups, not baskets. Unable to trigger any errors as expected and desired. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.