[Bug 28080] New: Add system preference that allows users to insert HTML in the <head> on all OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Bug ID: 28080 Summary: Add system preference that allows users to insert HTML in the <head> on all OPAC pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It would be nice if there was a system preference to allow librarinans to insert HTML into the document <head>. Currently there is no way to add custom scripts or meta content, links to Google fonts, etc. Many already insert this in the OPACHeader but since that has moved to the News Tool it is less than ideal to do it this way. ( see bug 26942 ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 119142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119142&action=edit Bug 28080: Add OPACHTMLHead system preference To test: -Apply patch -Look for the syspref OPACHTMLHead -If you insert HTML it should be present inside the <head> on all pages in the OPAC -An easy way to test is to add something like this: <style>body{ background: red !important } </style> -All OPAC pages should then have a red background -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119142|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 119171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119171&action=edit Bug 28080: Add OPACHTMLHead system preference To test: -Apply patch -Look for the syspref OPACHTMLHead -If you insert HTML it should be present inside the <head> on all pages in the OPAC -An easy way to test is to add something like this: <style>body{ background: red !important } </style> -All OPAC pages should then have a red background Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Commenting in an attempt to remind myself to QA this as it would be very useful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |In Discussion --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass from comment #0)
It would be nice if there was a system preference to allow librarinans to insert HTML into the document <head>. Currently there is no way to add custom scripts or meta content, links to Google fonts, etc.
Many already insert this in the OPACHeader but since that has moved to the News Tool it is less than ideal to do it this way. ( see bug 26942 )
We now have this already: KohaPlugins.get_plugins_opac_head And: [% KohaPlugins.get_plugins_opac_js %] And: [% KohaPlugins.get_plugins_intranet_head %] So it is a discussion item whether we really should have this too. We miss an intranet counterpart here, that the plugins offer. And maybe the location of adding the pref content in doc-head-close is questionable? Should we add it at the end, if we would decide so? Could you raise this on koha-devel ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> ---
We now have this already: KohaPlugins.get_plugins_opac_head And: [% KohaPlugins.get_plugins_opac_js %] And: [% KohaPlugins.get_plugins_intranet_head %]
So it is a discussion item whether we really should have this too. We miss an intranet counterpart here, that the plugins offer. And maybe the location of adding the pref content in doc-head-close is questionable? Should we add it at the end, if we would decide so?
Could you raise this on koha-devel ?
I think you are misunderstanding the purpose of this patch. Clearly, we should not have to build a plugin just to import a google font into Koha for some CSS style. That appears to be the purpose of this ehancement; to allow importing js and css into the correct part of Koha's html, the head block. Does that make sense? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #5)
We now have this already: KohaPlugins.get_plugins_opac_head And: [% KohaPlugins.get_plugins_opac_js %] And: [% KohaPlugins.get_plugins_intranet_head %]
So it is a discussion item whether we really should have this too. We miss an intranet counterpart here, that the plugins offer. And maybe the location of adding the pref content in doc-head-close is questionable? Should we add it at the end, if we would decide so?
Could you raise this on koha-devel ?
I think you are misunderstanding the purpose of this patch. Clearly, we should not have to build a plugin just to import a google font into Koha for some CSS style. That appears to be the purpose of this ehancement; to allow importing js and css into the correct part of Koha's html, the head block.
Does that make sense?
Surely, this explanation is helpful :) In this case I would ask: Couldnt you do the same with OPACUserCSS and @import url() or @font-face and src: url()? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> ---
Surely, this explanation is helpful :) In this case I would ask: Couldnt you do the same with OPACUserCSS and @import url() or @font-face and src: url()?
Marcel, we can do that for CSS, yes. I thought maybe it would be beneficial to be able to add other things that belong in the HTML head, link/meta/style/script etc. But perhaps the use case is so small that is not worth adding a whole new system preference to Koha. I will go ahead and mark this one as invalid as there are workarounds to my problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass from comment #7)
Marcel, we can do that for CSS, yes. I thought maybe it would be beneficial to be able to add other things that belong in the HTML head, link/meta/style/script etc.
But perhaps the use case is so small that is not worth adding a whole new system preference to Koha. I will go ahead and mark this one as invalid as there are workarounds to my problem.
Fair enough. But no one told you so yet. Stand with the first QA wave, cope with the second :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org