[Bug 33590] New: Select all/Clear all links on serial collection page are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Bug ID: 33590 Summary: Select all/Clear all links on serial collection page are broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: oleonard@myacpl.org The select all/clear all links to select items for editing or deleting on the serial collection page are broken and there is no reaction when clicking on them. To test: * Add a subscription * From the subscription detail page, click on serial collection link in left hand navigation * Create some additional issues * Clear all link for selecting issues to edit won't work, select all link neither -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slavashishkin@gmail.com Assignee|koha-bugs@lists.koha-commun |slavashishkin@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Select all/Clear all links |Select all/Clear all links |on serial collection page |on many pages are broken |are broken | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #1 from Slava Shishkin <slavashishkin@gmail.com> --- I found the same issues on another page – /cgi-bin/koha/circ/article-requests.pl It is possible that problems occur on other pages where wrappers have been applied. I will check and prepare a correction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #2 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 150250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150250&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt This commit fixed two cases: 1. Fixing "Select all" and "Clear all" links on the page. 2. Fixing the interaction with selected entries when switching between the "New" and "Pending" tabs. To test: (Create article requests if they don't exist) Case 1: 1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs. 2. Click on "Select all" and verify that it's not working -- the checkboxes are not selected. 3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared. 4. Apply the patch. 5. Restart the page and, without switching between tabs, repeat steps 2 and 3. Verify that it works now. Case 2: 1. Go to /cgi-bin/koha/circ/article-requests.pl. 2. Switch between tabs and leave "New" active. 3. Select any entry and delete or move it to another tab. 4. Verify that the entry remains in the table until the page reloads. 5. Apply the patch. 6. Restart the page and repeat steps 2 and 3. Make sure that everything works now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #3 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 150251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150251&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to serials-collection.tt To test: * Add a subscription * From the subscription detail page, click on serial collection link in left hand navigation * Create some additional issues * "Clear all" link for selecting issues to edit won't work, "Select all" link neither * Apply the patch * * "Clear all" link for selecting issues to edit works now, "Select all" link works too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Select all/Clear all links |WRAPPER tab_panel breaks JS |on many pages are broken |on some pages (Select | |all/Clear all, post-Ajax | |updates) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #4 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 150298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150298&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt The submitted numbers were not processed by the search query. To test: 1. Go to /cgi-bin/koha/circ/modborrowers.pl 2. On the relevant tab, enter the card number or the borrower number in the text area, or upload a text file with a relevant list of numbers. 3. Click "Continue" and verify that a message appears stating "No patron card numbers or borrowernumbers given". 4. Apply the patch. 5. Restart the page and repeat steps 2 and 3. Make sure you receive the correct response -- a list of borrowers or a message indicating that the specified numbers were not found. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Slava, is this ready for testing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #6 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 150377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150377&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt The list of CSV profiles was not displayed if the CSV format was selected in the output format settings. To test: 1. Go to /cgi-bin/koha/tools/export.pl 2. At the bottom of the page in the Output format, select SCV format. *If SCV format is not active in the drop-down File format menu, create any profile to Usage export records on the link /cgi-bin/koha/tools/csv-profiles.pl 3. Note that the list of SCV profiles is not displayed. 4. Apply the patch. 5. Restart the page and repeat steps 2. 6. Verify that when you select the CSV format, the list of CSV profiles appears. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #7 from Slava Shishkin <slavashishkin@gmail.com> --- Hi Katrin! Here, I found another case, which I added above. That's all I found, for now, can be test it. If I find something later, I'll create a new ticket. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150250|0 |1 is obsolete| | --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 150457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150457&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt This commit fixed two cases: 1. Fixing "Select all" and "Clear all" links on the page. 2. Fixing the interaction with selected entries when switching between the "New" and "Pending" tabs. To test: (Create article requests if they don't exist) Case 1: 1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs. 2. Click on "Select all" and verify that it's not working -- the checkboxes are not selected. 3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared. 4. Apply the patch. 5. Restart the page and, without switching between tabs, repeat steps 2 and 3. Verify that it works now. Case 2: 1. Go to /cgi-bin/koha/circ/article-requests.pl. 2. Switch between tabs and leave "New" active. 3. Select any entry and delete or move it to another tab. 4. Verify that the entry remains in the table until the page reloads. 5. Apply the patch. 6. Restart the page and repeat steps 2 and 3. Make sure that everything works now. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150251|0 |1 is obsolete| | --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 150458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150458&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to serials-collection.tt To test: * Add a subscription * From the subscription detail page, click on serial collection link in left hand navigation * Create some additional issues * "Clear all" link for selecting issues to edit won't work, "Select all" link neither * Apply the patch * * "Clear all" link for selecting issues to edit works now, "Select all" link works too. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150298|0 |1 is obsolete| | --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 150459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150459&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt The submitted numbers were not processed by the search query. To test: 1. Go to /cgi-bin/koha/circ/modborrowers.pl 2. On the relevant tab, enter the card number or the borrower number in the text area, or upload a text file with a relevant list of numbers. 3. Click "Continue" and verify that a message appears stating "No patron card numbers or borrowernumbers given". 4. Apply the patch. 5. Restart the page and repeat steps 2 and 3. Make sure you receive the correct response -- a list of borrowers or a message indicating that the specified numbers were not found. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150377|0 |1 is obsolete| | --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 150460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150460&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt The list of CSV profiles was not displayed if the CSV format was selected in the output format settings. To test: 1. Go to /cgi-bin/koha/tools/export.pl 2. At the bottom of the page in the Output format, select SCV format. *If SCV format is not active in the drop-down File format menu, create any profile to Usage export records on the link /cgi-bin/koha/tools/csv-profiles.pl 3. Note that the list of SCV profiles is not displayed. 4. Apply the patch. 5. Restart the page and repeat steps 2. 6. Verify that when you select the CSV format, the list of CSV profiles appears. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tested the 4.5 scenarios (serial collection, article requests (cases 1 and 2), patron batch modification and catalog export) and everything works with the patch. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150457|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150549&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt This commit fixed two cases: 1. Fixing "Select all" and "Clear all" links on the page. 2. Fixing the interaction with selected entries when switching between the "New" and "Pending" tabs. To test: (Create article requests if they don't exist) Case 1: 1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs. 2. Click on "Select all" and verify that it's not working -- the checkboxes are not selected. 3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared. 4. Apply the patch. 5. Restart the page and, without switching between tabs, repeat steps 2 and 3. Verify that it works now. Case 2: 1. Go to /cgi-bin/koha/circ/article-requests.pl. 2. Switch between tabs and leave "New" active. 3. Select any entry and delete or move it to another tab. 4. Verify that the entry remains in the table until the page reloads. 5. Apply the patch. 6. Restart the page and repeat steps 2 and 3. Make sure that everything works now. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150458|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150550&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to serials-collection.tt To test: * Add a subscription * From the subscription detail page, click on serial collection link in left hand navigation * Create some additional issues * "Clear all" link for selecting issues to edit won't work, "Select all" link neither * Apply the patch * * "Clear all" link for selecting issues to edit works now, "Select all" link works too. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150459|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150551&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt The submitted numbers were not processed by the search query. To test: 1. Go to /cgi-bin/koha/circ/modborrowers.pl 2. On the relevant tab, enter the card number or the borrower number in the text area, or upload a text file with a relevant list of numbers. 3. Click "Continue" and verify that a message appears stating "No patron card numbers or borrowernumbers given". 4. Apply the patch. 5. Restart the page and repeat steps 2 and 3. Make sure you receive the correct response -- a list of borrowers or a message indicating that the specified numbers were not found. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150460|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150552&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt The list of CSV profiles was not displayed if the CSV format was selected in the output format settings. To test: 1. Go to /cgi-bin/koha/tools/export.pl 2. At the bottom of the page in the Output format, select CSV format. *If CSV format is not active in the drop-down File format menu, create any profile to Usage export records on the link /cgi-bin/koha/tools/csv-profiles.pl 3. Note that the list of CSV profiles is not displayed. 4. Apply the patch. 5. Restart the page and repeat steps 2. 6. Verify that when you select the CSV format, the list of CSV profiles appears. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32571 Component|Serials |Staff interface CC| |gmcharlt@gmail.com QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 33679 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Bug 33590 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Bug 33590 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org