[Bug 35850] New: Use template wrapper for tabs: Header search forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Bug ID: 35850 Summary: Use template wrapper for tabs: Header search forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, I would like to update the header search form include files in the staff client to use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161252&action=edit Bug 35850: Use template wrapper for tabs: Header search forms This patch updates search header includes so that the tabs use WRAPPER to build markup. To test, apply the patch and test at least one page which uses each updated search include. Search header tabs should look correct and work correctly. - Acquisitions - Suggestions - Administration - Budgets and funds - Cities - Currencies - Desks - Patron categories - System preferences - Z39.50 - Advanced search - Authorities - Bibliographic detail page - Cataloging home page - Check in - Check out - Acquisitions -> Vendor -> Contracts - ERM - Staff interface home page - Serials - Tool -> Notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161252|0 |1 is obsolete| | --- Comment #2 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161298&action=edit Bug 35850: Use template wrapper for tabs: Header search forms This patch updates search header includes so that the tabs use WRAPPER to build markup. To test, apply the patch and test at least one page which uses each updated search include. Search header tabs should look correct and work correctly. - Acquisitions - Suggestions - Administration - Budgets and funds - Cities - Currencies - Desks - Patron categories - System preferences - Z39.50 - Advanced search - Authorities - Bibliographic detail page - Cataloging home page - Check in - Check out - Acquisitions -> Vendor -> Contracts - ERM - Staff interface home page - Serials - Tool -> Notices Signed-off-by: Martin AUBEUT <martin.aubeut@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Martin AUBEUT <martin.aubeut@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.aubeut@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161298|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161497&action=edit Bug 35850: Use template wrapper for tabs: Header search forms This patch updates search header includes so that the tabs use WRAPPER to build markup. To test, apply the patch and test at least one page which uses each updated search include. Search header tabs should look correct and work correctly. - Acquisitions - Suggestions - Administration - Budgets and funds - Cities - Currencies - Desks - Patron categories - System preferences - Z39.50 - Advanced search - Authorities - Bibliographic detail page - Cataloging home page - Check in - Check out - Acquisitions -> Vendor -> Contracts - ERM - Staff interface home page - Serials - Tool -> Notices Signed-off-by: Martin AUBEUT <martin.aubeut@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161497|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163520&action=edit Bug 35850: Use template wrapper for tabs: Header search forms This patch updates search header includes so that the tabs use WRAPPER to build markup. To test, apply the patch rebuild the staff interface CSS. Test at least one page which uses each updated search include. Search header tabs should look correct and work correctly. - Acquisitions - Suggestions - Administration - Budgets and funds - Cities - Currencies - Desks - Patron categories - System preferences - Z39.50 - Advanced search - Authorities - Bibliographic detail page - Cataloging home page - Check in - Check out - Acquisitions -> Vendor -> Contracts - ERM - Staff interface home page - Serials - Tool -> Notices Signed-off-by: Martin AUBEUT <martin.aubeut@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like we broke some cypress tests with this one because IDs changed: t/cypress/integration/ERM/Searchbar_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Working on a fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up will be pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36469 [Bug 36469] Conflict between _header.scss and addbiblio.css tab style -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36490 [Bug 36490] Correct tab-switching keyboard shortcut for header search forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Code structure change, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850 Bug 35850 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org