[Bug 13753] New: INDEXER_DAEMON default is incorrect in koha-indexer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Bug ID: 13753 Summary: INDEXER_DAEMON default is incorrect in koha-indexer Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: I.Brown@littleover.derby.sch.uk QA Contact: testopia@bugs.koha-community.org After upgrading to Koha 3.18 I thought I'd try the new daemon indexing as our librarian is always complaining about the delay before things appear in searches. I followed the instructions at http://wiki.koha-community.org/wiki/PackagesIndexDaemon to enable it but it did not seem to be working. Looking at ps output to see if it was running I noticed something strange: lcs-koha 947 0.0 0.0 17176 712 ? S Feb06 0:58 daemon --name=lcs-koha-indexer --errlog=/var/log/koha/lcs/indexer-error.log --stdout=/var/log/koha/lcs/indexer.log --output=/var/log/koha/lcs/indexer-output.log --verbose=1 --respawn --delay=30 --user=lcs-koha.lcs-koha -- -daemon -x -sleep 5 The executable name seemed to be missing. Further investigation led me to /usr/sbin/koha-indexer line 177: # Check if an alternate indexer has been set if [ -z $ALTERNATE_INDEXER_DAEMON ]; then INDEXER_DAEMON="$ALTERNATE_INDEXER_DAEMON" else # We default to rebuild_zebra.pl if no alternate indexer set INDEXER_DAEMON="${KOHA_HOME}/bin/migration_tools/rebuild_zebra.pl" fi Surely this means that if the INDEXER_DAEMON is zero length then set it to the zero length string! The default daemon program is never set. The INDEXER_DAEMON assigments should be swapped. I'm surprised no one else has reported this but I can't find any other bug reports. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Version|3.18 |master Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 36141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36141&action=edit Bug 13753: koha-indexer contains invalid statement An incorrect conditional makes the indexer daemon fail to load. To test: - Enable the indexer daemon on packages [1] - Restart koha-common: $ service koha-common restart - Run $ ps waux | grep koha-indexer => FAIL: there's no reference to the rebuild_zebra.pl script (line should look like *rebuild_zebra.pl -daemon*) Run ps -ef | grep rebuild_zebra.pl too to make sure. - Apply the patch, repeat the steps => SUCCESS: the rebuild_zebra.pl script is ran - Sign off :-D Thanks Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36141|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 36169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36169&action=edit Bug 13753: koha-indexer contains invalid statement An incorrect conditional makes the indexer daemon fail to load. To test: - Enable the indexer daemon on packages [1] - Restart koha-common: $ service koha-common restart - Run $ ps waux | grep koha-indexer => FAIL: there's no reference to the rebuild_zebra.pl script (line should look like *rebuild_zebra.pl -daemon*) Run ps -ef | grep rebuild_zebra.pl too to make sure. - Apply the patch, repeat the steps => SUCCESS: the rebuild_zebra.pl script is ran - Sign off :-D Thanks Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- Not in the scope of this patch: I had to manually start koha-indexer. That is neither mentioned here nor on the Wiki, so I wonder if it is supposed to run automatically? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Mirko Tietgen from comment #3)
Not in the scope of this patch: I had to manually start koha-indexer. That is neither mentioned here nor on the Wiki, so I wonder if it is supposed to run automatically?
Mirko, have you set /etc/default/koha-common ? And restarted the koha-common service? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Tomás Cohen Arazi from comment #4)
(In reply to Mirko Tietgen from comment #3)
Not in the scope of this patch: I had to manually start koha-indexer. That is neither mentioned here nor on the Wiki, so I wonder if it is supposed to run automatically?
Mirko, have you set /etc/default/koha-common ? And restarted the koha-common service?
Yes, I did. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Mirko Tietgen from comment #5)
(In reply to Tomás Cohen Arazi from comment #4)
(In reply to Mirko Tietgen from comment #3)
Not in the scope of this patch: I had to manually start koha-indexer. That is neither mentioned here nor on the Wiki, so I wonder if it is supposed to run automatically?
Mirko, have you set /etc/default/koha-common ? And restarted the koha-common service?
Yes, I did.
Sorry, I did not read carefully. I set /etc/koha/koha-common.conf. I did not set /etc/default/koha-common as it was not mentioned in the wiki. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36169|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36285&action=edit [PASSED QA] Bug 13731: Suggestions reason does not save on updating the status On the suggestion list view, if you set a status, it won't be saved. Test plan: 1/ Create a suggestion 2/ Go on the suggestion list view (suggestion/suggestion.pl) 3/ Select a suggestion and marked it as "rejected" (or the status you want) and choose a reason 4/ Save 5/ Browse you suggestions DB table (using your favorite MySQL CLI) and verify that the "reason" field is correctly filled. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Attachment #36169|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36169|0 |1 is obsolete| | Attachment #36285|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36286&action=edit [PASSED QA] Bug 13753: koha-indexer contains invalid statement An incorrect conditional makes the indexer daemon fail to load. To test: - Enable the indexer daemon on packages [1] - Restart koha-common: $ service koha-common restart - Run $ ps waux | grep koha-indexer => FAIL: there's no reference to the rebuild_zebra.pl script (line should look like *rebuild_zebra.pl -daemon*) Run ps -ef | grep rebuild_zebra.pl too to make sure. - Apply the patch, repeat the steps => SUCCESS: the rebuild_zebra.pl script is ran - Sign off :-D Thanks Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org