[Bug 9848] New: SIP tests : fix in 10renew_all.t (additionnal checkin)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Bug ID: 9848 Summary: SIP tests : fix in 10renew_all.t (additionnal checkin) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: SIP2 Assignee: adrien.saurat@biblibre.com Reporter: adrien.saurat@biblibre.com CC: colin.campbell@ptfs-europe.com [MT10401] An error occurs while trying the "renew all" SIP test, 10renew_all.t: # Failed test 'match leader Renew All: prep: check out 1783B to 1X981' # at /home/asaurat/workspace/versions/community/C4/SIP/t/SIPtest.pm line 204. # Response '121YNY20130319 153138AOVIL|AA1X981|AB1783B|AJL ANGOISSE DU ROI SALOMON|AH20130521 235900|AFItem already checked out to you: renewing item.|AY3AZD551' doesn't match pattern '(?-xism:^121NNY\d{8} {4}\d{6})' Koha sent: 121YNY The test expects: 121NNY 12 = code for "Checkout Response" message 1 = Operation succeeded The three following characters mean: - renewal ok - magnetic data - desensitize We have a difference on the "Renewal ok" field. I found the reason behind this: it happens when you run all the tests at once ("make test"). In this case, this "renew all" test starts with an item already checked out during a former test. The "renew all" test begins with a checkout operation, but as the item is already out, this results in a renewal when it's not expected yet. The solution I can see : adding a "checkin" operation at the very beginning of the test. But to let the test work even when launched alone, we must allow this checkin to be unsuccessfull, it's just part of the preparation before the actual renewal tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 16418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16418&action=edit proposed patch #1 Adds the new checkin operations explained above. + some cleaning + moved a block to enhance readibility (keeping execution order) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16418|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16517&action=edit Bug 9848: SIP tests, fix in 10renew_all.t (additionnal checkin) Adds a checkin operation at the beginning of the test. Otherwise, a former test leaves the test item checked out and this generates an error. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #2)
Created attachment 16517 [details] [review] Bug 9848: SIP tests, fix in 10renew_all.t (additionnal checkin)
Adds a checkin operation at the beginning of the test. Otherwise, a former test leaves the test item checked out and this generates an error.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
qa-comment: sorry, i spent a long time attempting to configure a sip-server to test this patch ...but was unsuccessful :/ someone else with a working sip will have to QA this Adrien, can you please perltidy this file, so qa-tool will pass it? http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16517|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34676&action=edit Bug 9848: SIP tests, fix in 10renew_all.t (additionnal checkin) Adds a checkin operation at the beginning of the test. Otherwise, a former test leaves the test item checked out and this generates an error. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Mason James from comment #3)
Adrien, can you please perltidy this file, so qa-tool will pass it? http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy
The changes have been perltidied. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Jonathan, can you add some hints on how to run the tests? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #6)
Jonathan, can you add some hints on how to run the tests?
I don't know and I did not find any documentation on these tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|adrien.saurat@biblibre.com |jonathan.druart@biblibre.co | |m CC| |tomascohen@gmail.com --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Does noone know how to run these tests? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 --- Comment #9 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #8)
Does noone know how to run these tests?
The only documentation is the README in the directory. I took a look ages ago but a lot of the tests have hardcoded references to a test setup on a Liblime test system. As a whole they need rewitten as part of the test suite and to handle dependencies in a reproduceable way. They arnt a test suite they are a reminder that one needs to be written -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ouch. What do you suggest for this bug? Should we push it to the 'reminder'? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 --- Comment #11 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #10)
Ouch. What do you suggest for this bug? Should we push it to the 'reminder'?
The patch makes logical sense. The problem is as it appears noone runs these tests regularly, noone is confident about verifying it. No problem with it, we must assume Adrien did run these to find the problem -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Summary|SIP tests : fix in |SIP tests : fix in |10renew_all.t (additionnal |10renew_all.t (additional |checkin) |checkin) --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am in favor of pushing these - what I get from the discussion is, that it 'looks right', so it might help when the old testing files are ever used for reference in writing new tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Adrien! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org