[Bug 24381] New: ACCOUNT_DEBIT slip not printing information about paid fines/fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Bug ID: 24381 Summary: ACCOUNT_DEBIT slip not printing information about paid fines/fees Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org While the templates suggests it should print the fines/fees paid/changed by the payment, this doesn't work for me on current master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Instead it shows the payment line - I think some variables are not quite right there. It's different in 19.05 as Caroline verified on IRC. Fee receipt - list of fines paid (print is on payment line) Invoice - list of payments made (print is on fine/fee) It appears turned upside down now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think what we should have in the table for each: ACCOUNT_CREDIT Fee receipt - list of fines paid (print is on payment line) ACCOUNT_DEBIT Invoice - list of payments made (print is on fine/fee) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ACCOUNT_DEBIT slip not |ACCOUNT_CREDIT slip not |printing information about |printing information about |paid fines/fees |paid fines/fees -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not understand, can you explain a bit more please? Or maybe attach a screenshot? I see the Print button for each line, the letter displays only 1 line. Do you expect all the lines to be displayed? In that case the button should be moved somewhere else? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It might get clearer if we start with the payment receipts printed from a 'payment' line. At the moment, it will have: - a table with the column heading: Description of charges - Below always 1 line only with "Payment" - And of course... there is not much to total What I think we should have, and we can already see this in the 'details' for the payment and in the sample notice for PAYMENT notices: - a table with the column heading: Description of charges - A list of the fines the payment paid off, so something like: - Rental fee X - Fine for ... - The total of the payment I've tried to use the TT syntax from the payment emails, but couldn't get it to work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm sure this used to work... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22761, 22809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 [Bug 22761] Move "Fee receipt" from template to a slip https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 [Bug 22809] Move "INVOICE" from template to a slip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Right.. I think I know what you guys want... but I'm pretty confident it wasn't different in 18.11 unless I'm missing a bug somewhere.. the conversion from hard coded to a notices template did not change the output going back to my notes.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Now that bug 23354 has been pushed to master, could you take a look at the template included for a RECEIPT slipt for the Point Of Sale receipts and confirm that would conform to the data you're looking for in the default slip here too.. If so, I can create a patch to correct that for new installs.. I think the reason we didn't add such a slip during the change to slips was to preserve existing receipt look and feel during upgrades. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Whilst we're here.. can someone explain to me why we need 4 distinct notices for this? ACCOUNT_CREDIT - printfeercpt ACCOUNT_DEBIT - printinvoice ACCOUNT_PAYMENT - What is this for? ACCOUNT_WRITEOFF - What is this for? RECEIPT - pos/printreceipt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #8)
Whilst we're here.. can someone explain to me why we need 4 distinct notices for this?
Interesting question!
ACCOUNT_CREDIT - printfeercpt ACCOUNT_DEBIT - printinvoice
These are for the slips. I have to say I keep confusing debit and credit, but i think: CREDIT = Payment DEBIT = Invoice
ACCOUNT_PAYMENT - What is this for? ACCOUNT_WRITEOFF - What is this for?
Sending emails to the patron, similar to checkout/checkin slips. It was a major step forward as at that time the slips were still not customizable. - see UseEmailReceipts system preference.
RECEIPT - pos/printreceipt
I think there is a good precedence to have different templates for printed slips, so that makes sense to me. Also while we could probably combine payment, writeoff notice and invoice notice are different things. I have not idea about RECEIPT yet - but this one you should know about ;) We have tested ACCOUNT_ emails and they do what we need on the slips. I'd prefere if they all shared the same names for objects/variables or this will be really messy to train and explain. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I need some more of the other accounts bugs to move before I can delegate time to this I'm afraid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Claudio <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, coming back to this..
We have tested ACCOUNT_ emails and they do what we need on the slips. I'd prefere if they all shared the same names for objects/variables or this will be really messy to train and explain.
I agree.. it would be great to unify the syntax's and have the default template all take a similar form... the issue with this to date has been backwards compatibility... I'm now considering how we can move to a consistent approach without having huge amounts of redundant code for backward compatibility.. any suggestions greatly welcomed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106946&action=edit Bug 24381: Ratify account slip printing This patch simplifies the members/print*.pl controller scripts to only pass around the minimum required data for the templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106947&action=edit Bug 24381: Update sample notices This patch update the sample notices for new installs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25998 [Bug 25998] Add 'library' relation to Koha::Account::Line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So.. this works really nicely for new installs now and the code is significantly cleaner in my opinion.. but I need to now work out how to support backward compatibility with older notices... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106946|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106950&action=edit Bug 24381: Ratify account slip printing This patch simplifies the members/print*.pl controller scripts to only pass around the minimum required data for the templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106947|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106951&action=edit Bug 24381: Update sample notices This patch update the sample notices for new installs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106952&action=edit Bug 23481: Update notices if defaults used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106953&action=edit Bug 24381: Update notices if defaults used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106956&action=edit Bug 25998: Add 'library' relation to Koha::Account::Line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106950|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106957&action=edit Bug 24381: Ratify account slip printing This patch simplifies the members/print*.pl controller scripts to only pass around the minimum required data for the templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106951|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106958&action=edit Bug 24381: Update sample notices This patch update the sample notices for new installs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106953|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106959&action=edit Bug 24381: Update notices if defaults used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106960&action=edit Bug 24381: Update notice params If the update to catch defaults fails, we need to attempt to update renamed template variables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106952|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ACCOUNT_CREDIT slip not |ACCOUNT_CREDIT and |printing information about |ACCOUNT_DEBIT slip not |paid fines/fees |printing information about | |paid fines/fees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106957|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106974&action=edit Bug 24381: Ratify account slip printing This patch simplifies the members/print*.pl controller scripts to only pass around the minimum required data for the templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106958|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106975&action=edit Bug 24381: Update sample notices This patch update the sample notices for new installs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106959|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106976&action=edit Bug 24381: Update notices if defaults used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106960|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106977&action=edit Bug 24381: Update notice params If the update to catch defaults fails, we need to attempt to update renamed template variables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test plan Fresh Install 1/ Install a koha fresh and allow the sample notices to be installed 2/ Create some debits on a patrons account 3/ 'Print' the debit and verify the print works and looks reasonable 4/ Create some credits on a patrons account 5/ 'Print' the credit and verify the print works and looks reasonable 6/ Apply a credit against some debits 7/ Print both 'credit' and 'debit' and confirm the receipts look reasonable Upgrade (With default notices) 1/ Perform an upgrade where the notices were still set to their defaults prior to upgrade 2/ Check that the notices have been upgraded to the new defaults Upgrade (With modified notices) 1/ Perform an upgrade where the notices have been modified locally 2/ Check that the notice customisations are intact 3/ Check that the notices still print correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Martin, can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106974|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110210&action=edit Bug 24381: Ratify account slip printing This patch simplifies the members/print*.pl controller scripts to only pass around the minimum required data for the templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106975|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110211&action=edit Bug 24381: Update sample notices This patch update the sample notices for new installs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106976|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110212&action=edit Bug 24381: Update notices if defaults used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106977|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110213&action=edit Bug 24381: Update notice params If the update to catch defaults fails, we need to attempt to update renamed template variables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110210|0 |1 is obsolete| | Attachment #110211|0 |1 is obsolete| | Attachment #110212|0 |1 is obsolete| | Attachment #110213|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 110461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110461&action=edit Bug 24381: Ratify account slip printing This patch simplifies the members/print*.pl controller scripts to only pass around the minimum required data for the templates. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 110462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110462&action=edit Bug 24381: Update sample notices This patch update the sample notices for new installs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 110463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110463&action=edit Bug 24381: Update notices if defaults used Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 110464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110464&action=edit Bug 24381: Update notice params If the update to catch defaults fails, we need to attempt to update renamed template variables Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi --- Comment #38 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Before this patch on koha-testing-docker if I add two manual fees and click on the print button on either one of the fees then it shows that fee as itemized. After applying this patch, running updatedatabase and restart_all I only see the total amount and not details for this fee. I think this is not expected, after this patch all the fee lines are supposed to be shown, right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26418 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26418 [Bug 26418] The "description" for REFUND accountlines is not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26418 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26418 [Bug 26418] The "description" for REFUND accountlines is not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26398 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 [Bug 26398] Credit and Debit types on creating a manual credits and manual invoices are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Joonas Kylmälä from comment #38)
Before this patch on koha-testing-docker if I add two manual fees and click on the print button on either one of the fees then it shows that fee as itemized. After applying this patch, running updatedatabase and restart_all I only see the total amount and not details for this fee. I think this is not expected, after this patch all the fee lines are supposed to be shown, right?
You are quit right.. seems I didn't test the cases where we haven't actually applied any credits against the debt.. or vica versa. Those don't looked great right now. I'm working on a better notice template to replace it with. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110461|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111530&action=edit Bug 24381: Ratify account slip printing This patch simplifies the members/print*.pl controller scripts to only pass around the minimum required data for the templates. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110462|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111531&action=edit Bug 24381: Update sample notices This patch update the sample notices for new installs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110463|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111532&action=edit Bug 24381: Update notices if defaults used Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110464|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111533&action=edit Bug 24381: Update notice params If the update to catch defaults fails, we need to attempt to update renamed template variables Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111534&action=edit Bug 24381: (follow-up) Notice improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- To Test The updated templates are used for a plethora of different cases and I'd like some feedback as to whether they're an improvement for each. ACCOUNT_DEBIT * This one is used for accountlines of debit_type_code 'ACCOUNT', 'ACCOUNT_RENEW', 'LOST', 'MANUAL', 'NEW_CARD', 'OVERDUE', 'PROCESSING', 'RENT', 'RENT_DAILY', 'RENT_RENEW', 'RENT_DAILY_RENEW', 'RESERVE', 'RESERVE_EXPIRED', 'PAYOUT' and any other locally added debit types. Other than the 'PAYOUT' type, which I believe may warrant it's own template entirely I'm reasonably happy. I am, however interested in feedback regarding how they look prior to and post the debt being paid (partially, fully in one and fully over multiple payments) ACCOUNT_CREDIT * This one is used for accountlines of credit_type_code 'PAYMENT', 'WRITEOFF', 'FORGIVEN', 'CREDIT', 'LOST_FOUND', 'REFUND' and any other locally added credit types. Again, I'm interested in feedback regarding how they look before and after they have been applied to debts. ACCOUNT_PAYMENT * I can't remember what this one is used for :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #46 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Martin, the changes you made to the template in the last patch are quite huge in my opinion, if you don't mind I would like to set this to Need Signoff to have someone review the last patch before having the QA team check for final time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- As an additional note, whilst working on the templates I noticed that the [% today %] substitution doesn't work in this notice as it does elsewhere.. After a discussion with Jonathan, we noted that these print slips do not go via GetPreparedLetter and rather call the private getletter function directly and then pass the resultant template into a process_tt block in the print template. We deceded we aught to work out a better way to handle this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111530|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111590&action=edit Bug 24381: Ratify account slip printing This patch simplifies the members/print*.pl controller scripts to only pass around the minimum required data for the templates. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111531|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111591&action=edit Bug 24381: Update sample notices This patch update the sample notices for new installs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111532|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111592&action=edit Bug 24381: Update notices if defaults used Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111533|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111593&action=edit Bug 24381: Update notice params If the update to catch defaults fails, we need to attempt to update renamed template variables Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111534|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111594&action=edit Bug 24381: (follow-up) Notice improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111595&action=edit Bug 24381: Convert printfeercpt to use GetPreparedLetter This patch updates C4::Letters to allow use of existing koha template includes from notices, then updates the printfeercpt slip print option to use GetPreparedLetter rather than calling getletter directly. As part of this work, we also add credits and debits handling to the _parseletter_sth and _get_tt_params routines in C4::Letters to allow for recognisable variable names in the notice template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, back to NSO.. that final followup is a proof of concept for converting the first slip to use GetPreparedLetter as aposed to calling getletter directly and then parting the evaluating the tt from inside the template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26689 | Depends on| |26689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734 [Bug 26734] Convert accounts (monetary) notices to template toolkit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26734 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734 [Bug 26734] Convert accounts (monetary) notices to template toolkit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- People seemed to generally lose interest in this.. :(.. the work moved to bug 26734 to split it into sensible parts as the code here ended up very customised for each case instead of using a more generalised patturn. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116394&action=edit Bug 24381: Add payout_amount method to Koha::Account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116394|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26398 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 [Bug 26398] Credit and Debit types on creating a manual credits and manual invoices are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22761 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 [Bug 22761] Move "Fee receipt" from template to a slip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Patch doesn't apply --- Comment #57 from Lucas Gass <lucas@bywatersolutions.com> --- Patch doesn't apply to current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111590|0 |1 is obsolete| | Attachment #111591|0 |1 is obsolete| | Attachment #111592|0 |1 is obsolete| | Attachment #111593|0 |1 is obsolete| | Attachment #111594|0 |1 is obsolete| | Attachment #111595|0 |1 is obsolete| | --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140868&action=edit Bug 24381: Update sample notices This patch update the sample notices for new installs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #59 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140869&action=edit Bug 24381: Update notices if defaults used Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #60 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140870&action=edit Bug 24381: Update notice params If the update to catch defaults fails, we need to attempt to update renamed template variables Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #61 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140871&action=edit Bug 24381: (follow-up) Notice improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #62 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140872&action=edit Bug 24381: Convert printfeercpt to use GetPreparedLetter This patch updates C4::Letters to allow use of existing koha template includes from notices, then updates the printfeercpt slip print option to use GetPreparedLetter rather than calling getletter directly. As part of this work, we also add credits and debits handling to the _parseletter_sth and _get_tt_params routines in C4::Letters to allow for recognisable variable names in the notice template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #63 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140873&action=edit Bug 24381: (follow-up) Add USE statements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #64 from Nick Clemens <nick@bywatersolutions.com> --- I dropped the first patch, it seemed to have been done already, updated the others slightly, worked in brief testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #65 from Lucas Gass <lucas@bywatersolutions.com> --- It appears like there is a problem with the rebase here. I think this block is now being repeated: my $htdocs = C4::Context->config('intrahtdocs'); my ($theme, $lang, $activethemes)= C4::Templates::themelanguage( $htdocs, 'about.tt', 'intranet'); my @includes; foreach (@$activethemes) { push @includes, "$htdocs/$_/$lang/includes"; push @includes, "$htdocs/$_/en/includes" unless $lang eq 'en'; } The QA tool complains about that: FAIL C4/Letters.pm FAIL valid "my" variable $htdocs masks earlier declaration in same scope "my" variable $theme masks earlier declaration in same scope "my" variable $lang masks earlier declaration in same scope "my" variable @includes masks earlier declaration in same scope "my" variable $htdocs masks earlier declaration in same scope "my" variable $theme masks earlier declaration in same scope "my" variable $lang masks earlier declaration in same scope "my" variable @includes masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140872|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've obsoleted another of the patches that Nick rebased as it's already done in bug 26734... This is another case of a bug loosing momentum due to a distinct lack of testing at the time and I'm struggling to catch back up again.. All we need at this point is the new notices.. all the core code stuff is in... Also, with bug 26689 we can finally split these notices up so they're specific to their credit_type_code and debit_type_code.. so the notices submitted here with various cases for the different types built into the one notice don't really make much sense now.. it's much clearer to have a notice per type instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The patchset should now work as it stands.. but personally I'd split the notices up to remove the `[% IF ( credit.credit_type_code == 'PAYMENT' ) %]"` and similar blocks and instead put them in new notices 'CREDIT_PAYMENT' for example. Either way.. give it a test and see if you like seeing the itemised summaries.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140868|0 |1 is obsolete| | --- Comment #68 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141619&action=edit Bug 24381: Update sample notices This patch update the sample notices for new installs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140869|0 |1 is obsolete| | --- Comment #69 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141620&action=edit Bug 24381: Update notices if defaults used Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140870|0 |1 is obsolete| | --- Comment #70 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141621&action=edit Bug 24381: Update notice params If the update to catch defaults fails, we need to attempt to update renamed template variables Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140871|0 |1 is obsolete| | --- Comment #71 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141622&action=edit Bug 24381: (follow-up) Notice improvements Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140873|0 |1 is obsolete| | --- Comment #72 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141623&action=edit Bug 24381: (follow-up) Add USE statements Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #73 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks for this one Martin. It will make a lot of librarians happy. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141619|0 |1 is obsolete| | Attachment #141620|0 |1 is obsolete| | Attachment #141621|0 |1 is obsolete| | Attachment #141622|0 |1 is obsolete| | Attachment #141623|0 |1 is obsolete| | --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142386&action=edit Bug 24381: Update sample notices This patch update the sample notices for new installs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #75 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142387&action=edit Bug 24381: Update notices if defaults used Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142388&action=edit Bug 24381: Update notice params If the update to catch defaults fails, we need to attempt to update renamed template variables Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #77 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142389&action=edit Bug 24381: (follow-up) Notice improvements Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142390&action=edit Bug 24381: (follow-up) Add USE statements Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #79 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 --- Comment #80 from Lucas Gass <lucas@bywatersolutions.com> --- Patchset won't apply cleanly to 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Bug 24381 depends on bug 26689, which changed state. Bug 26689 Summary: Monetary accounts notices should be definable at the credit_type/debit_type level https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34332 [Bug 34332] Syntax error in point of sale email template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35064 [Bug 35064] Syntax error in db_revs/220600072.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36846 [Bug 36846] Collected and change variables are set to 0.00 when printing from POS Transaction history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40305 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40305 [Bug 40305] Collected and change variables are inconsistent in controllers and notice templates -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org