[Bug 9696] New: Remove YUI styling from buttons on patron card creator edit pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 Bug ID: 9696 Summary: Remove YUI styling from buttons on patron card creator edit pages Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/patroncards/edit-*.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org Some buttons on the patron card creator's edit pages are styled using YUI: /cgi-bin/koha/patroncards/edit-batch.pl /cgi-bin/koha/patroncards/edit-layout.pl /cgi-bin/koha/patroncards/edit-profile.pl /cgi-bin/koha/patroncards/edit-template.pl Typically we don't apply special button styling to submit buttons, so to make these pages consistent with others in Koha I propose to remove YUI styling. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15622&action=edit Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages Submit and cancel buttons on patron card creator edit pages should not be styled differently than other submit and cancel controls. This patch removes YUI styling of these controls and makes them consistent with controls on other Koha pages. The "Cancel" button has been removed altogether from the batch edit page since there is not a corresponding submit button. To test, got to the patron card creator and edit a batch, a layout, a profile, and a template. Submit and cancel controls should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9697 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15622|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15638&action=edit [SIGNED-OFF] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages Submit and cancel buttons on patron card creator edit pages should not be styled differently than other submit and cancel controls. This patch removes YUI styling of these controls and makes them consistent with controls on other Koha pages. The "Cancel" button has been removed altogether from the batch edit page since there is not a corresponding submit button. To test, got to the patron card creator and edit a batch, a layout, a profile, and a template. Submit and cancel controls should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. Works and looks well. No errors. Note: It's true that edit batch has not a submit button, but on the other managed pages (layout, profile, template) cancel aborts editing and takes you to a list of objects (layout, etc.) Now if we selected the wrong batch, we need to click on left menu o back button (yay). Are we loosing a consistent interface? Just thinking. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15638|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15872&action=edit [PASSED QA] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages Submit and cancel buttons on patron card creator edit pages should not be styled differently than other submit and cancel controls. This patch removes YUI styling of these controls and makes them consistent with controls on other Koha pages. The "Cancel" button has been removed altogether from the batch edit page since there is not a corresponding submit button. To test, got to the patron card creator and edit a batch, a layout, a profile, and a template. Submit and cancel controls should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. Works and looks well. No errors. Note: It's true that edit batch has not a submit button, but on the other managed pages (layout, profile, template) cancel aborts editing and takes you to a list of objects (layout, etc.) Now if we selected the wrong batch, we need to click on left menu o back button (yay). Are we loosing a consistent interface? Just thinking. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, more consistent with Koha's general interface patterns. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9696 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org