[Bug 25277] New: Z3950responder does not work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Bug ID: 25277 Summary: Z3950responder does not work with Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The Z3950 responder is hardcoded to search the '_all" field if no field is passed. This breaks as of Koha 19.11 where the "_all" field is removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103690&action=edit Bug 25277: Don't specify a field in query if none passed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25278 [Bug 25278] Z3950 Responder does not work with Authorities under elasticsearch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103698&action=edit Bug 25277: Unit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- IIUC , it's about using Koha as a Z39.50 server. https://wiki.koha-community.org/wiki/Setting_up_the_Z39.50_and_SRU_Server Is it valid to test it with the same instance of Koha as a client? ^^" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #3)
IIUC , it's about using Koha as a Z39.50 server. https://wiki.koha-community.org/wiki/Setting_up_the_Z39.50_and_SRU_Server
Is it valid to test it with the same instance of Koha as a client? ^^"
Yes, you can test on your test environment To test: 0 - Have Koha running with ES enabled 1 - Launch the z3950 responder: perl misc/z3950_responder.pl -c etc/z3950/ --debug 2 - Connect using yaz-client: yaz-client localhost:2100 3 - base biblios 4 - find bruce 5 - No results 6 - Stop the responder 7 - Apply patch 8 - Repeat 9 - This time you get results You can also setup the localhost as a z39 search and search using the cataloguing module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- For some reason I have issues to run the responder on koha-testing-docker kohadev-koha@0c6291f3563f:/kohadevbox/koha$ perl misc/z3950_responder.pl -c etc/z3950/ --debug /etc/koha/sites/kohadev/z3950/: No such file or directory Why does it wants it from /etc/koha/sites/kohadev/z3950 ? It's like -c is ignored. Same issue when using the koha-z3950-responder command. kohadev-koha@0c6291f3563f:/kohadevbox/koha$ koha-z3950-responder --start kohadev [....] Starting Z39.50/SRU daemon for kohadev:/etc/koha/sites/kohadev/z3950/: No such file or directory I'm not specifying any param here. So it would be the default config of koha-testing-docker that doesn't pass it. Or it's ignored like above. This ugly trick did it. kohadev-koha@0c6291f3563f:/kohadevbox/koha$ ln -s /kohadevbox/koha/etc/z3950/ /etc/koha/sites/kohadev/z3950 Now it can try to test. But does anyone has an idea if that's and issue of Koha or koha-testing-docker? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Z> find learning Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 4, setno 6 records returned: 0 Elapsed: 0.038088 It's the number of hits right? Z> find learning Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 4, setno 1 records returned: 0 Elapsed: 0.048846 Same results with the patch and restart_all done.
You can also setup the localhost as a z39 search and search using the cataloguing module
I got 3 results that way. Wait. I still get 3 results without applying the patch. (I recreated my dev env) Maybe there is something wrong with my ES setup? Is there another way to see the current issue? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #6:
Maybe there is something wrong with my ES setup? Is there another way to see the current issue?
Are you certain your SearchEngine syspref is set to elastic? I can still recreate the issue Step 1 should say: perl misc/z3950_responder.pl --config-dir /kohadevbox/koha/etc/z3950 --debug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Are you certain your SearchEngine syspref is set to elastic? I can still recreate the issue
Yes, I double checked that. Z39.50 search gives me different results depending on the SearchEngine. But I always get results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Z3950responder does not |Z3950responder keyword |work with Elasticsearch |search does not work with | |Elasticsearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Z3950responder keyword |Z3950responder keyword |search does not work with |search does not work with |Elasticsearch |Elasticsearch 6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103690|0 |1 is obsolete| | --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104293&action=edit Bug 25277: Don't specify a field in query if none passed == test plan == To test: 0 - Have Koha running with ES 6 enabled 1 - Launch the z3950 responder: perl misc/z3950_responder.pl --config-dir /kohadevbox/koha/etc/z3950 --debug 2 - Connect using yaz-client: yaz-client localhost:2100 2.1 Alternative, if you add the responder as a Z39.50 server in Koha and do a catalogue Z39.50 search. Don't forget to search in the keywords field. Not the title field. 3 - base biblios 4 - find bruce 5 - No results 6 - Stop the responder 7 - Apply patch 8 - Repeat 9 - This time you get results Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103698|0 |1 is obsolete| | --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104294&action=edit Bug 25277: Unit test Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Test plan added. It was compiled from the previous comment. And with this addition:
2.1 Alternative, if you add the responder as a Z39.50 server in Koha and do a catalogue Z39.50 search. Don't forget to search in the keywords field. Not the title field.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104293|0 |1 is obsolete| | Attachment #104294|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104942&action=edit Bug 25277: Don't specify a field in query if none passed == test plan == To test: 0 - Have Koha running with ES 6 enabled 1 - Launch the z3950 responder: perl misc/z3950_responder.pl --config-dir /kohadevbox/koha/etc/z3950 --debug 2 - Connect using yaz-client: yaz-client localhost:2100 2.1 Alternative, if you add the responder as a Z39.50 server in Koha and do a catalogue Z39.50 search. Don't forget to search in the keywords field. Not the title field. 3 - base biblios 4 - find bruce 5 - No results 6 - Stop the responder 7 - Apply patch 8 - Repeat 9 - This time you get results Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: Removed unecessary () in the return statement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104943&action=edit Bug 25277: Unit test Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #15 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|major |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org