[Bug 25308] New: When cataloguing search fields are prefilled form record, content after & is cut off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Bug ID: 25308 Summary: When cataloguing search fields are prefilled form record, content after & is cut off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To test: - Add a new record from default framework in cataloguing - Enter something containing an & in the middle (Stuff & stuff) in 245$a 100$a - Click on Z39.50/SRU search - Verify the fields author and title are prefilled, but information is cut off at the & See also bug 11446 in this context. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | CC| |phil@chetcolibrary.org --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- If you really want to turn one bug into having to file dozens more, make your first step be "create a new MARC framework with the description Ants & Bees and the code A&B." Once you get past the inability to import an exported framework into it, and just click MARC structure and get the offer to copy in from default so you can use it to catalog, I'd expect there will be a lot more bustage (besides what I noticed fixing this, that when you find a record via Z39.50 and try to load it, it will come back into the nonexistent framework "A"). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 103892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103892&action=edit Bug 25308: Escape querystring for Z39.50 popup from cataloging Test plan: 1. For bonus fun, Administration -> MARC Frameworks -> New framework, with the code A&B and description Ants & Bees 2. In the A&B Actions menu, choose MARC structure since Import won't work 3. Accept the offer to copy in structure from default 4. Cataloging -> New record -> Ants & Bees 5. Type This & That in the 245$a (and for extra credit, in 020$a, and create an author authority with an & in it so you can put it in the 100/110) 6. Click Z39.50/SRU search, make sure everything you typed is prefilled including the parts after & 7. Search for anything that will retrieve a record (the ISBN This & That probably won't), choose Import 8. Check that the record came back, and verify in the Settings menu that it's still in the Ants & Bees framework. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Phil, in order to get the fixes in fast, it's good to split things into smaller bugs. This way your other patch can go in, while we work on the next ones. I think there is some expectation that people don't pick special chars for codes (like framework codes), but of course descriptions and data should work. It's still good to fix such things, but I think the risk for catalog data is higher. Thx for the patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103892|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104240&action=edit Bug 25308: Escape querystring for Z39.50 popup from cataloging Test plan: 1. For bonus fun, Administration -> MARC Frameworks -> New framework, with the code A&B and description Ants & Bees 2. In the A&B Actions menu, choose MARC structure since Import won't work 3. Accept the offer to copy in structure from default 4. Cataloging -> New record -> Ants & Bees 5. Type This & That in the 245$a (and for extra credit, in 020$a, and create an author authority with an & in it so you can put it in the 100/110) 6. Click Z39.50/SRU search, make sure everything you typed is prefilled including the parts after & 7. Search for anything that will retrieve a record (the ISBN This & That probably won't), choose Import 8. Check that the record came back, and verify in the Settings menu that it's still in the Ants & Bees framework. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works as described, there is an edge case for the frameworks, but I feel if at all, we should deal with them separately. People should really not use special chars in framework codes. Test: - Select the framework with A&B from the Z39.50 pull down for import - Search for any record and import it - Verify you end up on an empty page, instead of the filled framework. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When cataloguing search |When cataloguing search |fields are prefilled form |fields are prefilled from |record, content after & is |record, content after & is |cut off |cut off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104240|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 104925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104925&action=edit Bug 25308: Escape querystring for Z39.50 popup from cataloging Test plan: 1. For bonus fun, Administration -> MARC Frameworks -> New framework, with the code A&B and description Ants & Bees 2. In the A&B Actions menu, choose MARC structure since Import won't work 3. Accept the offer to copy in structure from default 4. Cataloging -> New record -> Ants & Bees 5. Type This & That in the 245$a (and for extra credit, in 020$a, and create an author authority with an & in it so you can put it in the 100/110) 6. Click Z39.50/SRU search, make sure everything you typed is prefilled including the parts after & 7. Search for anything that will retrieve a record (the ISBN This & That probably won't), choose Import 8. Check that the record came back, and verify in the Settings menu that it's still in the Ants & Bees framework. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- We could indeed find some more bugs in this area. Just looking at e.g. git grep Z3950Terms. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | --- Comment #9 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org