[Bug 7647] New: Checkout History Sort
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Priority: P5 - low Change sponsored?: --- Bug ID: 7647 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: Checkout History Sort QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: srdjan@catalyst.net.nz Hardware: All Status: NEW Version: master Component: Circulation Product: Koha With popular items the checkout history can be quite long and it is a challenge to sort through and find one libraries history of a book. Will put a table sorter on the checkout history. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|kyle.m.hall@gmail.com |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 8023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8023&action=edit patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I don't think we should be adding new instances of the tablesorter plugin when we're trying to switch to DataTables (Bug 5345 - DataTables in Koha). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5345 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8023|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 8677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8677&action=edit patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nengard@gmail.com --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- nengard@kohavm:~/kohaclone$ git bz apply 7647 Bug 7647 - Checkout History Sort patch Apply? [yn] y Applying: bug_7647: Table sorter on issue history error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt:1 error: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt: patch does not apply Patch failed at 0001 bug_7647: Table sorter on issue history When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/patch-v09mXq.patch nengard@kohavm:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #4)
nengard@kohavm:~/kohaclone$ git bz apply 7647 Bug 7647 - Checkout History Sort
patch Apply? [yn] y
Applying: bug_7647: Table sorter on issue history error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt:1 error: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt: patch does not apply Patch failed at 0001 bug_7647: Table sorter on issue history When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/patch-v09mXq.patch nengard@kohavm:~/kohaclone$
Don't forget to try git am -3. The patch actually applies fine with three-way merge. If you look at the last few lines, it actually gives you a hint of what to do next. You run the following two commands: git am --abort git am -3iu /tmp/patch-v09mXq.patch There's also a patched version of git-bz that takes care of that for you which you could download (I don't recall exactly wherefrom). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8677|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9438&action=edit bug_7647: Table sorter on issue history Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Ian Walls <koha.sekjal@gmail.com> --- Adds DataTables to item issue history to be more consistent with what we see on patron checkout history. Template only, with some javascript libraries. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Will be in 3.8.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7647 Bug 7647 depends on bug 5345, which changed state. Bug 5345 Summary: DataTables in Koha http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org