http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-05 10:57:48 UTC --- If you want to participate to the upstreaming: * assign the bug to yourself * retrieve the patch(es) on git.biblibre.com * the branch name can be found using git branch -a|grep NNNN Usually, it should be biblibre/customer/ft/MTNNNN For example: remotes/origin/stetienne/ft/MT6522 This patch is in branch number 5546 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@biblibre.co | |m AssignedTo|henridamien@koha-fr.org |jonathan.druart@biblibre.co | |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-17 15:02:30 UTC --- Created attachment 7719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7719 parcel.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-17 15:03:08 UTC --- Created attachment 7721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7721 addorderiso2709.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-17 15:03:38 UTC --- Created attachment 7723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7723 basketgroup.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-17 15:04:06 UTC --- Created attachment 7725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7725 lateorders.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-17 15:04:35 UTC --- Created attachment 7727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7727 newordersuggestion.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-17 15:04:59 UTC --- Created attachment 7729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7729 orderreceive.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-17 15:05:41 UTC --- Created attachment 7731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7731 spent.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-17 15:06:10 UTC --- Created attachment 7733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7733 uncertainprice.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Bug 5345 depends on bug 6836, which changed state. Bug 6836 Summary: jQuery plugin Datatables integration http://wiki.koha-community.org/wiki/DataTables_HowTo http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 What |Old Value |New Value ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8039|0 |1 is obsolete| | --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8040&action=edit Bug 5345 [FOLLOW-UP] DataTables in Koha Adding missing images: The "disabled" version of the next, previous, first, and last buttons. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #4)

Created attachment 7720 [details] acqui-home.tt

Are the controls really necessary on this page? On my screen the table is pretty small, and the top controls wrap to two lines in an ugly way. I would say either eliminate the controls altogether or have only a minimal set of controls on the top. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7734|0 |1 is obsolete| | --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8057&action=edit [SIGNED-OFF] Bug 5345: DataTables integration in acquisition module [16] z3950_search.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7727|0 |1 is obsolete| | --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8058&action=edit [SIGNED-OFF] Bug 5345: DataTables integration in acquisition module [9] newordersuggestion.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Alexandre Lengereau <alexandre.lengereau@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alexandre.lengereau@biblibr | |e.com --- Comment #26 from Alexandre Lengereau <alexandre.lengereau@biblibre.com> --- <h1>Something went wrong !</h1>Applying: Bug 5345: DataTables integration in acquisition module [1]<br/> Using index info to reconstruct a base tree...<br/> Falling back to patching base and 3-way merge...<br/> Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt<br/> Applying: Bug 5345: DataTables integration in acquisition module [2]<br/> Applying: Bug 5345: DataTables integration in acquisition module [3]<br/> Applying: Bug 5345: DataTables integration in acquisition module [4]<br/> Applying: Bug 5345: DataTables integration in acquisition module [5]<br/> Applying: Bug 5345: DataTables integration in acquisition module [6]<br/> Applying: Bug 5345: DataTables integration in acquisition module [7]<br/> Using index info to reconstruct a base tree...<br/> Falling back to patching base and 3-way merge...<br/> Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt<br/> Applying: Bug 5345: DataTables integration in acquisition module [8]<br/> Applying: Bug 5345: DataTables integration in acquisition module [10]<br/> Applying: Bug 5345: DataTables integration in acquisition module [11]<br/> Applying: Bug 5345: DataTables integration in acquisition module [12]<br/> Using index info to reconstruct a base tree...<br/> Falling back to patching base and 3-way merge...<br/> Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt<br/> CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt<br/> Failed to merge in the changes.<br/> Patch failed at 0001 Bug 5345: DataTables integration in acquisition module [12]<br/> When you have resolved this problem run git am --resolved.<br/> If you would prefer to skip this patch, instead run git am --skip.<br/> To restore the original branch and stop patching run git am --abort.<br/> Bug 5345 - DataTables in Koha<br/> <br/> parcel.tt<br/> Apply? [yn] <br/> acqui-home.tt<br/> Apply? [yn] <br/> addorderiso2709.tt<br/> Apply? [yn] <br/> basket.tt<br/> Apply? [yn] <br/> basketgroup.tt<br/> Apply? [yn] <br/> histsearch.tt<br/> Apply? [yn] <br/> lateorders.tt<br/> Apply? [yn] <br/> neworderbiblio.tt<br/> Apply? [yn] <br/> ordered.tt<br/> Apply? [yn] <br/> orderreceive.tt<br/> Apply? [yn] <br/> parcels.tt<br/> Apply? [yn] <br/> Patch left in /tmp/parcelstt-AYmmg0.patch<br/> <br/>=== translation installation ===<br/>Install templates Install templates 'opac From: /home/koha/src/koha-tmpl/opac-tmpl/prog/en/ To : /home/koha/src/koha-tmpl/opac-tmpl/prog/fr-FR With: /home/koha/src/misc/translator/po/fr-FR-i-opac-t-prog-v-3006000.po The install seems to be successful. Install templates 'intranet From: /home/koha/src/koha-tmpl/intranet-tmpl/prog/en/ To : /home/koha/src/koha-tmpl/intranet-tmpl/prog/fr-FR With: /home/koha/src/misc/translator/po/fr-FR-i-staff-t-prog-v-3006000.po The install seems to be successful. If you use this system for the 1st time, you may find usefull to reach the wiki page http://wiki.koha-community.org/wiki/Sandboxes to have some information about those results, to check if everything went well & if you can test the patch properly -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch can not be tested with a sandbox. Please Test these patches individually -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) parcel.tt - still applies on current master, but basket and order line columns are not sortable. When clicking on the sort options, I see a javasript error in Firebug. FAILED QA 2) acqui-home.tt - still applies on current master and works. I am not sure having the full toolbar here is necessary - but it works. I see that Owen has commented on that too. NOT signing off. 3) addorderiso2709.tt - still applies on current master. Only affects the list of imports, not the list of records. Signing off. 4) basket.tt - still applies on current master. Modify and Delete columns are sortable. That's not necessary and could be removed in a follow up. Signing off. 5) basketgroup.tt - still applies to master but I don't see where it's applied? QUESTION 6) histsearch.tt - still applies to current master and works. Signing off. 7) lateorders.tt - does not apply. FAILED QA CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt 8) neworderbiblio.tt - still applies on current master. There is still a pagination on top of the page. I think sorting only a single result page does not make sense. We should remove the pagination in favor of the datatables or keep pagination for now. FAILED QA 9) ordered.tt - still applies on current master and works. Signing off. 10) orderreceive.tt - does not apply. FAILED QA CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt 11) spent.tt - still applies on current master and works. Signing off. 12) supplier.tt - still applies on current master and works. Here - similar to aqui-home.tt I am not sure the full toolbars are needed for the contracts table. I think having sortable columns would be enough. NOT signing off. 13) uncertainprice.tt - still applies on current master and works. Signing off. 14) DataTables missing some required images Works, signing off. 15) parcels.tt - still applies on current master, but there is a merge marker in the patch - FAILED QA. # Failed test './koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt contains merge conflict markers in line 79' # at t/00-merge-conflict-markers.t line 51. # Looks like you failed 1 test of 6260. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8040|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8830&action=edit [SIGNED-OFF] Bug 5345 [FOLLOW-UP] DataTables in Koha Adding missing images: The "disabled" version of the next, previous, first, and last buttons. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7731|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8833&action=edit [SIGNED-OFF] Bug 5345: DataTables integration in acquisition module [13] spent.tt Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7724|0 |1 is obsolete| | --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8835&action=edit [SIGNED-OFF] Bug 5345: DataTables integration in acquisition module [6] histsearch.tt Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7721|0 |1 is obsolete| | --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8837&action=edit [SIGNED-OFF] Bug 5345: DataTables integration in acquisition module [3] addorderiso2709.tt Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Only affects the list of imports, not the list of records -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8057|[SIGNED-OFF] Bug 5345: |[PASSED_QA][SIGNED-OFF] Bug description|DataTables integration in |5345: DataTables |acquisition module [16] |integration in acquisition | |module [16] -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #42 from Paul Poulain <paul.poulain@biblibre.com> --- back to sign-off for the patches that are waiting for marcel's QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8058|[SIGNED-OFF] Bug 5345: |[PASSED_QA][SIGNED-OFF] Bug description|DataTables integration in |5345: DataTables |acquisition module [9] |integration in acquisition | |module [9] -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8831|[SIGNED-OFF] Bug 5345: |[PASSED_QA][SIGNED-OFF] Bug description|DataTables integration in |5345: DataTables |acquisition module [15] |integration in acquisition | |module [15] -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8834|[SIGNEd-OFF] Bug 5345: |[PASSED_QA][SIGNED-OFF] Bug description|DataTables integration in |5345: DataTables |acquisition module [10] |integration in acquisition | |module [10] -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #46 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- 8831, 8833 and 8834 passed qa. 8835 replaced by 9519 too. Coming back soon for 8836 and 8837. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8831|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8834|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #47 from Paul Poulain <paul.poulain@biblibre.com> --- All now-marked-obsolete patches have been pushed, others still need signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #49 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #47)

All now-marked-obsolete patches have been pushed, others still need signoff

Could be that a mistake was made somewhere? Note that Bug 5345: DataTables integration in acquisition module [6] did not yet pass QA, but has already been pushed. (Just noting for the record.) Also DataTables integration in acquisition module [4] has been obsoleted. Please check if that is correct. Not QAed nor pushed as far as I can see. DataTables integration in acquisition module [3] should still be QAed. Some of the other patches are actually in a kind of Failed QA-state; see the comments from Katrin. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #51 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #50)

Marcel is right, I failed some QA - in the comments. I didn't know how to better do it. I could have reattached the file pehraps, but instead of [SIGNED OFF] marked with [FAILED QA]. You do not need to reattach, just change the description with Edit Details (two clicks away).

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8098 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8100 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8102 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8104 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8106 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7726|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 7726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7726 neworderbiblio.tt see Bug 8100 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7732|0 |1 is obsolete| | --- Comment #56 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 7732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7732 supplier.tt see Bug 8102 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9601|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 9601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9601 lateorders.tt see Bug 8104 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #60 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 9602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9602 basketgroup.tt see Bug 8105 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8837|0 |1 is obsolete| | --- Comment #62 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 8837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8837 [SIGNED-OFF] Bug 5345: DataTables integration in acquisition module [3] see Bug 8106 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #64 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #50)

Even better I think woudl be a meta bug for changes like this, with lots of smaller bugs surrounding with single patches. Much easier to manage and not growing endlessly like this one.

Done :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 --- Comment #66 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #49)

(In reply to comment #47)

...

All now-marked-obsolete patches have been pushed, others still need signoff

Could be that a mistake was made somewhere? Note that Bug 5345: DataTables integration in acquisition module [6] did not yet pass QA, but has already been pushed. (Just noting for the record.)

Yes, indeed :-/

Also DataTables integration in acquisition module [4] has been obsoleted. Please check if that is correct. Not QAed nor pushed as far as I can see.

DataTables integration in acquisition module [3] should still be QAed. Some of the other patches are actually in a kind of Failed QA-state; see the comments from Katrin.

Yes I created 2 new Bugs for them, Bug 8106 - DataTables in Acquisision module: addorderiso2709.tt for [3] and Bug 8109 - DataTables in Acquisision module: basket.tt for [4] I am under the impression that all bugs have a new Bug or have already pushed. I hope it will be much easier to test like this. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m Depends on| |8234 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8395 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Bug 5345 depends on bug 8109, which changed state. Bug 8109 Summary: DataTables in Acquisision module: basket.tt http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8109 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.