[Bug 11270] New: Search Result highlighting should be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 Bug ID: 11270 Summary: Search Result highlighting should be refactored Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: campbellreidtait@gmail.com, chris@bigballofwax.co.nz, gitbot@bugs.koha-community.org, jonathan.druart@biblibre.com, katrin.fischer@bsz-bw.de, kyle@bywatersolutions.com, martin.renvoize@ptfs-europe.com, paul.poulain@biblibre.com, savitra.sirohi@osslabs.biz, spalding@senylrc.org Depends on: 6149 Whilst working on Bug 6149 I found there to be many repeats of code in different file relating to the search highlighting. This patch tries to factor out some of the code into include's to enhance maintainability. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 23039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23039&action=edit Bug 11270: Refactor hit highliginting code This patch tries to factor out some of the hit highlighting code to aid in future maintainability. It should not affect current operation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |magnus@enger.priv.no --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- Looks like this should be "Needs signoff" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Could you post a test plan? Also, the code seems slightly different in opac-results.tt versus opac-results-grouped.tt. I've never used the latter (as I don't use pazpar2), so I'm not sure I can test this one... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 23039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23039 Bug 11270: Refactor hit highliginting code Review of attachment 23039: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11270&attachment=23039) ----------------------------------------------------------------- Please split the bootstrap and prog patches into two seperate patch files. It is my understanding, which could be flawed, but given that 3.18 is likely to deprecate prog/cssr, you want to not include prog/cssr patches in master. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt @@ -356,5 @@
- $("td").highlight(q_array[x]); - } - } - $(".highlight_toggle").toggle(); -}
The two functions were in this code, and are moved to opac-highlight.inc, but there is no include in this file. How are these functions still provided? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to M. Tompsett from comment #4)
Comment on attachment 23039 [details] [review] Bug 11270: Refactor hit highliginting code
Review of attachment 23039 [details] [review]: -----------------------------------------------------------------
Please split the bootstrap and prog patches into two seperate patch files. It is my understanding, which could be flawed, but given that 3.18 is likely to deprecate prog/cssr, you want to not include prog/cssr patches in master.
prog and cssr already are deprecated, but they will be removed in 3.18. Here is the relevant coding guideline http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML5:_Deprecation_of_... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |srdjan@catalyst.net.nz --- Comment #6 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- I could not apply the patch. Can you please check. Plus needs prog removal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38939&action=edit Bug 11270: Search Result highlighting should be refactored (master) Whilst working on Bug 6149 I found there to be many repeats of code in different file relating to the search highlighting. This patch tries to factor out some of the code into include's to enhance maintainability. This is just the bootstrap portions. Untested. This should apply. However, Martin Renvoize has yet to post a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23039|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38940&action=edit Bug 11270: Search Result highlighting should be refactored (3.16.x) Whilst working on Bug 6149 I found there to be many repeats of code in different file relating to the search highlighting. This patch tries to factor out some of the code into include's to enhance maintainability. This is just the bootstrap portions. Untested. This should apply. However, Martin Renvoize has yet to post a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38940|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38941&action=edit Bug 11270: Search Result highlighting should be refactored (3.16.x) Whilst working on Bug 6149 I found there to be many repeats of code in different file relating to the search highlighting. This patch tries to factor out some of the code into include's to enhance maintainability. This is just the bootstrap portions. Untested. This should apply. However, Martin Renvoize has yet to post a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |martin.renvoize@ptfs-europe | |.com CC| |mtompset@hotmail.com Status|Patch doesn't apply |ASSIGNED --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Changing back to assigned to Martin, since he posted the initial patches, and he never responded with a test plan. :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org