[Bug 14061] New: Inventory fails to map withdrawn authorized values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Bug ID: 14061 Summary: Inventory fails to map withdrawn authorized values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org if ($f and $sf) fails if: $f is NULL,'', or 0 and similarly with $sf. 952$0 = withdrawn status. This should be (defined $f and defined $sf). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38485&action=edit Bug 14061: Fix broken mapping for not withdrawn items. TEST PLAN --------- 1) Run inventory on a filtered set such that the selected barcode is not withdrawn. -- the Withdrawn column displays '0'. 2) Apply patch 3) Rerun -- the Withdrawn column displays '' (as expected) 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12909 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 38486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38486&action=edit statuses say 0 It's not just withdrawn that shows 0 by the way ... it's all status columns -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Also, after applying the patch I still see 0 ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 38487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38487&action=edit after patch I still see 0 after patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Please post a screen shot of your authorized values for WITHDRAWN. If there is no mapping for WITHDRAWN=0, then it will still show 0. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 38488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38488&action=edit authorized values on first test I didn't have a zero -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 38489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38489&action=edit authorized values on second test I added a 0 with no description -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 38490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38490&action=edit withdrawn cataloging with the 0 value I get a 0 in my withdrawn pull down when cataloging now ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #9 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 38491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38491&action=edit limit to withdrawn with patch With the patch when I limit to withdrawn I get a 1 instead of the word 'withdrawn' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38485|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38493&action=edit Bug 14061: Fix broken mapping for not withdrawn items. TEST PLAN --------- 1) Check what values to have entered for WITHDRAWN authorized values (Home -> Koha Administration -> Authorized values change dropdown to WITHDRAWN) 2) Add a new authorized value of 0 () if one is missing. 3) Add a new authorized value of 1 (Withdrawn) if one is missing. 4) Run inventory on a filtered set such that the selected barcode is not withdrawn. (Home -> Tools -> Inventory/stocktaking) -- the Withdrawn column displays '0'. 5) Run inventory on a filtered set such that the selected barcode is withdrawn. -- the Withdrawn column displays '1'. 6) Apply patch 7) Rerun steps 4 & 5 -- the Withdrawn column displays the descriptions as seen in steps 1-3. 8) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- I'm doing a fresh base install to see if I can replicate your failures, because I can't on my current system. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14057 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Painfully, I redid a fresh install on Ubuntu 14.04 LTS a full git install from scratch. I ran it without the patch Withdrawn = 0 in the table (as is all the fields beside Withdrawn). I then ran it with the patch. Everything was still 0. I then checked my authorised values, and there was no 0, so I added it 'Not Withdrawn'. Re-ran, and 'Not Withdrawn' is displayed now. I figured I'd check it out. Then re-run, I got a nice yellow warning telling me it checked it back in. So, I re-ran it again, and got 'Not Withdrawn'. Nicole, I think your settings are a-typical or something. I'm going to put this back to 'Needs Signoff' and perhaps someone else with be able to duplicate the issue with the... test plan in comment #10. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 38505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38505&action=edit [Signed-off] Bug 14061: Fix broken mapping for not withdrawn items. TEST PLAN --------- 1) Check what values to have entered for WITHDRAWN authorized values (Home -> Koha Administration -> Authorized values change dropdown to WITHDRAWN) 2) Add a new authorized value of 0 () if one is missing. 3) Add a new authorized value of 1 (Withdrawn) if one is missing. 4) Run inventory on a filtered set such that the selected barcode is not withdrawn. (Home -> Tools -> Inventory/stocktaking) -- the Withdrawn column displays '0'. 5) Run inventory on a filtered set such that the selected barcode is withdrawn. -- the Withdrawn column displays '1'. 6) Apply patch 7) Rerun steps 4 & 5 -- the Withdrawn column displays the descriptions as seen in steps 1-3. 8) run koha qa test tools Followed test plan #1-#7. Aut. value for 0 set to: 'No' amd 1: "withdrawn'. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #38493|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38505|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38735&action=edit [PASSED QA] Bug 14061: Fix broken mapping for not withdrawn items. TEST PLAN --------- 1) Check what values to have entered for WITHDRAWN authorized values (Home -> Koha Administration -> Authorized values change dropdown to WITHDRAWN) 2) Add a new authorized value of 0 () if one is missing. 3) Add a new authorized value of 1 (Withdrawn) if one is missing. 4) Run inventory on a filtered set such that the selected barcode is not withdrawn. (Home -> Tools -> Inventory/stocktaking) -- the Withdrawn column displays '0'. 5) Run inventory on a filtered set such that the selected barcode is withdrawn. -- the Withdrawn column displays '1'. 6) Apply patch 7) Rerun steps 4 & 5 -- the Withdrawn column displays the descriptions as seen in steps 1-3. 8) run koha qa test tools Followed test plan #1-#7. Aut. value for 0 set to: 'No' amd 1: "withdrawn'. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |RESOLVED Resolution|--- |INVALID --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Because Bug 14057 was pushed to master, this bug is invalid. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org