[Bug 24076] New: Remove inline CSS to center patron home library in search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 Bug ID: 24076 Summary: Remove inline CSS to center patron home library in search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 9811 The DataTables configuration for patron search results adds inline CSS to center the contents of column #5, currently patron library. I'm not sure if other data was originally targeted by the #5 column, but I don't think it makes sense logically or visually to center the library in the table. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 [Bug 9811] Patrons search improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 95638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95638&action=edit Bug 24076: Remove inline CSS to center patron home library in search results This patch removes code from the patron search results DataTable configuration which was designed to add "text-align:center" to the table cells containing patron home library. I don't think there's a good reason to centering to that data. To test, apply the patch and perform a patron search in the staff client. The "Library" column should contain left-aligned data, matching almost every other column in the table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95638|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 95768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95768&action=edit Bug 24076: Remove inline CSS to center patron home library in search results This patch removes code from the patron search results DataTable configuration which was designed to add "text-align:center" to the table cells containing patron home library. I don't think there's a good reason to centering to that data. To test, apply the patch and perform a patron search in the staff client. The "Library" column should contain left-aligned data, matching almost every other column in the table. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org