[Bug 23905] New: Button "Search to add" don't wor at Quick add new patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Bug ID: 23905 Summary: Button "Search to add" don't wor at Quick add new patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: black23@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In current master button "Search to add" in Quick add ne patron page don't open search window. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Summary|Button "Search to add" |Button "Search to add" |don't wor at Quick add new |doesn't work on Quick add |patron |new patron --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested and confirmed on master - you can no longer add guarantors from the quick add form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23778 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think it has been caused by commit bc9871f428af323901ebe57a6d0888f1dcf871cf Bug 23778: Regression: Guarantor entry section no longer has a unique id Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23778 [Bug 23778] Regression: Guarantor entry section no longer has a unique id -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14570 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- But I think it's also broken since bug 14570. This must be fixed for 19.11. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 95798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95798&action=edit Bug 23905: Button "Search to add" doesn't work on Quick add new patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- This fixes the popup not showing, but after selecting a patron, the info is not added to the page. the line: $('#guarantor_relationships').append( fieldset ); simply does nothing. If you add it to something outside of #guarantor_relationships such as 'body' or '#quick_add_form' it shows up! I'm not sure why it refused to append to '#guarantor_relationships'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- I have a hunch that it has to do with these elements not existing at the time the page is loaded. These elements are created dynamically via javascript, right? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- In addition, I just realized the guarantor 'template' is visible on the quick add form, but should not be. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #7)
In addition, I just realized the guarantor 'template' is visible on the quick add form, but should not be.
Are we sure about that? I was wondering too, but there is a note referring quick add and guarantor: Note: Quick add guarantor form populates address fields in full form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95798|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 95800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95800&action=edit Bug 23905: Button "Search to add" doesn't work on Quick add new patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95800|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 95803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95803&action=edit Bug 23905: Button "Search to add" doesn't work on Quick add new patron This issue is caused by duplicating the patron guarantor fieldset. The solution is to move it between the two forms insetad. In addition, this patch moves the guarantor information fieldset to the area below the "Quick add" fieldset, instead of *inside* it. This change preserves the correct styling and layout of the Guarantor information fieldset whilst it is moved back and forth by the "quick add"/"full form" toggle. Test Plan: 1) Quick add a child patron 2) Attempt to use the "Search to add" button 3) Note it does nothing 4) Apply this patch 5) Repeat steps 1 and 2 6) It works now! 7) Test toggling between the quick add and full form views, note the "Guarantor information" fieldset shows correctly in the full form view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95803|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 95804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95804&action=edit Bug 23905: Button "Search to add" doesn't work on Quick add new patron This issue is caused by duplicating the patron guarantor fieldset. The solution is to move it between the two forms insetad. In addition, this patch moves the guarantor information fieldset to the area below the "Quick add" fieldset, instead of *inside* it. This change preserves the correct styling and layout of the Guarantor information fieldset whilst it is moved back and forth by the "quick add"/"full form" toggle. Test Plan: 1) Quick add a child patron 2) Attempt to use the "Search to add" button 3) Note it does nothing 4) Apply this patch 5) Repeat steps 1 and 2 6) It works now! 7) Test toggling between the quick add and full form views, note the "Guarantor information" fieldset shows correctly in the full form view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95804|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95812&action=edit Bug 23905: Button "Search to add" doesn't work on Quick add new patron This issue is caused by duplicating the patron guarantor fieldset. The solution is to move it between the two forms insetad. In addition, this patch moves the guarantor information fieldset to the area below the "Quick add" fieldset, instead of *inside* it. This change preserves the correct styling and layout of the Guarantor information fieldset whilst it is moved back and forth by the "quick add"/"full form" toggle. Test Plan: 1) Quick add a child patron 2) Attempt to use the "Search to add" button 3) Note it does nothing 4) Apply this patch 5) Repeat steps 1 and 2 6) It works now! 7) Test toggling between the quick add and full form views, note the "Guarantor information" fieldset shows correctly in the full form view. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95813&action=edit Bug 23905: Remove extra closing span Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95812|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95818&action=edit Bug 23905: Button "Search to add" doesn't work on Quick add new patron This issue is caused by duplicating the patron guarantor fieldset. The solution is to move it between the two forms insetad. In addition, this patch moves the guarantor information fieldset to the area below the "Quick add" fieldset, instead of *inside* it. This change preserves the correct styling and layout of the Guarantor information fieldset whilst it is moved back and forth by the "quick add"/"full form" toggle. Test Plan: 1) Quick add a child patron 2) Attempt to use the "Search to add" button 3) Note it does nothing 4) Apply this patch 5) Repeat steps 1 and 2 6) It works now! 7) Test toggling between the quick add and full form views, note the "Guarantor information" fieldset shows correctly in the full form view. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95813|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95819&action=edit Bug 23905: Remove extra closing span Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks good to me, thanks guys.. PQA and Pushing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org