[Bug 38502] New: Use Bootstrap alert info class for messages on table settings page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 Bug ID: 38502 Summary: Use Bootstrap alert info class for messages on table settings page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There are a couple of informational messages on the table settings page which are wrapped in <div class="alert">, a class which doesn't add any style. These should be updated to be <div class="alert alert-info"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174871&action=edit Bug 38502: Use Bootstrap alert info class for messages on table settings page This patch updates the table settings template to add style to informational messages. To test, apply the patch and go to Administration -> Table settings. - Go to Catalog -> detail -> holdings_table. Above the table's settings you should see a message, "Please not that if a field..." It should have the standard Bootstrap "info" style. - Go to Cataloging -> additem. You should see a similarly styled message, "Changes made below..." Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174871|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 176108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176108&action=edit Bug 38502: Use Bootstrap alert info class for messages on table settings page This patch updates the table settings template to add style to informational messages. To test, apply the patch and go to Administration -> Table settings. - Go to Catalog -> detail -> holdings_table. Above the table's settings you should see a message, "Please not that if a field..." It should have the standard Bootstrap "info" style. - Go to Cataloging -> additem. You should see a similarly styled message, "Changes made below..." Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176108|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176643&action=edit Bug 38502: Use Bootstrap alert info class for messages on table settings page This patch updates the table settings template to add style to informational messages. To test, apply the patch and go to Administration -> Table settings. - Go to Catalog -> detail -> holdings_table. Above the table's settings you should see a message, "Please not that if a field..." It should have the standard Bootstrap "info" style. - Go to Cataloging -> additem. You should see a similarly styled message, "Changes made below..." Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the styles for release notes| |informational messages on | |the table settings page | |(Administration > | |Additional parameters > | |Table settings). It updates | |the existing class | |(class="alert"), which | |doesn't add any style, to | |the Bootstrap 5 class | |(class="alert alert-info") | |- which now has a light | |blue background. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38502 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org