[Bug 38783] New: Row highlighting table_readingrec members/readingrec.pl doesn't look great
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Bug ID: 38783 Summary: Row highlighting table_readingrec members/readingrec.pl doesn't look great Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Make some checkout to a patron so they have a circulation history, have some items checked in and some still on loan. 2. Look at the table, you can see that there can be 4 possible background colors for each row (#ffffff, #f3f4f4, #F9FAE0, and #FFFFCC ) I think that's is too many row colors and make the table look ... not great. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Row highlighting |Row highlighting in |table_readingrec |table_readingrec |members/readingrec.pl |members/readingrec.pl |doesn't look great |doesn't look great -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 --- Comment #1 from Cheryl <clackman@fargolibrary.org> --- The problem I had with it is that returned items have alternating shades of grey and white line by line, but items still checked out alternate between yellow and an effectively identical shade of grey to the grey in the returned item alternating lines. Returned items: white/grey Checked out items: yellow/grey So you can't tell the difference between an item that is grey because it's returned (and not white), and an item that is grey because it's checked out (and not yellow). This is especially unhelpful when you're trying to sort by checkout date and not return date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Furthermore, the green links ( #408540 ) on a yellow background ( #FFFFCC ) do not meet accessibility standards for color contrast. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |accessibility -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I don't love the yellow row highlighting. It is meaningless unless you happen to know it represents an on loan item. I think we should add a Bootstrap badge somewhere on the row with the text 'Checked out'. It already exists in the return date column. Maybe we can just make that a yellow bade, so it stands out more. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 --- Comment #4 from Cheryl <clackman@fargolibrary.org> --- What if it was with the title column, or the barcode column? The return date/checked out column is all the way over on the right side, very far away from the title. You would most likely be looking at the title in the first place, and it would just be faster to see the most relevant information all at one go. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176540&action=edit Proposed change to Bootstrap badges -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Cheryl from comment #4)
What if it was with the title column, or the barcode column? The return date/checked out column is all the way over on the right side, very far away from the title. You would most likely be looking at the title in the first place, and it would just be faster to see the most relevant information all at one go.
I do think the 'Return date' column makes the most sense. I uploaded an attachment of what that would look like. I don't love the idea of attaching it to a a column that has nothing to do with, return date/onloan status like title or barcode. We will attach that patch, adding it to 'Return date'. I am also going to CC some others to see what they think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Leo Stoyanov <leo.stoyanov@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 --- Comment #7 from Leo Stoyanov <leo.stoyanov@bywatersolutions.com> --- Created attachment 176541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176541&action=edit Bug 38783: Added "Checked out" badge for checked out items in the circulation history table. To test: 1. Make some checkout to a patron so they have a circulation history, with some items checked in and some still on loan. 2. Look at the patron's "Circulation history" table. There are four possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0, and #FFFFCC. 3. Apply the patch, update the CSS (yarn build), and restart everything (restart_all). 4. Repeat steps 1-2, if needed. An orange/gold badge will appear under the "Return date" column of the table for items that have been checked out, and there will no longer be alternating, pale yellow rows. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176541|0 |1 is obsolete| | --- Comment #8 from Magnus Enger <magnus@libriotech.no> --- Created attachment 176542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176542&action=edit Bug 38783: Added "Checked out" badge for checked out items in the circulation history table. To test: 1. Make some checkout to a patron so they have a circulation history, with some items checked in and some still on loan. 2. Look at the patron's "Circulation history" table. There are four possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0, and #FFFFCC. 3. Apply the patch, update the CSS (yarn build), and restart everything (restart_all). 4. Repeat steps 1-2, if needed. An orange/gold badge will appear under the "Return date" column of the table for items that have been checked out, and there will no longer be alternating, pale yellow rows. Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. I agree that it looks better now than before, and that it is easier to tell the checked out items from the returned items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Leo Stoyanov <leo.stoyanov@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leo.stoyanov@bywatersolutio | |ns.com Assignee|koha-bugs@lists.koha-commun |leo.stoyanov@bywatersolutio |ity.org |ns.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176542|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176647&action=edit Bug 38783: Added "Checked out" badge for checked out items in the circulation history table. To test: 1. Make some checkout to a patron so they have a circulation history, with some items checked in and some still on loan. 2. Look at the patron's "Circulation history" table. There are four possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0, and #FFFFCC. 3. Apply the patch, update the CSS (yarn build), and restart everything (restart_all). 4. Repeat steps 1-2, if needed. An orange/gold badge will appear under the "Return date" column of the table for items that have been checked out, and there will no longer be alternating, pale yellow rows. Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. I agree that it looks better now than before, and that it is easier to tell the checked out items from the returned items. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176648&action=edit Bug 38783: (follow-up) Remove obsolete .badge-pill class .badge-pill is from a previous version of Bootstrap. .rounded-pill is the current version, but I think it looks better without. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176647|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176944&action=edit Bug 38783: Added "Checked out" badge for checked out items in the circulation history table. To test: 1. Make some checkout to a patron so they have a circulation history, with some items checked in and some still on loan. 2. Look at the patron's "Circulation history" table. There are four possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0, and #FFFFCC. 3. Apply the patch, update the CSS (yarn build), and restart everything (restart_all). 4. Repeat steps 1-2, if needed. An orange/gold badge will appear under the "Return date" column of the table for items that have been checked out, and there will no longer be alternating, pale yellow rows. Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. I agree that it looks better now than before, and that it is easier to tell the checked out items from the returned items. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176648|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176945&action=edit Bug 38783: (follow-up) Remove obsolete .badge-pill class .badge-pill is from a previous version of Bootstrap. .rounded-pill is the current version, but I think it looks better without. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38954 CC| |jonathan.druart@gmail.com --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Found bug 38954 when QAing this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #14 from David Nind <david@davidnind.com> --- Just to say that this is a great improvement! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38954 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 [Bug 38954] checkout type column should be hidden by colvis -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Row highlighting in |Row highlighting in |table_readingrec |circulation history table |members/readingrec.pl |of a user doesn't look |doesn't look great |great -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's stuff like this, the small changes. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Row highlighting in |Row highlighting in the |circulation history table |circulation history table |of a user doesn't look |for a patron doesn't look |great |great Text to go in the| |This fixes the circulation release notes| |history table for a patron, | |and makes it easier to | |identify checked out items: | |- the alternating row | |background colors are now | |white and grey, rather | |than: | | . Returned items: | |white/grey | | . Checked out | |items: yellow/grey | |- | |checked out items are now | |shown as "Checked out" | |using an orange/gold badge | |in the "Return date" column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 --- Comment #17 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #18 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Is it possible this is broken? I was trying it out to see what it was supposed to do and the circ history is now all different shades of yellow? Is that what it was meant to do? I was expecting the regular grey and white alternating rows with the only yellow being the badge/pill thing. https://snipboard.io/EmDeyG.jpg This is on a fresh KTD. I'm assuming spinning it up does the CSS update/magic thingy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 --- Comment #19 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Caroline Cyr La Rose from comment #18)
Is it possible this is broken? I was trying it out to see what it was supposed to do and the circ history is now all different shades of yellow? Is that what it was meant to do? I was expecting the regular grey and white alternating rows with the only yellow being the badge/pill thing.
https://snipboard.io/EmDeyG.jpg
This is on a fresh KTD. I'm assuming spinning it up does the CSS update/magic thingy.
I didn't specify, but I'm on main (I also tried on 25.05.02, with the same result). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- It's broken. An error in rebases of Bug 38714 looks to be the cause. https://gitlab.com/koha-community/Koha/-/commit/c0961118625b2d398fba5bbf0960... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 [Bug 40592] Fix incorrect row highlighting on patron checkout history page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #21 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org