[Bug 19188] New: Self checkout: missing space if fine amount is blocking renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Bug ID: 19188 Summary: Self checkout: missing space if fine amount is blocking renewal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When a fine amount is blocking the renewal in the web based self checkout, the message reads like: ... EUR15.00 ... EUR is the active currency in my system, so display might vary a bit. We should add a space there and it might be nice to use the Price TT plugin for formatting the fine nicely. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Can you please provide a plan of how to reproduce this and where the message shows? I can't seem to reproduce the bug but I may be trying to create it in the wrong place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's been a little while, did you try the web based self check with a fine amount on the account over what is set in OPACFineNoRenewals? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The problem is here: sco-main.tt 55 [% ELSIF ( circ_error_DEBT ) %] 56 You owe the library [% amount %] and cannot check out. opac / sco / sco-main.pl 165 if ($issue_error eq 'DEBT') { 166 $template->param(amount => $currencySymbol.$impossible->{DEBT}); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 jwayway@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 --- Comment #4 from jwayway@hotmail.com --- Created attachment 70577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70577&action=edit Bug-19188: Self checkout missing space for price Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. Login to localhost:8081 and issue a book 3. In OPAC give user fine by going to 'my account' at top right 4. Then under fines tab 'create manual invoice' 5. Make sure this amount is more than OPACFineNoRenenwals which can be changed under System prefernces 6. Back in localhost:8081, try renewing the book 7. Error 'Item cannot be checked out' should occur 8. Without patch the currency symbol and amount is together 9. With patch there should be a space in between -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70577|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70608&action=edit Bug 19188: Self checkout missing space for price Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. Login to localhost:8081 and issue a book 3. In OPAC give user fine by going to 'my account' at top right 4. Then under fines tab 'create manual invoice' 5. Make sure this amount is more than OPACFineNoRenenwals which can be changed under System prefernces 6. Back in localhost:8081, try renewing the book 7. Error 'Item cannot be checked out' should occur 8. Without patch the currency symbol and amount is together 9. With patch there should be a space in between Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70608|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 70624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70624&action=edit Bug 19188: Self checkout missing space for price Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. Login to localhost:8081 and issue a book 3. In OPAC give user fine by going to 'my account' at top right 4. Then under fines tab 'create manual invoice' 5. Make sure this amount is more than OPACFineNoRenenwals which can be changed under System prefernces 6. Back in localhost:8081, try renewing the book 7. Error 'Item cannot be checked out' should occur 8. Without patch the currency symbol and amount is together 9. With patch there should be a space in between Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Assignee|koha-bugs@lists.koha-commun |jwayway@hotmail.com |ity.org | QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am wondering if we should not display the currency with the Price plugin instead. Delaying the push for now as I do not have time to deep more into it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71124&action=edit Bug 19188: Use the Price template plugin with_symbol => 1 To make it displayed correctly depending on the configuration of the currency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff Depends on| |4078 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have added a follow-up based on top of bug 4078. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Add the ability to customize and display the symbol for a currency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Bug 19188 depends on bug 4078, which changed state. Bug 4078 Summary: Add the ability to customize and display the symbol for a currency https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |charles.farmer@inlibro.com --- Comment #10 from Charles Farmer <charles.farmer@inlibro.com> --- Got 2 conflicts trying to apply the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jwayway@hotmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145708&action=edit Bug 19188: Self checkout missing currency symbol Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. In OPAC give user fine by going to 'my account' at top right 3. Then under fines tab 'create manual invoice' 4. Make sure this amount is more than noissuescharge which can be changed under system preferences 5. Go to the web based self check from the OPAC URL 6. Log in as your user 7. Try to check out an item 7. Error 'Item cannot be checked out' should occur 8. With the patch, the currency symbol should show for the amount. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Updated test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71124|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145709&action=edit Bug 19188: Use the Price template plugin with_symbol => 1 To make it displayed correctly depending on the configuration of the currency Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Self checkout: missing |Self checkout: Fine |space if fine amount is |blocking checkout is |blocking renewal |missing currency symbol --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a bit of a rescue mission for Jenny's patch. Rebased the original patch set, fixed test plan and made sure it worked with current code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70624|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145708|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 145763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145763&action=edit Bug 19188: Self checkout missing currency symbol Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. In OPAC give user fine by going to 'my account' at top right 3. Then under fines tab 'create manual invoice' 4. Make sure this amount is more than noissuescharge which can be changed under system preferences 5. Go to the web based self check from the OPAC URL 6. Log in as your user 7. Try to check out an item 7. Error 'Item cannot be checked out' should occur 8. With the patch, the currency symbol should show for the amount. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Updated test plan. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145709|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 145764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145764&action=edit Bug 19188: Use the Price template plugin with_symbol => 1 To make it displayed correctly depending on the configuration of the currency Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145763|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145864&action=edit Bug 19188: Self checkout missing currency symbol Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. In OPAC give user fine by going to 'my account' at top right 3. Then under fines tab 'create manual invoice' 4. Make sure this amount is more than noissuescharge which can be changed under system preferences 5. Go to the web based self check from the OPAC URL 6. Log in as your user 7. Try to check out an item 7. Error 'Item cannot be checked out' should occur 8. With the patch, the currency symbol should show for the amount. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145764|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145865&action=edit Bug 19188: Use the Price template plugin with_symbol => 1 To make it displayed correctly depending on the configuration of the currency Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|m.de.rooy@rijksmuseum.nl |martin.renvoize@ptfs-europe | |.com --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great to see this rescued, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 --- Comment #20 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Version(s)|23.05.00,22.11.03,22.05.10 |23.05.00,22.11.03,22.05.10, released in| |21.11.16 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #22 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.1x for 21.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #23 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org