https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Summary|Dropdown selector when |Dropdown selector when |changing pickup library is |changing pickup library |buggy |should not depend on | |RESTdefaultPageSize Resolution|WORKSFORME |--- --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It does solve it, but I think the dependency is not good - we should keep this open and look into changing the behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171969|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 171970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171970&action=edit Bug 34068: Fix pagination for hold pickup locations This patch addresses an issue where pagination filters are set incorrectly for the pickup locations endpoint. Only the final page is returned rather than the expected full list of results Test plan: 1) In KTD, set the syspref RESTdefaultPageSize to 5 2) Set AllowHoldPolicyOverride to Allow 3) Create a hold on an item for a patron 4) Navigate to the patron's page and click on the holds tab 5) Click the dropdown in pickup locations 6) There will be two results, repeated three times 7) Apply patch and restart_all 8) Repeat step 5, there should now be a full list of 12 libraries Co-authored-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174072&action=edit Bug 34068: Fix tests Several wrong things in the previous attempt: * as_list returns an array * as_list returns objects, ->{library_id} does not exist * as_list does not returns api object, you need to call ->branchcode to get the id * $pickup_locations defined for both situations was confusing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Tests are failing here for me now, not always, but it seems that if I set RESTdefaultPageSize to something other than 20 they fail: # Failed test 'exact match for JSON Pointer ""' # at /kohadevbox/koha/t/db_dependent/api/v1/holds.t line 908. # Structures begin differing at: # $got->[5] = Does not exist # $expected->[5] = HASH(0x5ed8c2627ed8) ok 13 - Patron passed correctly ok 14 - GET //tomasito:thePassword123@/api/v1/holds/157/pickup_locations?_order_by=marc_org_code&_page=2 not ok 15 - exact match for JSON Pointer "" # Failed test 'exact match for JSON Pointer ""' # at /kohadevbox/koha/t/db_dependent/api/v1/holds.t line 912. # Structures begin differing at: # $got->[0]{address3} = 'gftd3B_' # $expected->[0]{address3} = 'YtBCoGC' # Looks like you failed 2 tests of 15. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174106&action=edit Bug 34068: Mock RESTdefaultPageSize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171970|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 176110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176110&action=edit Bug 34068: Fix pagination for hold pickup locations This patch addresses an issue where pagination filters are set incorrectly for the pickup locations endpoint. Only the final page is returned rather than the expected full list of results Test plan: 1) In KTD, set the syspref RESTdefaultPageSize to 5 2) Set AllowHoldPolicyOverride to Allow 3) Create a hold on an item for a patron 4) Navigate to the patron's page and click on the holds tab 5) Click the dropdown in pickup locations 6) There will be two results, repeated three times 7) Apply patch and restart_all 8) Repeat step 5, there should now be a full list of 12 libraries Co-authored-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174072|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 176112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176112&action=edit Bug 34068: Fix tests Several wrong things in the previous attempt: * as_list returns an array * as_list returns objects, ->{library_id} does not exist * as_list does not returns api object, you need to call ->branchcode to get the id * $pickup_locations defined for both situations was confusing Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Severity|enhancement |normal --- Comment #17 from David Nind <david@davidnind.com> --- I've changed this to a normal bug, instead of an enhancement. I'm not sure who the assignee should be 8-), so haven't updated that. The tests pass: prove t/db_dependent/api/v1/holds.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176110|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176331&action=edit Bug 34068: Fix pagination for hold pickup locations This patch addresses an issue where pagination filters are set incorrectly for the pickup locations endpoint. Only the final page is returned rather than the expected full list of results Test plan: 1) In KTD, set the syspref RESTdefaultPageSize to 5 2) Set AllowHoldPolicyOverride to Allow 3) Create a hold on an item for a patron 4) Navigate to the patron's page and click on the holds tab 5) Click the dropdown in pickup locations 6) There will be two results, repeated three times 7) Apply patch and restart_all 8) Repeat step 5, there should now be a full list of 12 libraries Co-authored-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176112|0 |1 is obsolete| | --- Comment #20 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176333&action=edit Bug 34068: Fix tests Several wrong things in the previous attempt: * as_list returns an array * as_list returns objects, ->{library_id} does not exist * as_list does not returns api object, you need to call ->branchcode to get the id * $pickup_locations defined for both situations was confusing Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |holds function| | Patch complexity|--- |Trivial patch Assignee|matt.blenkinsop@ptfs-europe |jonathan.druart@gmail.com |.com | QA Contact|testopia@bugs.koha-communit |pedro.amorim@ptfs-europe.co |y.org |m --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Thanks for improving upon the initial patch, Joubu, and all the additional work here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #25 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.