[Bug 37927] New: Show report name on page title when viewing SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 Bug ID: 37927 Summary: Show report name on page title when viewing SQL Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org The name of the report doesn't show in the page title (the browser window or tab title) when viewing SQL, i.e. the URL is /cgi-bin/koha/reports/guided_reports.pl?reports=162&phase=Show SQL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Aleisha Amohia from comment #0)
The name of the report doesn't show in the page title (the browser window or tab title) when viewing SQL, i.e. the URL is /cgi-bin/koha/reports/guided_reports.pl?reports=162&phase=Show SQL
Aleisha, I think this URL may have changed since when you filed this? I could be wrong. Is this now /cgi-bin/koha/reports/guided_reports.pl?id=162&op=run ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yanjun.li@bywatersolutions. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi Luke, no this one is still valid. I'm referring to when we're viewing SQL, not when running a report. Foe example if you go to your saved reports, then click the Actions drop-up menu, then click View SQL. You're right that the URL has changed though, it is now this: /cgi-bin/koha/reports/guided_reports.pl?id=1&op=show It would be great to show the report name on the tab title here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 Leo Stoyanov <leo.stoyanov@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 --- Comment #3 from Leo Stoyanov <leo.stoyanov@bywatersolutions.com> --- Created attachment 176209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176209&action=edit Bug 37927: Fixed report name on page title not showing up when viewing SQL To test: 1. Create a SQL report. 2. Go to /cgi-bin/koha/reports/guided_reports.pl?id=1&op=show. 3. Inspect element the page, go to the head, and find the title; it should have no report name or id. 4. Apply patch. 5. Redo steps 1-3 to see the fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 Leo Stoyanov <leo.stoyanov@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main Assignee|koha-bugs@lists.koha-commun |leo.stoyanov@bywatersolutio |ity.org |ns.com Patch complexity|--- |Trivial patch CC| |leo.stoyanov@bywatersolutio | |ns.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176209|0 |1 is obsolete| | --- Comment #4 from Imani <imani.thomas@bywatersolutions.com> --- Created attachment 176210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176210&action=edit Bug 37927: Fixed report name on page title not showing up when viewing SQL To test: 1. Create a SQL report. 2. Go to /cgi-bin/koha/reports/guided_reports.pl?id=1&op=show. 3. Inspect element the page, go to the head, and find the title; it should have no report name or id. 4. Apply patch. 5. Redo steps 1-3 to see the fix. Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176210|0 |1 is obsolete| | --- Comment #5 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 176242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176242&action=edit Bug 37927: Fixed report name on page title not showing up when viewing SQL To test: 1. Create a SQL report. 2. Go to /cgi-bin/koha/reports/guided_reports.pl?id=1&op=show. 3. Inspect element the page, go to the head, and find the title; it should have no report name or id. 4. Apply patch. 5. Redo steps 1-3 to see the fix. Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Signed Off |Passed QA Severity|enhancement |normal --- Comment #6 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Nice work, thanks Leo! Passing QA and switching this from an enhancement to a bug, because it is really an accessibility bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the browser release notes| |window/tab page title when | |viewing the SQL for a | |report (Reports > Saved | |reports > Actions > View) - | |it now includes the report | |name and number. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37927 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #10 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org