https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25698 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #2 from Hugo Agud <hagud@orex.es> --- Great idea!!! suggestions: a) Some libraries has not continues attention, for example in lunch time has not desktop service? now you can set up opening and closing time, good idea add the change for adding closes period -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #3 from Michal Denar <black23@gmail.com> --- Great idea, bBut there are some bugs or suggestions for extensions that would be great to incorporate into the final functionality. Like https://github.com/bywatersolutions/koha-plugin-curbside-pickup/issues/27. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Lisette Scheer from comment #4) Thanks for your input Lisette, that's very useful.

As a current user, here are some of the issues listed on the GitHub that would be great to have fixed: -limit ability for patrons to schedule pickups to only patrons with waiting holds (optionally as some libraries may use the plugin for prints or other non-item pickups)

Will be done.

-Allow 2 (or more) pickup windows a day (maybe there is a lunch break etc)

Will be done (infinite number of pickup windows!)

-Linking the information about curbside to checkouts for statistics

Do you have an idea about how to implement that already?

-Allowing staff to add/edit note after reservation is made -Optionally allow scheduling only until X hours before an appointment (preferably each library should be able to set this along with hours etc) -Additionally allow to limit scheduling out further than x number of days (we'd like to let people schedule 1-2 weeks in advance max, but currently you could schedule out years)

Won't be done, at least not on this bug report.

-Pickups showing up on both "staged & ready" and "delivered" tabs when marked as delivered from "staged & ready"

I don't recreate this problem.

-Option to remove "patron has arrived" button by library (preferably each library should be able to set this along with hours etc)

Shouldn't be too hard to implement, but won't be done in the first iteration.

-Holidays on Calendar can still have appointments scheduled

Not done yet, but I should definitely implement that here. It would be helpful if you could open follow-up bug reports linked to this one. If I have some time left when this first set is integrated, I will work on the follow-up bug reports which got the more votes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Current state of the development can be found at https://gitlab.com/joubu/Koha/-/commits/bug_30650 It can already be tested if you want to provide feedback. What has been done in this patch set: - Deal with installations using the existing plugin (upgrade the DB schema and migrate their data) - Add a new syspref (CurbsidePickup) and a new permission (manage_curbside_pickups) - Add an administration page to setup the configuration: admin/curbside_pickup.pl - Add a circulation page to manage the existing pickups, and create new one - Add a new OPAC view "your curbside pickups" to let patron manage their pickups, and create new ones - Add link from the "member" toolbar Improvements compared to the plugin: - Ability to create several pickup windows per day - Better display of the pickup times (not in a dropdown list) - Ability to disable pickups for patrons without waiting holds - Display pickups on the patron circulation page - Display pickups of the library on the homepage - Prevent pickup to be created on a holiday - Better error handling (exceptions) - Unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- All credit goes to the authors of the existing Curbside Pickup plugin, thanks to them, and to Kyle especially! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964 [Bug 30964] Add information about overdues and restrictions on the curbside pickup list -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30964 | Blocks| |30964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964 [Bug 30964] Add information about overdues and restrictions on the curbside pickup list -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136585&action=edit Bug 30650: Koha classes Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136587&action=edit Bug 30650: Add new permission manage_curbside_pickups Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136589&action=edit Bug 30650: Admin page This patch adds a new page in the administration area to manage curbside pickups. Test plan: 1. Enable the new CurbsidePickup syspref 2. Go to Administration > Curbside pickups => If the logged-in user has the manage_curbside_pickups permission you should see the administration view 3. Enable the feature for some libraries and configure it. a. You must define a "pickup interval" and a "maximum patrons per interval" values. b. If "Patron-scheduled pickup" is enabled, patrons will be able to schedule curbside pickups from the OPAC c. If "Enable for waiting holds only" is enabled, only patron with waiting holds will be allowed to schedule curbside pickups d. In the bottom part of the form you can define the slots available for curbside pickups. e. Save Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136591&action=edit Bug 30650: Be more flexible with opening slots Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136593&action=edit Bug 30650: Add circulation page view This is the main commit message. A plugin already exists to manage curbside pickups. This new enhancehemnt is suggesting an implementation that is ready to be integrated into Koha core in order to provide the feature out-of-the-box. What has been done in this patch set: - Deal with installations using the existing plugin (upgrade the DB schema and migrate their data) - Add a new syspref (CurbsidePickup) and two new permissions: * parameters.manage_curbside_pickups * circulate.manage_curbside_pickups - Add an administration page to setup the configuration: admin/curbside_pickup.pl - Add a circulation page to manage the existing pickups, and create new one - Add a new OPAC view "your curbside pickups" to let patron manage their pickups, and create new ones - Add link from the "member" toolbar Improvements compared to the plugin: - Ability to create several pickup windows per day - Better display of the pickup times (not in a dropdown list) - Ability to disable pickups for patrons without waiting holds - Display pickups on the patron circulation page - Display pickups of the library on the homepage - Prevent pickup to be created on a holiday - Better error handling (exceptions) - Unit tests More improvements are already planned, see related bug reports. Test plan: After you setup the feature correctly from the administration view, you will be able to use the schedule curbside pickups from the staff interface, and from the OPAC interface if you selected "patron-scheduled pickup" A. Staff interface 1. Go to Circulation > Curbside pickups => If the logged-in user has the circulate.manage_curbside_pickups permission you will be able to create and manage curbside pickups 2. Go to a patron detail page and click the "Schedule pickup" button in the toolbar 3. If the patron has waiting holds and you selected "Enable for waiting holds only", of if you didn't select the option, you will be able to select a pickup date and slots to create a pickup. 4. Confirm that you cannot create more pickups per slot than what you defined in the curbside pickup configuration for this library 5. Confirm that you cannot create a pickup if the feature is disabled for the library 6. Notice that you can mark the pickup as "stage and ready", then "patron is outside" and finally "delivered today". You can also rollback the change 7. Notice that once the pickup has been marked as delivered, the item has been checked out and that a new notice has been generated (if the patron has "Hold_Filled" in their messaging preferences 8. Confirm that the information about current pickups is displayed on the circulation page of the patron B. OPAC interface 1. Create a new curbside pickup from the OPAC 2. Confirm that the same limitations as from the staff interface are in effect (waiting holds, number of patron per slots, etc.) 3. Confirm that you can cancel a pickup and alert staff of you arrival 4. Confirm that you cannot cancel a pickup that has been delivered already Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136595&action=edit Bug 30650: Add dayjs to opac Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136597&action=edit Bug 30650: Add link from the member toolbar Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136599&action=edit Bug 30650: DB - Add policy.enable_waiting_holds_only Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136601&action=edit Bug 30650: Add link from the mainpage Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136603&action=edit Bug 30650: Add filter_by_scheduled_today A bit of cleaning Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136605&action=edit Bug 30650: Split the permission We actually want one permission to manage the administration page, and one for the circulation module. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136607&action=edit Bug 30650: Prevent browser crash if no pickup interval set Don't get stuck in an infinite loop -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136609&action=edit Bug 30650: DBIC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is ready for testing, see test plans in patches "Bug 30650: Admin page" and "Bug 30650: Add circulation page view" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137095&action=edit Bug 30650: Display holds waiting at the logged-in library Not those waiting at the library of the logged-in user -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30570 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570 [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137211&action=edit Bug 30650: Add dayjs customParseFormat plugin -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr Status|Needs Signoff |Signed Off --- Comment #42 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hi, I've tested on a sandbox and everything is as excepted. - the two circulation permissions are OK - Curbside pickup is possible only for branches where it has been defined - If you choose to "Enable for waiting holds only", you can't choose a slot for a pickup if the patron doesn't have available hold. But it's possible if you don't check this in the setting - If you choose "Enable patrons to schedule their own curbside" on some branches, they are displayed in the OPAC in the user account. If the patron didn't have any available holds and that it is asked for one branches, this one is displayed and disabled. If no branch is set for enable patrons to schedule pickup, the tab doesn't appear in the user account - The slot for the days, the hours and the intevals are well displayed - The checking of the number of patrons alowed for the same slot is ok - the change of status are ok and you can rollback is wanted - the item is correctly checked out when it is marked as delivered - A notice is send to the patron is he has a primary mail defined and if the choice "email" is checked for hold filled in the Patron messaging preferences - the curbisde pickup are displayed on the checjout page for the patron - If a patron click on "Alert staff of your arrival", the curbside pickup switch on the "patron is arrived" tab in the intranet after 1 or 2 mn Thanks joubu :) Sonia -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137278&action=edit Bug 30650: Koha classes Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137280&action=edit Bug 30650: Add new permission manage_curbside_pickups Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #48 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137282&action=edit Bug 30650: Admin page This patch adds a new page in the administration area to manage curbside pickups. Test plan: 1. Enable the new CurbsidePickup syspref 2. Go to Administration > Curbside pickups => If the logged-in user has the manage_curbside_pickups permission you should see the administration view 3. Enable the feature for some libraries and configure it. a. You must define a "pickup interval" and a "maximum patrons per interval" values. b. If "Patron-scheduled pickup" is enabled, patrons will be able to schedule curbside pickups from the OPAC c. If "Enable for waiting holds only" is enabled, only patron with waiting holds will be allowed to schedule curbside pickups d. In the bottom part of the form you can define the slots available for curbside pickups. e. Save Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #50 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137284&action=edit Bug 30650: Be more flexible with opening slots Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #52 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137286&action=edit Bug 30650: Add circulation page view This is the main commit message. A plugin already exists to manage curbside pickups. This new enhancehemnt is suggesting an implementation that is ready to be integrated into Koha core in order to provide the feature out-of-the-box. What has been done in this patch set: - Deal with installations using the existing plugin (upgrade the DB schema and migrate their data) - Add a new syspref (CurbsidePickup) and two new permissions: * parameters.manage_curbside_pickups * circulate.manage_curbside_pickups - Add an administration page to setup the configuration: admin/curbside_pickup.pl - Add a circulation page to manage the existing pickups, and create new one - Add a new OPAC view "your curbside pickups" to let patron manage their pickups, and create new ones - Add link from the "member" toolbar Improvements compared to the plugin: - Ability to create several pickup windows per day - Better display of the pickup times (not in a dropdown list) - Ability to disable pickups for patrons without waiting holds - Display pickups on the patron circulation page - Display pickups of the library on the homepage - Prevent pickup to be created on a holiday - Better error handling (exceptions) - Unit tests More improvements are already planned, see related bug reports. Test plan: After you setup the feature correctly from the administration view, you will be able to use the schedule curbside pickups from the staff interface, and from the OPAC interface if you selected "patron-scheduled pickup" A. Staff interface 1. Go to Circulation > Curbside pickups => If the logged-in user has the circulate.manage_curbside_pickups permission you will be able to create and manage curbside pickups 2. Go to a patron detail page and click the "Schedule pickup" button in the toolbar 3. If the patron has waiting holds and you selected "Enable for waiting holds only", of if you didn't select the option, you will be able to select a pickup date and slots to create a pickup. 4. Confirm that you cannot create more pickups per slot than what you defined in the curbside pickup configuration for this library 5. Confirm that you cannot create a pickup if the feature is disabled for the library 6. Notice that you can mark the pickup as "stage and ready", then "patron is outside" and finally "delivered today". You can also rollback the change 7. Notice that once the pickup has been marked as delivered, the item has been checked out and that a new notice has been generated (if the patron has "Hold_Filled" in their messaging preferences 8. Confirm that the information about current pickups is displayed on the circulation page of the patron B. OPAC interface 1. Create a new curbside pickup from the OPAC 2. Confirm that the same limitations as from the staff interface are in effect (waiting holds, number of patron per slots, etc.) 3. Confirm that you can cancel a pickup and alert staff of you arrival 4. Confirm that you cannot cancel a pickup that has been delivered already Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137288&action=edit Bug 30650: Add dayjs to opac Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #56 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137290&action=edit Bug 30650: Add link from the member toolbar Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #58 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137292&action=edit Bug 30650: DB - Add policy.enable_waiting_holds_only Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #60 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137294&action=edit Bug 30650: Add link from the mainpage Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #62 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137296&action=edit Bug 30650: Add filter_by_scheduled_today A bit of cleaning Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #64 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137298&action=edit Bug 30650: Split the permission We actually want one permission to manage the administration page, and one for the circulation module. Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #66 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137300&action=edit Bug 30650: Prevent browser crash if no pickup interval set Don't get stuck in an infinite loop Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #68 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137302&action=edit Bug 30650: DBIC Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #70 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137304&action=edit Bug 30650: Display holds waiting at the logged-in library Not those waiting at the library of the logged-in user Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #72 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137306&action=edit Bug 30650: Add dayjs customParseFormat plugin Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #74 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138261&action=edit Bug 30650: Display the link in the admin even if the pref is off The link in the sidebar was displayed already. The idea is to let admins configure the module before enabling it for users. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #76 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138263&action=edit Bug 30650: Koha classes Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #78 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138265&action=edit Bug 30650: Add new permission manage_curbside_pickups Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #80 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138267&action=edit Bug 30650: Admin page This patch adds a new page in the administration area to manage curbside pickups. Test plan: 1. Enable the new CurbsidePickup syspref 2. Go to Administration > Curbside pickups => If the logged-in user has the manage_curbside_pickups permission you should see the administration view 3. Enable the feature for some libraries and configure it. a. You must define a "pickup interval" and a "maximum patrons per interval" values. b. If "Patron-scheduled pickup" is enabled, patrons will be able to schedule curbside pickups from the OPAC c. If "Enable for waiting holds only" is enabled, only patron with waiting holds will be allowed to schedule curbside pickups d. In the bottom part of the form you can define the slots available for curbside pickups. e. Save Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #82 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138269&action=edit Bug 30650: Be more flexible with opening slots Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #84 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138271&action=edit Bug 30650: Add circulation page view This is the main commit message. A plugin already exists to manage curbside pickups. This new enhancehemnt is suggesting an implementation that is ready to be integrated into Koha core in order to provide the feature out-of-the-box. What has been done in this patch set: - Deal with installations using the existing plugin (upgrade the DB schema and migrate their data) - Add a new syspref (CurbsidePickup) and two new permissions: * parameters.manage_curbside_pickups * circulate.manage_curbside_pickups - Add an administration page to setup the configuration: admin/curbside_pickup.pl - Add a circulation page to manage the existing pickups, and create new one - Add a new OPAC view "your curbside pickups" to let patron manage their pickups, and create new ones - Add link from the "member" toolbar Improvements compared to the plugin: - Ability to create several pickup windows per day - Better display of the pickup times (not in a dropdown list) - Ability to disable pickups for patrons without waiting holds - Display pickups on the patron circulation page - Display pickups of the library on the homepage - Prevent pickup to be created on a holiday - Better error handling (exceptions) - Unit tests More improvements are already planned, see related bug reports. Test plan: After you setup the feature correctly from the administration view, you will be able to use the schedule curbside pickups from the staff interface, and from the OPAC interface if you selected "patron-scheduled pickup" A. Staff interface 1. Go to Circulation > Curbside pickups => If the logged-in user has the circulate.manage_curbside_pickups permission you will be able to create and manage curbside pickups 2. Go to a patron detail page and click the "Schedule pickup" button in the toolbar 3. If the patron has waiting holds and you selected "Enable for waiting holds only", of if you didn't select the option, you will be able to select a pickup date and slots to create a pickup. 4. Confirm that you cannot create more pickups per slot than what you defined in the curbside pickup configuration for this library 5. Confirm that you cannot create a pickup if the feature is disabled for the library 6. Notice that you can mark the pickup as "stage and ready", then "patron is outside" and finally "delivered today". You can also rollback the change 7. Notice that once the pickup has been marked as delivered, the item has been checked out and that a new notice has been generated (if the patron has "Hold_Filled" in their messaging preferences 8. Confirm that the information about current pickups is displayed on the circulation page of the patron B. OPAC interface 1. Create a new curbside pickup from the OPAC 2. Confirm that the same limitations as from the staff interface are in effect (waiting holds, number of patron per slots, etc.) 3. Confirm that you can cancel a pickup and alert staff of you arrival 4. Confirm that you cannot cancel a pickup that has been delivered already Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #86 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138273&action=edit Bug 30650: Add dayjs to opac Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #88 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138275&action=edit Bug 30650: Add link from the member toolbar Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #90 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138277&action=edit Bug 30650: DB - Add policy.enable_waiting_holds_only Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #92 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138279&action=edit Bug 30650: Add link from the mainpage Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #94 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138281&action=edit Bug 30650: Add filter_by_scheduled_today A bit of cleaning Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #96 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138283&action=edit Bug 30650: Split the permission We actually want one permission to manage the administration page, and one for the circulation module. Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #98 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138285&action=edit Bug 30650: Prevent browser crash if no pickup interval set Don't get stuck in an infinite loop Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #100 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138287&action=edit Bug 30650: DBIC specific Note for QA - a false positive is raised by the QA tools: """ The new column curbside_pickup_opening_slots.day is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/CurbsidePickupOpeningSlot.pm) """ => It's not a boolean! Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #102 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138289&action=edit Bug 30650: Don't display slots that have are before now Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #104 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138291&action=edit Bug 30650: Take dateformat into account dayjs init was not passing the dateformat. We really need to clean the date handling with the following two bugs: Bug 30310 - Replace Moment.js with Day.js and Bug 30718 - Use flatpickr's altInput option everywhere But it's outside the scope of this bug report. Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #106 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There was a typo 'Cubside' in the exception name, and on the UI. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #108 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

From testing in the GUI:

3) Curbside pickup configuration The trashcan icon behind the times is missing a space before it. It also doesn't have an alt text/tool tip when hovering. 4) Circulation start page a) With CircSidebar enabled, the curbside pickup entry is missing from the sidebar. b) Also the curbside configuration page doesn't show the sidebar. c) Capitalization: Curbside Pickup = Curbside pickup 5) Schedule pickup a) When scheduling a pickup the calendar widget shows future days greyed out and allows to select dates in the past. (blocker) b) The button remains greyed out until you pick a date with pickup times available. I think a tool tip would be very helpful here. (not blocker) 5) New notice NEW_CURBSIDE_PICKUP a) Tiny typo: You have schedule a curbside pickup for [% branch.branchname %] => ... scheduled (normal) b) Can we break the content text into 3 entries in the .yml file for new installations (one per sentence) to ease translation a bit? (normal) 6) Koha start page a) The start page for new pickups reads: New curbside pickups 1. We should add a : here: New curbside pickups: 1 This makes it also more consistent with the other entries (looked at suggestions and patron modifications). (trivial) 7) OPAC view As this is the patron side of things, I worry more about that than about other stuff. I have some issues here: a) The alert link will only be functional, when the pickup has been "staged & ready". But there is no clue in the GUI about this and the patron might be in front of the library without being able to see what's going on. b) Once the pickup has been "marked as delivered" it still remains in the list with no clue that it has been picked up already. It would be nicer to display, that it's already been delivered. Note: only today's and future pickups will show in the list. Maybe this could be a separate bug as well to get some feedback, but it feels like we should give the patrons more information there. X) Possible enhancements These are supposed to go into new wish list bugs. But maybe you could look through them quickly to check if I have missed/misunderstood something? a) Curbside pickup configuration page: The weekday pull down and display should follow the CalendarFirstDayofWeek system preference. b) Show a note on top of the Curbside pickup configuration page, if the Curbside pickup module is not enabled (similar to what we do for the Transport cost matrix administration page) c) Improve GUI for pickup up pickup times in staff interface: The times are a little hard to select/hard to read. I think it would be nice to make this look more like in the OPAC. d) Scheduling a pickup from the curbside pickups page only will only work with the cardnumber. It would be nicer to use the standard patron search for this. e) Add logging for curbside pickup location actions f) Have different permission descriptions (might require to change the permission code) to make it clearer what the difference between each of the permissions is. h) Make curbside pickup confirmation its own messaging preference or adapt messaging preference description to include curbside pickups when the pref is enabled. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 [Bug 31262] Curbside pickups - disable dates without slots -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31264 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264 [Bug 31264] CalendarFirstDayOfWeek not taken into account when configuring curbside pickups -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31266 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31266 [Bug 31266] Curbside pickups - New messaging preference -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #110 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138320&action=edit Bug 30650: Add dayjs license to the about page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #112 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138322&action=edit Bug 30650: Add link to the circ nav bar -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #114 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138324&action=edit Bug 30650: Split yml on several lines to help translation -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #116 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #107) Thanks a lot, Katrin, for you great QA session :)

o) Tests are failing, but possibly just a typo/later change causing it:

# Failed test 'Notice correctly generated' # at t/db_dependent/Koha/CurbsidePickups.t line 299. # got: 'You have schedule a curbside pickup for Te9oDc' # expected: 'You have schedule a curbside pickup for Te9oDc.' # Looks like you failed 1 test of 2.

Other finds from code review:

1) Tiny typos

* Curbside pickups are not enabled for your location. = library * Pickup Date/Time = capitalization * ... it is an holiday = it is a holiday. (multiple) * Deliver Date/Time = capitalization * There is no waiting holds for this patron at this location. = There are no... at this library * No pickup time define for this day. = defined (multiple) * You don't have waiting holds at this location = library

Done in patch "Fix some typos"

2) New JS libraries

There are no license statements for these, as we only add the minified version:

dayjs.min.js isSameOrAfter.js customParseFormat.js

Should they be listed on the about page?

Yes, done in "Add dayjs license to the about page" (In reply to Katrin Fischer from comment #108)

From testing in the GUI:

3) Curbside pickup configuration

The trashcan icon behind the times is missing a space before it. It also doesn't have an alt text/tool tip when hovering.

Done in "Add info to the trash icon"

4) Circulation start page

a) With CircSidebar enabled, the curbside pickup entry is missing from the sidebar.

Done in "Add link to the circ nav bar"

b) Also the curbside configuration page doesn't show the sidebar.

"Add the sidebar to the circ view"

c) Capitalization: Curbside Pickup = Curbside pickup

Done in "Fix some typos"

5) Schedule pickup

a) When scheduling a pickup the calendar widget shows future days greyed out and allows to select dates in the past. (blocker)

I don't recreate that. All dates can be selected using the widget, but dates in the past won't display slots. This is the correct behaviour. We could improve and "disable" dates in the past or even dates without slots, but that's for another bug report. Opened bug 31261 and bug 31262.

b) The button remains greyed out until you pick a date with pickup times available. I think a tool tip would be very helpful here. (not blocker)

I think I understand what you mean: you have to remove the focus from the widget to be able to select a slot. I've tried to fix it already but didn't manage to find a correct solution.

5) New notice NEW_CURBSIDE_PICKUP

a) Tiny typo: You have schedule a curbside pickup for [% branch.branchname %] => ... scheduled (normal)

Fixed earlier.

b) Can we break the content text into 3 entries in the .yml file for new installations (one per sentence) to ease translation a bit? (normal)

"Split yml on several lines to help translation"

6) Koha start page

a) The start page for new pickups reads: New curbside pickups 1. We should add a : here: New curbside pickups: 1 This makes it also more consistent with the other entries (looked at suggestions and patron modifications). (trivial)

"Fix some typos"

7) OPAC view

As this is the patron side of things, I worry more about that than about other stuff. I have some issues here:

a) The alert link will only be functional, when the pickup has been "staged & ready". But there is no clue in the GUI about this and the patron might be in front of the library without being able to see what's going on.

I would like this to be discussed on a separate bug report, it was the previous (plugin) behaviour. See bug 31263.

b) Once the pickup has been "marked as delivered" it still remains in the list with no clue that it has been picked up already. It would be nicer to display, that it's already been delivered. Note: only today's and future pickups will show in the list.

Maybe this could be a separate bug as well to get some feedback, but it feels like we should give the patrons more information there.

What do you suggest? Do you want a separate column to display the status?

X) Possible enhancements

These are supposed to go into new wish list bugs. But maybe you could look through them quickly to check if I have missed/misunderstood something?

a) Curbside pickup configuration page: The weekday pull down and display should follow the CalendarFirstDayofWeek system preference.

Why do we accept all the day of the week in this syspref?! It should, indeed, but not trivial. Opening a separate bug and not sure it will be fixed. That seems a lot of work for not much to gain. Maybe first keeping only Monday, Saturday and Sunday... ...ha ... bug 12137 comment 16... Opened bug 31264!

b) Show a note on top of the Curbside pickup configuration page, if the Curbside pickup module is not enabled (similar to what we do for the Transport cost matrix administration page)

Done in "Add message on the admin page if the pref is off"

c) Improve GUI for pickup up pickup times in staff interface: The times are a little hard to select/hard to read. I think it would be nice to make this look more like in the OPAC.

Opened a separate bug, I would like to ask Owen his opinion what's best here. We could improve both I think. The plugin was displaying the list in a dropdown list, so it's already a nice improvement how it is now ;) Opened bug 31265 for discussion.

d) Scheduling a pickup from the curbside pickups page only will only work with the cardnumber. It would be nicer to use the standard patron search for this.

Bug 30965 is waiting for you PQA stamp :)

e) Add logging for curbside pickup location actions

Can you open a bug report with the detail of what you have in mind exactly?

f) Have different permission descriptions (might require to change the permission code) to make it clearer what the difference between each of the permissions is.

Is that blocker? :D If not done here it won't be done. On the other hand I don't see how it could be a problem (the module code is different).

h) Make curbside pickup confirmation its own messaging preference or adapt messaging preference description to include curbside pickups when the pref is enabled.

Yes, that is definitely something we should do. I've copied the plugin's behaviour but it's not obvious. Opened bug 31266. We will need to prioritize what we want first :) I will pick the related bugs with the highest number of votes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #118 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

...

0) Tests are failing, but possibly just a typo/later change causing it:

Tests pass now.

...

1) Tiny typos

Fixed another "location" to library in a follow-up.

...

2) New JS libraries Yes, done in "Add dayjs license to the about page"

Ok!

...

3) Curbside pickup configuration

The trashcan icon behind the times is missing a space before it. It also doesn't have an alt text/tool tip when hovering.

Done in "Add info to the trash icon"

Much better, thanks!

...

4) Circulation start page

a) With CircSidebar enabled, the curbside pickup entry is missing from the sidebar. Done in "Add link to the circ nav bar"

OK!

...

b) Also the curbside configuration page doesn't show the sidebar.

"Add the sidebar to the circ view"

OK!

...

c) Capitalization: Curbside Pickup = Curbside pickup

OK!

...

5) Schedule pickup

a) When scheduling a pickup the calendar widget shows future days greyed out and allows to select dates in the past. (blocker)

I don't recreate that. All dates can be selected using the widget, but dates in the past won't display slots. This is the correct behaviour. We could improve and "disable" dates in the past or even dates without slots, but that's for another bug report.

Opened bug 31261 and bug 31262.

Talked about it on IRC and agreeing with the approach.

...

b) The button remains greyed out until you pick a date with pickup times available. I think a tool tip would be very helpful here. (not blocker)

I think I understand what you mean: you have to remove the focus from the widget to be able to select a slot. I've tried to fix it already but didn't manage to find a correct solution.

Not blocker for me.

...

5) New notice NEW_CURBSIDE_PICKUP

a) Tiny typo: You have schedule a curbside pickup for [% branch.branchname %] => ... scheduled (normal)

Fixed earlier.

OK! Fixed another small glitch: letter.name is set in .yml but not in the update. See follow-up.

...

b) Can we break the content text into 3 entries in the .yml file for new installations (one per sentence) to ease translation a bit? (normal)

"Split yml on several lines to help translation"

OK, thanks!

...

6) Koha start page

a) The start page for new pickups reads: New curbside pickups 1. We should add a : here:

OK!

...

7) OPAC view

As this is the patron side of things, I worry more about that than about other stuff. I have some issues here:

a) The alert link will only be functional, when the pickup has been "staged & ready". But there is no clue in the GUI about this and the patron might be in front of the library without being able to see what's going on.

I would like this to be discussed on a separate bug report, it was the previous (plugin) behaviour. See bug 31263.

Suggested the same a bit further below, fine by me!

...

b) Once the pickup has been "marked as delivered" it still remains in the list with no clue that it has been picked up already. It would be nicer to display, that it's already been delivered. Note: only today's and future pickups will show in the list.

Maybe this could be a separate bug as well to get some feedback, but it feels like we should give the patrons more information there.

What do you suggest? Do you want a separate column to display the status?

I think a status column would be nice, but happy to move to a separate bug.

...

X) Possible enhancements

These are supposed to go into new wish list bugs. But maybe you could look through them quickly to check if I have missed/misunderstood something?

a) Curbside pickup configuration page: The weekday pull down and display should follow the CalendarFirstDayofWeek system preference.

Why do we accept all the day of the week in this syspref?! It should, indeed, but not trivial. Opening a separate bug and not sure it will be fixed. That seems a lot of work for not much to gain. Maybe first keeping only Monday, Saturday and Sunday...

...ha ... bug 12137 comment 16...

Opened bug 31264!

Thx for opening the bugs already :) I agree with your past comment, just wishing we could have Monday first to match with the calendars.

...

b) Show a note on top of the Curbside pickup configuration page, if the Curbside pickup module is not enabled (similar to what we do for the Transport cost matrix administration page)

Done in "Add message on the admin page if the pref is off"

OK! Already off the wish list then :)

...

c) Improve GUI for pickup up pickup times in staff interface: The times are a little hard to select/hard to read. I think it would be nice to make this look more like in the OPAC.

Opened a separate bug, I would like to ask Owen his opinion what's best here. We could improve both I think. The plugin was displaying the list in a dropdown list, so it's already a nice improvement how it is now ;) Opened bug 31265 for discussion.

Thx for the bug!

...

d) Scheduling a pickup from the curbside pickups page only will only work with the cardnumber. It would be nicer to use the standard patron search for this.

Bug 30965 is waiting for you PQA stamp :)

I'll look at the other related bugs, once we are done here. Would be nice if it was already pushed as this makes testing a little easier.

...

e) Add logging for curbside pickup location actions

Can you open a bug report with the detail of what you have in mind exactly?

I'll think about it a bit more. Maybe it's not an issue, but it seemed like a little missing piece.

...

f) Have different permission descriptions (might require to change the permission code) to make it clearer what the difference between each of the permissions is.

Is that blocker? :D If not done here it won't be done. On the other hand I don't see how it could be a problem (the module code is different).

Maybe a non-issue, we can wait and see with this one.

...

h) Make curbside pickup confirmation its own messaging preference or adapt messaging preference description to include curbside pickups when the pref is enabled.

Yes, that is definitely something we should do. I've copied the plugin's behaviour but it's not obvious. Opened bug 31266.

Thx!

I will pick the related bugs with the highest number of votes.

Go and vote people! :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138262|0 |1 is obsolete| | --- Comment #119 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138330&action=edit Bug 30650: DB changes Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138264|0 |1 is obsolete| | --- Comment #121 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138332&action=edit Bug 30650: Add the CurbsidePickup syspref Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138266|0 |1 is obsolete| | --- Comment #123 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138334&action=edit Bug 30650: Add link from the admin home page Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138268|0 |1 is obsolete| | --- Comment #125 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138336&action=edit Bug 30650: Adjust atomic update Take into account existing installs using the plugins Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138270|0 |1 is obsolete| | --- Comment #127 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138338&action=edit Bug 30650: Add some useful modules and tests Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138272|0 |1 is obsolete| | --- Comment #129 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138340&action=edit Bug 30650: Add dayjs and isSameOfAfter plugin Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138274|0 |1 is obsolete| | --- Comment #131 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138342&action=edit Bug 30650: OPAC view Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138276|0 |1 is obsolete| | --- Comment #133 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138344&action=edit Bug 30650: Notify the patron when a new curbside pickup is created Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138278|0 |1 is obsolete| | --- Comment #135 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138346&action=edit Bug 30650: Allow to restrict curbside pickup for waiting holds only Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138280|0 |1 is obsolete| | --- Comment #137 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138348&action=edit Bug 30650: Add link from the circ patron page Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138282|0 |1 is obsolete| | --- Comment #139 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138350&action=edit Bug 30650: Prevent pickup to be created on holiday We could improve this more and add disable the holiday from the date picker widget, but it's out of the scope here. Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138284|0 |1 is obsolete| | --- Comment #141 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138352&action=edit Bug 30650: Select 'schedule a pickup' if no pickups yet Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138286|0 |1 is obsolete| | --- Comment #143 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138354&action=edit Bug 30650: DBIC Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138288|0 |1 is obsolete| | --- Comment #145 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138356&action=edit Bug 30650: Display holds waiting at the logged-in library Not those waiting at the library of the logged-in user Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138290|0 |1 is obsolete| | --- Comment #147 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138358&action=edit Bug 30650: Add dayjs customParseFormat plugin Signed-off-by: Koha Team University Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138292|0 |1 is obsolete| | --- Comment #149 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138360&action=edit Bug 30650: Display the link in the admin even if the pref is off The link in the sidebar was displayed already. The idea is to let admins configure the module before enabling it for users. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138320|0 |1 is obsolete| | --- Comment #151 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138362&action=edit Bug 30650: Add dayjs license to the about page Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138322|0 |1 is obsolete| | --- Comment #153 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138364&action=edit Bug 30650: Add link to the circ nav bar Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138324|0 |1 is obsolete| | --- Comment #155 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138366&action=edit Bug 30650: Split yml on several lines to help translation Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #157 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138368&action=edit Bug 30650: Add missing name to notice added by database update The notice was missing the name, which gives you an error when you try to save changes in Koha. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 --- Comment #159 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 138375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138375&action=edit Bug 30650: (QA follow-up) Some higher-level methods usage Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a Curbside Pickup |Add a curbside pickup |module |module --- Comment #162 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like we have a failing test now? not ok 264 - Module Koha::CurbsidePickupPolicys should be defined -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | Status|Pushed to master |Needs documenting --- Comment #165 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32111 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 [Bug 32111] Cannot schedule a pickup at the OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32785 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/617 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 [Bug 32891] Curbside pickups - Cannot select slot in the last hour -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34373 [Bug 34373] Improve layout of curbside pickups items ready list -- You are receiving this mail because: You are watching all bug changes.