[Bug 19304] New: Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Bug ID: 19304 Summary: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19303 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 [Bug 19303] Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67126&action=edit Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address This subroutine is quite trivial and can be replaced easily with a new method of Koha::Patron Test plan: Overdue notices and shelf sharing must be send the to an email address, according to the value of the pref AutoEmailPrimaryAddress -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david.bourgault@inlibro.com --- Comment #2 from David Bourgault <david.bourgault@inlibro.com> --- I can't apply the patch fatal: sha1 information is lacking or useless (C4/Members.pm). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Apply correctly for me, you need to apply the patches from bug 19303 first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67126|0 |1 is obsolete| | --- Comment #4 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 68111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68111&action=edit Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address This subroutine is quite trivial and can be replaced easily with a new method of Koha::Patron Test plan: Overdue notices and shelf sharing must be send the to an email address, according to the value of the pref AutoEmailPrimaryAddress Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68111|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70222&action=edit Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address This subroutine is quite trivial and can be replaced easily with a new method of Koha::Patron Test plan: Overdue notices and shelf sharing must be send the to an email address, according to the value of the pref AutoEmailPrimaryAddress Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70223&action=edit Bug 19304: (QA follow-up) Fix number of tests in Members.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Bug 19304 depends on bug 19303, which changed state. Bug 19303 Summary: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick@bywatersolutions.com Resolution|--- |FIXED --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org