https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #1 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 114168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114168&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he starting search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! We need do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). If need do 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good <index_name> for <elasticsearch> 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 4. For add information in the index we need run script for indexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find "AutocompleteElasticSearch". Value must be "Show". 7. Now we have Autocomplete for all search input (advanced search also) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ivan.dziuba@inlibro.com --- Comment #2 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 114169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114169&action=edit Result -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- In koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc + var OL_PREVIEW = _("Preview"); Why this ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #7 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Yes, I see many errors in the files. I will change it. I would like to provide the service for both opac and intranet through REST API. But, I see many preferences for REST API: ('RESTBasicAuth'- 'If enabled, Basic authentication is enabled for the REST API.','YesNo'), ('RESTdefaultPageSize' - 'Default page size for endpoints listing objects','Integer'), ('RESTOAuth2ClientCredentials' - 'If enabled, the OAuth2 client credentials flow is enabled for the REST API.','YesNo'), ('RESTPublicAnonymousRequests' -'If enabled, the API will allow anonymous access to public routes that don\'t require authenticated access.','YesNo'), ('RESTPublicAPI' - 'If enabled, the REST API will expose the /public endpoints.','YesNo') I am not sure that good idea for OPAC because REST API uses Auth. It is possible to disable authentication in the preferences for REST API, but this may have a consequences... Do you have a solution about this? Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #9 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Are you sure that OPAC search uses REST API? It's only GET request (with parametres 'q', 'idx', ...) for file opac-search.pl and return a results for template *-results.tt. I don't see here REST API. Best regards, -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Ivan Dziuba from comment #9)

Are you sure that OPAC search uses REST API? It's only GET request (with parametres 'q', 'idx', ...) for file opac-search.pl and return a results for template *-results.tt. I don't see here REST API.

Best regards,

No indeed, search is not actually using API. I say your autocomplete feature should use a dedicated API service. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116293|0 |1 is obsolete| | --- Comment #13 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 119979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119979&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Bug 27113: ElasticSearch: Autocomplete in input search. Fix bugs. Bug 27113: ElasticSearch: Autocomplete in input search. Use Unicode::Normalize instead Text::Unaccent. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #15 from Blou <philippe.blouin@inlibro.com> --- Good idea on the button. But I asked Ivan to focus on feature at hand and everything else can be a new BZ. If he gets it through, it'll be easy to add on afterward. For the .css, you mean merging autocomplete.css into opac.css ? Couldn't that be a RM thing at the end, if really needed? Otherwise that makes the rebasing very painful. Ivan is certainly not at ease with that demand. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Blou from comment #15)

Good idea on the button. But I asked Ivan to focus on feature at hand and everything else can be a new BZ. If he gets it through, it'll be easy to add on afterward.

For the .css, you mean merging autocomplete.css into opac.css ? Couldn't that be a RM thing at the end, if really needed? Otherwise that makes the rebasing very painful. Ivan is certainly not at ease with that demand.

The RM will generate the scss files, you don't need to submit those. But they won't merge CSS changes into the css files. But the risk of conflict is not usually high there. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120028|0 |1 is obsolete| | --- Comment #19 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 120029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120029&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good <index_name> for <elasticsearch> and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120088&action=edit GIF showing the buggy behavior I have to mark this "Failed QA" again because the QA tool issues were not all addressed. Please run the QA tool and fix the problems it raises. The only other thing I noticed in testing today was that there is a change in behavior of the search tabs in the staff client. The layout is off, and the focus doesn't move to the input field like it does on the other tabs. See the attached screen grab. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #22 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- (In reply to Owen Leonard from comment #21)

Created attachment 120088 [details] GIF showing the buggy behavior

I have to mark this "Failed QA" again because the QA tool issues were not all addressed. Please run the QA tool and fix the problems it raises.

The only other thing I noticed in testing today was that there is a change in behavior of the search tabs in the staff client. The layout is off, and the focus doesn't move to the input field like it does on the other tabs. See the attached screen grab.

You have changed/moved CSS files and it provoke your problem with the layout (it was not good idea). Katrin Fischer gave you notice of that! Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #21)

The layout is off

My mistake--I recorded that screengrab without having rebuilt the CSS from SCSS. I will modify the test plan to make that part clear. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120029|0 |1 is obsolete| | --- Comment #26 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 120140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120140&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good <index_name> for <elasticsearch> and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120141|0 |1 is obsolete| | --- Comment #29 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 120806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120806&action=edit Bug 27113: (follow-up) QA Tests Bug 27113: (follow-up) QA Tests (2) Bug 27113: (follow-up) Fixup warnings. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good <index_name> for <elasticsearch> and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #32 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(... Bug 27113 - ElasticSearch: Autocomplete in input search 120109 - Bug 27113: (follow-up) Move new CSS to main SCSS files 120140 - Bug 27113: ElasticSearch: Autocomplete in input search 120806 - Bug 27113: (follow-up) QA Tests 121498 - Bug 27113: (follow-up) Correction with Session Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27113: (follow-up) Move new CSS to main SCSS files error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/elasticsearch/autocomplete.css). error: could not build fake ancestor Patch failed at 0001 Bug 27113: (follow-up) Move new CSS to main SCSS files -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I agree with Fridolin: we should think of adding API routes for this. There should be a privileged route, and an unprivileged route. You shouldn't worry about sessions and all. Just add the required permissions to interact with the routes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #36 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #34)

I agree with Fridolin: we should think of adding API routes for this. There should be a privileged route, and an unprivileged route. You shouldn't worry about sessions and all. Just add the required permissions to interact with the routes.

Yeah, I don't get why session data is being used here. I don't even know if there needs to be 2 routes. Maybe just 1 public/unprivileged API route. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #38 from David Nind <david@davidnind.com> --- (In reply to Ivan Dziuba from comment #33) ..

I checked it and it works :). Do you use Koha 21.05? Thanks. ..

Hi Ivan. I'm using master - I tried again and still get the same error for the CSS follow-up patch: .. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27113: (follow-up) Move new CSS to main SCSS files error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/elasticsearch/autocomplete.css). error: could not build fake ancestor Patch failed at 0001 Bug 27113: (follow-up) Move new CSS to main SCSS files .. I can get the patches to apply if I use interactive, comment out the CSS follow-up patch, then apply again using interactive and then just apply the CSS follow-up patch. I'm assuming the error is because the follow-up CSS is being applied first, but what it is changing doesn't exist yet as it is one of the later patches. I don't know enough about patches to fix this up, but will try and test with what I have. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120140|0 |1 is obsolete| | --- Comment #39 from David Nind <david@davidnind.com> --- Created attachment 121555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121555&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good <index_name> for <elasticsearch> and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121498|0 |1 is obsolete| | --- Comment #41 from David Nind <david@davidnind.com> --- Created attachment 121557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121557&action=edit Bug 27113: (follow-up) Correction with Session I have changed CGI::Session->new() from CGI::Session->load() for use session. This condition - 'CGI::Session->load() or die CGI::Session->errstr();' I am not sure that was good idea to use 'die' in this condition...What do you think? Thanks! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #43 from David Nind <david@davidnind.com> --- I finally got this to work for me, and it is a really nice feature. Nice work! I've signed off, but these are my suggestions for the wording for the new system preferences - the QA Team will probably comment on this is as well, so you may as well get ahead of them!: 1. IntranetAutocompleteElasticSearch: change system preference name to StaffInterfaceAutocompleteElasticsearch - We are using 'staff interface' now, instead of 'intranet' - not sure what the protocol is for system preference names, but for new system preferences we should probably start using StaffInterface; Elasticsearch doesn't have a capital S (see for example the SearchEngine system preference) 2. Wording for IntranetAutocompleteElasticSearch: . Currently: Don't show/Show looking terms based on a provided text by using an ElasticSearch for Intranet. . Suggested: Don't show/Show search suggestions in the staff interface when using Elasticsearch. 3. Wording for OPACAutocompleteElasticSearch: . Currently: Don't show/Show looking terms based on a provided text by using an ElasticSearch for OPAC. . Change to: Don't show/Show search suggestions in the OPAC when using Elasticsearch. Other testing notes (using koha-testing-docker): . Package command to rebuild the index: koha-elasticsearch -d --rebuild -a -b kohadev . Needed to change .env file as a result of recent commits to koha-testing-docker for Elasticsearch (compared default with custom .env file and added new variables) . As indicated earlier, had to apply patch interactively: 1st excluding CSS patch, then again to include CSS patch . Rebuild CSS as per CSS patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #44 from David Cook <dcook@prosentient.com.au> --- I am tempted to mark this as Failed QA, since I'm pretty sure the session handling doesn't work as intended (I think it's saving the session data in a file rather than in the database), but I haven't actually tested it, so leaving it as is. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As QA: I really like David's suggestions for the rephrasing. I think it makes the use much more clear. But before spending time on these, we probably need to sort out the other requirements/comments. Sessions: * David, can you be a bit more precise about what you think doesn't work? * Tomas, can you help with what you imagined and maybe the sessions bit? Does this need to be fixed here or could it be a follow-up? (In reply to Tomás Cohen Arazi from comment #34)

I agree with Fridolin: we should think of adding API routes for this. There should be a privileged route, and an unprivileged route. You shouldn't worry about sessions and all. Just add the required permissions to interact with the routes.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Blou from comment #46)

Ivan has already recoded it without sessions in our codebase. But before pushing that change, we'll be waiting for Tomas' instructions regarding the svc/

Hi Blou, thx for the update! So we can scratch that off the list. I'll ask Tomas to have another look. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #49 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Blou from comment #46)

Ivan has already recoded it without sessions in our codebase. But before pushing that change, we'll be waiting for Tomas' instructions regarding the svc/

I think this is a subject worth discussing in the open, i.e. in koha-devel. As I mentioned (not sure where) I believe we could try adding some filtering capabilities to GET /biblios to accomplish this. I proposed something similar on bug 25870. In that case, I proposed a 'q_ccl' query param that could take a CCL query so we could accept complex queries. The route would then extract the ids (biblionumbers) and return Koha::Biblios->to_api objects as required. I don't think CCL is a cool feature, but it felt like good start: allowing people to query records through the API. The ES syntax might be a high constraint for the feature (leaving Zebra users out), specially if you are querying things like title, author, etc. But that's another possibility: add a query parameter that only works with ES (q_es?). Regarding routes, you need to think what the response would look like. And it will help you figure what you want. Is it ok/enough for GET /biblios?<filter> to return JSON representation of the biblio+biblioitems table columns? Unfortunately, the OpenAPI v2.0 schema doesn't provide a way to define different response schemas for different content-type responses, and thus we left GET /biblios/:biblio_id under-documented (it is supported on v3) but you can try GET /biblios/1 and see the response to get an idea of what we already return [1]. It feels like we need to build a good query language, and reuse this routes. [1] This is how we build the JSON representation of a biblio https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/Bi... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #52 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 131208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131208&action=edit Bug 27113: (follow-up) QA Tests Bug 27113: (follow-up) QA Tests (2) Bug 27113: (follow-up) Fixup warnings. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good <index_name> for <elasticsearch> and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #54 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 131210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131210&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 The Minh Luong <the-minh.luong@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |the-minh.luong@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #57 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 132361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132361&action=edit Bug 27113: (follow-up) QA Tests Bug 27113: (follow-up) QA Tests (2) Bug 27113: (follow-up) Fixup warnings. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good <index_name> for <elasticsearch> and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #59 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 132363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132363&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #61 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 132808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132808&action=edit Bug 27113: No autosubmit after clicking autocomplete option in advanced search This patch makes it so it doesn't automatically submit form after clicking an autocomplete option in advanced search. Also removes autocomplete options after pressing tab. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com --- Comment #63 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- My concern is that searching with more than 1 prefix is going to be too slow when there are lots of items since it will go through a triple nested loop. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132945|0 |1 is obsolete| | --- Comment #65 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 132946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132946&action=edit Bug 27113: Removes items in OPACHiddenItems from autocomplete Items specified in OPACHiddenItems preference are removed from search suggestions in OPAC. Test plan: 1- Search for an item. Notice that the autocomplete functionnality is not available. (See "Result" attachment) 2- Make sure that you are using Elasticsearch as your searching engine. (Preference->SearchEngine->ElasticSearch) 3- Apply the patch. 4- Run ./installer/data/mysql/updatedatabase.pl 5- Looks for the following preferences : - IntranetAutocompleteElasticSearch - OPACAutocompleteElasticSearch 6- Set their value to show. 7- Rebuild the OPAC and staff client CSS (This step is important because the autocomplete CSS is moved to the main SCSS file): Instructions here: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... 8- Search for an item and notice that the autocomplete functionnality is now available. 9- In the staff interface, go in "Search the catalog". 10- Notice that the buggy behavior is now fixed. 11- Search for an item with basic search and click on one of the options. 12- Notice it automatically sends you to the selected items page. 13- This time, search an item using the advanced search and click on one of the options. 14- Notice it just writes the chosen option in the input instead. 15- Go to Administration -> system preferences -> OPACHiddenItems. 16- Define a rule that applies to an existing item. 17- Search that item in OPAC and notice it doesn't give you the suggestion for that item. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #66 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 133042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133042&action=edit Bug 27113: Removes hidden and suppressed items from OPAC autocomplete Items specified in OPACHiddenItems preference and items affected by OpacSuppression are removed from search suggestions in OPAC. Test plan: 1- Search for an item. Notice that the autocomplete functionnality is not available. (See "Result" attachment) 2- Make sure that you are using Elasticsearch as your searching engine. (Preference->SearchEngine->ElasticSearch) 3- Apply the patch. 4- Run ./installer/data/mysql/updatedatabase.pl 5- Looks for the following preferences : - IntranetAutocompleteElasticSearch - OPACAutocompleteElasticSearch 6- Set their value to show. 7- Rebuild the OPAC and staff client CSS (This step is important because the autocomplete CSS is moved to the main SCSS file): Instructions here: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... 8- Search for an item and notice that the autocomplete functionnality is now available. 9- In the staff interface, go in "Search the catalog". 10- Notice that the buggy behavior is now fixed. 11- Search for an item with basic search and click on one of the options. 12- Notice it automatically sends you to the selected items page. 13- This time, search an item using the advanced search and click on one of the options. 14- Notice it just writes the chosen option in the input instead. 15- Go to Administration -> system preferences -> OPACHiddenItems. 16- Define a rule that applies to an existing item. 17- Search that item in OPAC and notice it doesn't give you the suggestion for that item. 18- Go to Administration -> system preferences -> OpacSuppression and set it to "hide". 19- Add or edit a record and set 942$n field to yes. 20- Search that entry in OPAC and notice it doesn't give you the suggestion for that entry. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132360|0 |1 is obsolete| | --- Comment #68 from Blou <philippe.blouin@inlibro.com> --- Created attachment 133407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133407&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good <index_name> for <elasticsearch> and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133042|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132362|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132364|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132363|0 |1 is obsolete| | --- Comment #70 from Blou <philippe.blouin@inlibro.com> --- Created attachment 133410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133410&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133409|0 |1 is obsolete| | --- Comment #72 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 136312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136312&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good <index_name> for <elasticsearch> and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind <david@davidnind.com> Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #73 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Squashed the two patches at the request of Blou. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136312|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #74 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Nevermind. Put back the last two patches. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133410|0 |1 is obsolete| | --- Comment #76 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 136457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136457&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #78 from David Nind <david@davidnind.com> --- Created attachment 136465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136465&action=edit Bug 27113 - Advanced search - more options display issue I've added a follow-up with my suggestions for the descriptions for the two new system preferences. I've changed the status to Failed QA as there is a slight issue with the staff interface advanced search > more options after the patch is applied. See the attached screenshots. Also, something for QA to comment on. The spelling for Elasticsearch - the s in search is not capitalised, as it is the product name (not ElasticSearch). Does this need changing for the preference names, and the other code in the patches? Can confirm everything continues to work otherwise, and I like it! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #79 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 136653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136653&action=edit Bug 27113: (follow-up) fix adv. searches - more options display issue -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #80 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Fixed the little display issue. Also, does anyone know how to have the same relative path to one file from both OPAC and staff interface url? (e.g. http://master/api/elasticsearch/elasticsearch.pl and http://master-intranet/api/elasticsearch/elasticsearch.pl) With this we would only need to create one .pl file to be used by both interface instead of one for each. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136456|0 |1 is obsolete| | --- Comment #81 from David Nind <david@davidnind.com> --- Created attachment 136657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136657&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good <index_name> for <elasticsearch> and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136464|0 |1 is obsolete| | --- Comment #83 from David Nind <david@davidnind.com> --- Created attachment 136659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136659&action=edit Bug 27113: (follow-up) Update descriptions for system preferences Update the descriptions for the new system preferences - IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch. Test plan: 1. Review the descriptions for the IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch system preferences. 2. Make sure they are readable and make sense. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #85 from David Nind <david@davidnind.com> --- (In reply to Shi Yao Wang from comment #80)

Fixed the little display issue.

Thanks!

Also, does anyone know how to have the same relative path to one file from both OPAC and staff interface url? (e.g. http://master/api/elasticsearch/elasticsearch.pl and http://master-intranet/api/elasticsearch/elasticsearch.pl)

With this we would only need to create one .pl file to be used by both interface instead of one for each.

Sorry, I don't. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #86 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

...

Also, does anyone know how to have the same relative path to one file from both OPAC and staff interface url? (e.g. http://master/api/elasticsearch/elasticsearch.pl and http://master-intranet/api/elasticsearch/elasticsearch.pl)

With this we would only need to create one .pl file to be used by both interface instead of one for each.

Sorry, I don't.

AFAIK it's not possible to share files between OPAC and staff interface. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136657|0 |1 is obsolete| | --- Comment #88 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 137436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137436&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good <index_name> for <elasticsearch> and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136659|0 |1 is obsolete| | --- Comment #90 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 137438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137438&action=edit Bug 27113: (follow-up) Update descriptions for system preferences Update the descriptions for the new system preferences - IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch. Test plan: 1. Review the descriptions for the IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch system preferences. 2. Make sure they are readable and make sense. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #92 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Fixed an encoding/display problem when using "é", "ù", etc. (In reply to Fridolin Somers from comment #87)

You can with REST API. Public routes are same file between OPAC and staff : https://wiki.koha-community.org/wiki/REST_api_RFCs#Unprivileged_.28public. 29_routes

I don't know how to do it, but I think it would be a good idea. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137436|0 |1 is obsolete| | --- Comment #94 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 137780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137780&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good <index_name> for <elasticsearch> and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137438|0 |1 is obsolete| | --- Comment #96 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 137782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137782&action=edit Bug 27113: (follow-up) Update descriptions for system preferences Update the descriptions for the new system preferences - IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch. Test plan: 1. Review the descriptions for the IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch system preferences. 2. Make sure they are readable and make sense. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #98 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- (In reply to Katrin Fischer from comment #93)

First of all: I quite like the functionality and how this looks. It also appears to be pretty fast and accurate as far as I can tell. I especially like that it's not only available for the keyword index, but also on other search options like author search and limits the results down accordingly.

That said: There are a couple things here that would require fixing and a big question we need to resolve for moving this forward.

The small stuff: 1) In the database update, there should still be a description for the system preference. 2) sysprefs.sql is sorted alphabetically to avoid conflicts, please move the prefs into the correct places. 3) Instead of use strict; use warnings; we use use Modern::Perl; (see PERL2 in coding guidelines) 4) In the database update elasticsearch should be Elasticsearch.

Somewhat bigger:

5) I have problems making this work with the "library catalog" and "title" search options in simple search in OPAC. title doesn't give me any results and library catalog looks like author (but it's a keyword search). Something might not be 'wired' correctly there. 6) Updating installations: I believe you also need to reset mappings to make this work? How can we ensure this works out of the box for people updating without them having to "redo" their index configuration? (database update?) 7) sub filterAutocomplete looks complex and I wonder if it should be in the .pl and not in a module where it can be tested. 942 is hardcoded as field for OpacSuppression, which is a little risky. I wonder if it could be more elegant to filter this at search time instead of after?

Small stuff fixed. 5) Searching with "title" works for me. Maybe an index issue? or is it just me? "library catalog" search displays suggestions for each search options in this order: title-cover, author, subject, title-series, publisher. What I think probably happened is, since "title" search doesn't work for you, it showed "author" suggestions where you had more match than the maximum number of rows displayed. 6) I don't know :/ 7) I can move it to a module, but which one? Maybe in a new module? if so, where? I reused the code in opac/opac-detail.pl where 942 is hardcoded too. I do think it would be better to filter at search time but I don't know how... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #100 from Blou <philippe.blouin@inlibro.com> --- Created attachment 141466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141466&action=edit Bug 27113: Allow for ending special characters in titles Modifies the cleanup regex that removed )}' and " endings from the suggested titles or authors. When selected without those, the record was not found. Ex: "MyTitle (1234)" became "MyTitle (123" in the list. It returned no results, where the full title or "MyTitle 123" would. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #102 from Blou <philippe.blouin@inlibro.com> --- Created attachment 145167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145167&action=edit Bug 27113: (follow-up) diacritics/acccents in sought word would make autocomplete return nothing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele@inlibro.com --- Comment #104 from Hammat wele <hammat.wele@inlibro.com> --- sub filterAutocomplete moved to a new module and now the filtering is done at the search time. (In reply to Katrin Fischer from comment #93)

6) Updating installations: I believe you also need to reset mappings to make this work? How can we ensure this works out of the box for people updating without them having to "redo" their index configuration? (database update?)

It's been wrote in the test plan by precaution but there is no need reset mappings to make this work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ivan.dziuba@inlibro.com |hammat.wele@inlibro.com Depends on| |30790, 25870 CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #105 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Waiting for some work on bug 25870 and bug 30790 to continue this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 [Bug 25870] Add a q_ccl query parameter to /biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 [Bug 30790] Add REST API route to list biblios -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Bug 27113 depends on bug 30790, which changed state. Bug 30790 Summary: Add REST API route to list biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ivan.dziuba@inlibro.com, | |the-minh.luong@inlibro.com | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Bug 27113 depends on bug 32734, which changed state. Bug 32734 Summary: REST API: Add a list endpoint for Biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133042|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137782|0 |1 is obsolete| | --- Comment #107 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 159770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159770&action=edit Bug 27113: (follow-up) Update descriptions for system preferences Update the descriptions for the new system preferences - IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch. Test plan: 1. Review the descriptions for the IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch system preferences. 2. Make sure they are readable and make sense. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139624|0 |1 is obsolete| | --- Comment #109 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 159772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159772&action=edit Bug 27113: (follow-up) replace removed GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145167|0 |1 is obsolete| | --- Comment #111 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 159774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159774&action=edit Bug 27113: (follow-up) diacritics/acccents in sought word would make autocomplete return nothing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |salah.ghedda@inlibro.com --- Comment #113 from Salah Ghedda <salah.ghedda@inlibro.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159769|0 |1 is obsolete| | --- Comment #115 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 160135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160135&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159771|0 |1 is obsolete| | --- Comment #117 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 160137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160137&action=edit Bug 27113: (follow-up) fix adv. searches - more options display issue Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159773|0 |1 is obsolete| | --- Comment #119 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 160139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160139&action=edit Bug 27113: Allow for ending special characters in titles Modifies the cleanup regex that removed )}' and " endings from the suggested titles or authors. When selected without those, the record was not found. Ex: "MyTitle (1234)" became "MyTitle (123" in the list. It returned no results, where the full title or "MyTitle 123" would. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159775|0 |1 is obsolete| | --- Comment #121 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 160141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160141&action=edit Bug 27113: Move filterAutocomplete to a new module and filter the result at search time -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #123 from Magnus Enger <magnus@libriotech.no> --- (In reply to Katrin Fischer from comment #93)

The last big question, I'll refer to the RM: This adds to /svc which is the outdated way of doing things as others have pointed out before. I think in order to move on here and before more time is spend, we should come to a decision of what is required for this patch to make it in and if it needs to be rewritten to use REST API or if this could be an exception.

As far as I can see, the patches are still adding to svc, not the REST API? So I guess we need to resolve this question for the bug to move forward? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160142|0 |1 is obsolete| | Attachment #160142|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161076|0 |1 is obsolete| | Attachment #161076|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #127 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #124)

I believe we had a plan here involving solving bug 25870 first as a better base for the work here. It's already linked as a dependency, but needs some more work right now.

I know a lot of people would love to see this functionality and I hope we can figure out the implementation bits this cycle.

Can you have a look at bug 25870 maybe? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |BLOCKED --- Comment #129 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Blocked by bug 25870 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160135|0 |1 is obsolete| | --- Comment #131 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 165896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165896&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160137|0 |1 is obsolete| | --- Comment #133 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 165898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165898&action=edit Bug 27113: (follow-up) fix adv. searches - more options display issue Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160139|0 |1 is obsolete| | --- Comment #135 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 165900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165900&action=edit Bug 27113: Allow for ending special characters in titles Modifies the cleanup regex that removed )}' and " endings from the suggested titles or authors. When selected without those, the record was not found. Ex: "MyTitle (1234)" became "MyTitle (123" in the list. It returned no results, where the full title or "MyTitle 123" would. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160141|0 |1 is obsolete| | --- Comment #137 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 165902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165902&action=edit Bug 27113: Move filterAutocomplete to a new module and filter the result at search time -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163826|0 |1 is obsolete| | --- Comment #139 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 165904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165904&action=edit Bug 27113: Fix the issue of the cursor not displaying -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165913|0 |1 is obsolete| | --- Comment #142 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 165922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165922&action=edit Bug 27113: Fix input size of all searchbar -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #143 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #124)

I believe we had a plan here involving solving bug 25870 first as a better base for the work here. It's already linked as a dependency, but needs some more work right now.

I know a lot of people would love to see this functionality and I hope we can figure out the implementation bits this cycle.

I haven't reviewed the patches or comments in depth (I've only skimmed so far), but why would an autocomplete need a q_ccl query parameter on /biblios? It seems to me that bug 25870 is about adding a search endpoint, while this enhancement would be scanning indexes rather than searching them? Perhaps I'm misunderstanding the intent on bug 27113. I'd be worried about searches being done during an autocomplete. I have a lot of big systems that are slow to search (work in progress making search faster), and that wouldn't work at all for them... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #145 from David Cook <dcook@prosentient.com.au> --- Correct me if I'm wrong but wouldn't the most logical way to move forward with bug 27113 would be to temporarily drop the dependency on bug 27428? That feature, which would depend on bug 25870, could then be added later? Heck, it could even be trialled in prod using a Koha plugin, since it would primarily be an added API endpoint and some Javascript, no? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #147 from David Cook <dcook@prosentient.com.au> --- Note: I think we want to use "suggestable" rather than "suggestible" here. The first one, in a technical context, meant to be able to be suggest. "Suggestible" means being easily persuaded by a suggestion. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #149 from David Cook <dcook@prosentient.com.au> --- Realising now that I needed to rebuild the CSS. It would be good to provide an up-to-date test plan, especially one geared towards koha-testing-docker, which is what most testers will be using. -- With the re-built CSS, the staff interface auto complete is looking much better, but it still looks a little weird. It's a rectangular white text box that overlaps with the masthead. Ah it has the text highlighting now and the separation of suggestions. Excellent. NOTE: If you have a long autocomplete list, it clashes with the search toolbar on the search result page. It displays UNDER the "Select all | Clear all | Unhighlight | Add to cart... etc" when it should be displaying OVER. Additionally, it might make more sense to show 3-5 options instead of 10 and have a scroll so that you can look through the options. 10 options takes up a lot of the page... -- NOTE: It would be interesting to test this against a very large ES database. It's very fast on koha-testing-docker, but it only has ~400 bib records. Note: I notice that there's no loading icon for the autocomplete. Even on a small database, there's a slight lag until the autocomplete results show. It might be good to have a small loading icon in the search bar. (Just a nice to have. Not the end of the world if there isn't one, although on a large database, it might be a problem.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #151 from David Cook <dcook@prosentient.com.au> --- Btw, it would be interesting to explore changing "_build_query_autocomplete" to include "OpacSuppression" with say a Boolean query, as it would be ideal to include the OpacSuppression search at the search engine level. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #153 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #152)

Overall, I have to say that this is a pretty cool feature.

We're almost exclusively using Elasticsearch now over Zebra, so I can probably help move this along. (I'm no good with dev meetings due to timezones, but let's try to hash out this bug 25870 issue.)

I'd be really happy to have this feature in 25.05 and team work is the best work :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165896|0 |1 is obsolete| | --- Comment #155 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 177538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177538&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165898|0 |1 is obsolete| | --- Comment #157 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 177540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177540&action=edit Bug 27113: (follow-up) fix adv. searches - more options display issue Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165900|0 |1 is obsolete| | --- Comment #159 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 177542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177542&action=edit Bug 27113: Allow for ending special characters in titles Modifies the cleanup regex that removed )}' and " endings from the suggested titles or authors. When selected without those, the record was not found. Ex: "MyTitle (1234)" became "MyTitle (123" in the list. It returned no results, where the full title or "MyTitle 123" would. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165902|0 |1 is obsolete| | --- Comment #161 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 177544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177544&action=edit Bug 27113: Move filterAutocomplete to a new module and filter the result at search time -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165904|0 |1 is obsolete| | --- Comment #163 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 177546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177546&action=edit Bug 27113: Fix the issue of the cursor not displaying -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #165 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 177548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177548&action=edit Bug 27113: Fix autocomplete list position This patch set the z-index of form-content When you are on the search results page on the intranet, and you do another search that opens the autocomplete dropdown, the results page number is above it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #167 from David Cook <dcook@prosentient.com.au> --- I think Hammat has fixed some of my concerns, but not all of them... -- 1) I'm still noticing that the input for "Search catalog" is wrong when I'm taken to the detail page. For instance: 1. Search "test" in ktd using "Search catalog" (don't worry about autocomplete) 2. Now type in "e" into the "Search catalog" 3. Choose "Early jazz" 4. You should be taken to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=291&found1=1 5. Note that the input for "Search catalog" says "test" and not "Early jazz" -- 2) The autocomplete suggestions menu looks funny. It starts a bit too far right on the left side, and on the right-side its square edge creates a weird gap with the rounded end of the input for "Search catalog" It's not terrible, but it's... uncomfortable? It just doesn't feel right yet. But close. -- 3) It's still using the SVC API. Switching over to the REST API shouldn't be hard here. Actually, I also notice a api/elasticsearch/elasticsearch.pl which breaks all existing patterns as well. These need to go. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177548|0 |1 is obsolete| | --- Comment #169 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 177657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177657&action=edit Bug 27113: Fix autocomplete list position This patch set the z-index of form-content When you are on the search results page on the intranet, and you do another search that opens the autocomplete dropdown, the results page number is above it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177537|0 |1 is obsolete| | --- Comment #170 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178822&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good <index_name> for <elasticsearch> and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177539|0 |1 is obsolete| | --- Comment #172 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178824&action=edit Bug 27113: (follow-up) Update descriptions for system preferences Update the descriptions for the new system preferences - IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch. Test plan: 1. Review the descriptions for the IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch system preferences. 2. Make sure they are readable and make sense. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177541|0 |1 is obsolete| | --- Comment #174 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178826&action=edit Bug 27113: (follow-up) replace removed GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes.