[Bug 27566] New: CSS rule not applying to HTML select / option - displays with serif font ignoring rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Bug ID: 27566 Summary: CSS rule not applying to HTML select / option - displays with serif font ignoring rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: Mac OS Status: NEW Severity: critical Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: ramos.rodolfo@gmail.com QA Contact: testopia@bugs.koha-community.org System uses NotoSans to render content, the font file loads correctly (see it in the network while using inspector). The HTML select displays with serif fonts.The CSS rules applied to select and option is font-family: NotoSans. In this instance i think there should be a fallback like font-family: NotoSans, sans-serif. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- OS|Mac OS |All Severity|critical |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115975&action=edit Bug 27566: Add generic font family to prevent unstyled select tags This patch adds a default font family "sans-serif" to the OPAC CSS as a workaround for this Firefox bug: font-family isn't honored in `<option>` element within `<select>` dropdown https://bugzilla.mozilla.org/show_bug.cgi?id=1536148 To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Open the OPAC main page in Firefox. - Click the search type dropdown. The options should be styled using your system's default sans-serif font rather than a serif font. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk --- Comment #2 from Henry Bolshaw <bolshawh@parliament.uk> --- I can't replicate this bug on Firefox 86 or Firefox 78.8.0esr (desktop Linux) or Firefox for Android. Please would you provide more information about how to reproduce the error or provide a screenshot of where the serif font appears. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118369&action=edit Screenshot of OPAC dropdown in Firefox on macOS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #4 from Henry Bolshaw <bolshawh@parliament.uk> --- Thanks Owen! I'm seeing something different in my browser so I don't think I can test this patch unfortunately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #5 from RR <ramos.rodolfo@gmail.com> --- Hya, i'm on ubuntu, also couldn't get the bug on firefox or chrome. I think that you'd get the bug visible on gnome web, which is "a sort" of safari. Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #6 from RR <ramos.rodolfo@gmail.com> --- Sorry guys actually looks like you can't replicate using gnome web -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For what it's worth, we are seeing this bug with Firefox ESR in Windows. Sadly, I can't test this myself either, but I'll try and see if I can find some other combination that shows the error outside windows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115975|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 118568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118568&action=edit Bug 27566: Add generic font family to prevent unstyled select tags This patch adds a default font family "sans-serif" to the OPAC CSS as a workaround for this Firefox bug: font-family isn't honored in `<option>` element within `<select>` dropdown https://bugzilla.mozilla.org/show_bug.cgi?id=1536148 To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Open the OPAC main page in Firefox. - Click the search type dropdown. The options should be styled using your system's default sans-serif font rather than a serif font. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch won't hurt anything - changes are standard CSS and will be ok, I checked for regressions in a few browsers. I hope to do another check from Windows, but really happy if someone beats me to it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118568|0 |1 is obsolete| | --- Comment #10 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 118591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118591&action=edit Bug 27566: Add generic font family to prevent unstyled select tags This patch adds a default font family "sans-serif" to the OPAC CSS as a workaround for this Firefox bug: font-family isn't honored in `<option>` element within `<select>` dropdown https://bugzilla.mozilla.org/show_bug.cgi?id=1536148 To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Open the OPAC main page in Firefox. - Click the search type dropdown. The options should be styled using your system's default sans-serif font rather than a serif font. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Henry! Counting my Sign off for QA in this case :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #12 from Henry Bolshaw <bolshawh@parliament.uk> --- I'd forgotten I could test this via the sandboxes! I can confirm that the serif font was appearing when using Firefox on Windows and that this patch fixes the issue. I didn't notice any other visual changes when the patch was applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Henry Bolshaw from comment #12)
I'd forgotten I could test this via the sandboxes! I can confirm that the serif font was appearing when using Firefox on Windows and that this patch fixes the issue. I didn't notice any other visual changes when the patch was applied.
Same here :) Totally forgot I could use the sandboxes from my Windows environment yesterday. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- This patch was very wrong, and I'm sorry I made it. It breaks the expected custom font-loading completely. I have what I think is a correct patch. It could be added as a follow-up or the original could be reverted. There is no part of the original patch which is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #16 from Henry Bolshaw <bolshawh@parliament.uk> --- Now you tell us! :O -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119322&action=edit Bug 27566: (follow-up) Add generic font family to prevent unstyled select tags This correction fixes the previous patch which was dumb and stupid. This patch adds a default font family "sans-serif" to the OPAC CSS as a workaround for this Firefox bug: font-family isn't honored in `<option>` element within `<select>` dropdown https://bugzilla.mozilla.org/show_bug.cgi?id=1536148 To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Open the OPAC main page in Firefox. - Click the search type dropdown. The options should be styled using your system's default sans-serif font rather than a serif font. - Check that other areas of the OPAC are still styled with the correct "NotoSans" font. An error with this patch should be obvious when looking at a logged-in user's checkouts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oh I wait for backport then. We may revert from master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119322|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 119560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119560&action=edit Bug 27566: (follow-up) Add generic font family to prevent unstyled select tags This correction fixes the previous patch which was dumb and stupid. This patch adds a default font family "sans-serif" to the OPAC CSS as a workaround for this Firefox bug: font-family isn't honored in `<option>` element within `<select>` dropdown https://bugzilla.mozilla.org/show_bug.cgi?id=1536148 To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Open the OPAC main page in Firefox. - Click the search type dropdown. The options should be styled using your system's default sans-serif font rather than a serif font. - Check that other areas of the OPAC are still styled with the correct "NotoSans" font. An error with this patch should be obvious when looking at a logged-in user's checkouts. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #20 from David Nind <david@davidnind.com> --- Testing notes: - Tested on Ubuntu 18.04 with Firefox 87 64-bit and Firefox Developer Edition 88.0b9 64-bit - Didn't notice any change with the drop down list - was the NotoSans or a sans-serif font - I did notice on the checkouts summary page - some text was a serif font including the title: applying the patch and updating the CSS fixed it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119560|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 120031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120031&action=edit Bug 27566: (follow-up) Add generic font family to prevent unstyled select tags This correction fixes the previous patch which was dumb and stupid. This patch adds a default font family "sans-serif" to the OPAC CSS as a workaround for this Firefox bug: font-family isn't honored in `<option>` element within `<select>` dropdown https://bugzilla.mozilla.org/show_bug.cgi?id=1536148 To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Open the OPAC main page in Firefox. - Click the search type dropdown. The options should be styled using your system's default sans-serif font rather than a serif font. - Check that other areas of the OPAC are still styled with the correct "NotoSans" font. An error with this patch should be obvious when looking at a logged-in user's checkouts. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This also fixes the item type descriptions on the advanced search that had suddenly started to show in serif font for me :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.06 released in| | --- Comment #24 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Doesn't apply cleanly to 20.05, please rebase if needed. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org