[Bug 28064] New: Transits are not created at check in despite user responding 'Yes, print slip' to the prompt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Bug ID: 28064 Summary: Transits are not created at check in despite user responding 'Yes, print slip' to the prompt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com, gmcharlt@gmail.com, katrin.fischer@bsz-bw.de, kyle.m.hall@gmail.com, kyle@bywatersolutions.com, mtj@kohaaloha.com, oleonard@myacpl.org, testopia@bugs.koha-community.org Depends on: 18372, 24085 +++ This bug was initially created as a clone of Bug #18372 +++ When checking in an item from another library the user is prompted whether the item should go into transit if they respond "Yes, print slip" no transit is created and the item status is shown as Available. This bug appears to be a resurgence of bug 18372 since we pushed bug 24085. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18372 [Bug 18372] transits are not created at check in despite user responsing Yes to the prompt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 [Bug 24085] Double submission of forms on returns.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|colin.campbell@ptfs-europe. |sally.healey@cheshireshared |com |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gmcharlt@gmail.com, | |kyle.m.hall@gmail.com, | |mtj@kohaaloha.com, | |testopia@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test plan * Set AutomaticItemReturn system preference is set to "Don't" * Check in an item that belongs to another library, a dialog will ask you if you want to transfer. * Click 'Yes, print slip' * Look at the item record and note the status is 'Available', it should be 'In transit to...' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119044&action=edit Bug 28064: Add dotransfer field to slip print submission By changing the code to only do a javascript triggered submission from the from button we lose the original buttons name and value elements upon submission. This patch checks for those fields in the JS capture and triggers the addition of a new hidden form field to contain the dotransfer data. Test plan 1/ Set AutomaticItemReturn system preference is set to "Don't" 2/ Check in an item that belongs to another library, a dialog will ask you if you want to transfer. 3/ Click 'Yes, print slip' 4/ Look at the item record and note the status is 'Available'. 5/ Apply patch 6/ Follow steps 2 - 4 7/ Note the status is now 'In transit to...' 8/ Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119045&action=edit Bug 28064: (follow-up) Do not re-trigger transfer if it already exists For some unknown reason the 'Print slip' button for when a transfer has already been triggered also had the 'dotransfer' name attribute. It won't have been getting passed to the form on submission due to the bug with JS submissions and that this particular button was always a button and not a submit in the past. However, it does need removing to prevent the re-triggering now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119044|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 119055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119055&action=edit Bug 28064: Add dotransfer field to slip print submission By changing the code to only do a javascript triggered submission from the from button we lose the original buttons name and value elements upon submission. This patch checks for those fields in the JS capture and triggers the addition of a new hidden form field to contain the dotransfer data. Test plan 1/ Set AutomaticItemReturn system preference is set to "Don't" 2/ Check in an item that belongs to another library, a dialog will ask you if you want to transfer. 3/ Click 'Yes, print slip' 4/ Look at the item record and note the status is 'Available'. 5/ Apply patch 6/ Follow steps 2 - 4 7/ Note the status is now 'In transit to...' 8/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119045|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 119056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119056&action=edit Bug 28064: (follow-up) Do not re-trigger transfer if it already exists For some unknown reason the 'Print slip' button for when a transfer has already been triggered also had the 'dotransfer' name attribute. It won't have been getting passed to the form on submission due to the bug with JS submissions and that this particular button was always a button and not a submit in the past. However, it does need removing to prevent the re-triggering now. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119055|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 119440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119440&action=edit Bug 28064: Add dotransfer field to slip print submission By changing the code to only do a javascript triggered submission from the from button we lose the original buttons name and value elements upon submission. This patch checks for those fields in the JS capture and triggers the addition of a new hidden form field to contain the dotransfer data. Test plan 1/ Set AutomaticItemReturn system preference is set to "Don't" 2/ Check in an item that belongs to another library, a dialog will ask you if you want to transfer. 3/ Click 'Yes, print slip' 4/ Look at the item record and note the status is 'Available'. 5/ Apply patch 6/ Follow steps 2 - 4 7/ Note the status is now 'In transit to...' 8/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119056|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 119441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119441&action=edit Bug 28064: (follow-up) Do not re-trigger transfer if it already exists For some unknown reason the 'Print slip' button for when a transfer has already been triggered also had the 'dotransfer' name attribute. It won't have been getting passed to the form on submission due to the bug with JS submissions and that this particular button was always a button and not a submit in the past. However, it does need removing to prevent the re-triggering now. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Here is another signoff in the hope of helping. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hum, actually I don't know how to test the second patch. «However, it does need removing to prevent the re-triggering now.» Didn't found how to do a re-triggering when not having the second patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119440|0 |1 is obsolete| | Attachment #119441|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119585&action=edit Bug 28064: Add dotransfer field to slip print submission By changing the code to only do a javascript triggered submission from the from button we lose the original buttons name and value elements upon submission. This patch checks for those fields in the JS capture and triggers the addition of a new hidden form field to contain the dotransfer data. Test plan 1/ Set AutomaticItemReturn system preference is set to "Don't" 2/ Check in an item that belongs to another library, a dialog will ask you if you want to transfer. 3/ Click 'Yes, print slip' 4/ Look at the item record and note the status is 'Available'. 5/ Apply patch 6/ Follow steps 2 - 4 7/ Note the status is now 'In transit to...' 8/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #10)
Hum, actually I don't know how to test the second patch. «However, it does need removing to prevent the re-triggering now.»
Didn't found how to do a re-triggering when not having the second patch.
I think Victor is right, the second patch touches code that isn't hit when we have an existing transfer - we hit the 'WrongTransfer' portion instead - dropping that and passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Nick.. you guys were both right.. I hadn't taken a broad enough view of the code with that intuitive follow-up.. happy it's been dropped :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28148 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 [Bug 28148] js error when printing transfer slip for existing transfer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The switch from input to button has been done on commit 10a9a1e147699bdb1fd2b58ab93fe87cb82074cf Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation Does it mean it's broken for 5 years? Additional question, shouldn't we remove the value="Yes" attribute from the buttons, to avoid confusion in the future? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- *** Bug 28176 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Waiting for answer on comment 14. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #14)
The switch from input to button has been done on commit 10a9a1e147699bdb1fd2b58ab93fe87cb82074cf Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation
Does it mean it's broken for 5 years?
Additional question, shouldn't we remove the value="Yes" attribute from the buttons, to avoid confusion in the future?
A git bisect traced it back to bug 24085 for me... so not 5 years.. but certainly since 19.11.02. Hmm, removing the 'value=Yes' is perhaps a good idea... I tried to be as noninvasive as I could as this template is plain confusing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119993&action=edit Bug 28064: (QA follow-up) Remove value from button To clarify that the value is not used on buttons that are not submit type we remove the value entirely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in| | --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06,20.05.12 |21.05.00,20.11.06,20.05.12, released in| |19.11.18 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.18 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org