[Bug 29006] New: Make GoogleOpenIDConnect options consistent in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 Bug ID: 29006 Summary: Make GoogleOpenIDConnect options consistent in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 10988 In the OPAC, when GoogleOpenIDConnect is enabled, the login options are inconsistent: - The "Log in to your account" link in the header takes you straight to a Google form. - The login form on the main page doesn't offer a link to Google login, just the standard login form. - The login page offers both a GoogleOpenIDConnect link and a standard login form. If GoogleOpenIDConnect is enabled, all login options should offer both Google and Koha login. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124862&action=edit Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC This patch makes modifications to OPAC templates to make the Google login options more consistent. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - In the staff interface, enable the GoogleOpenIDConnect preference, and populate the GoogleOAuth2ClientID the GoogleOAuth2ClientSecret with values (they don't need to be valid). - On the OPAC main page you should see a "Log in with Google" button above the Koha login form. - If you click the "Log in to your account" link at the top of the page you should see a "Log in with Google" button in the modal window - If you navigate directly to /cgi-bin/koha/opac-user.pl when not logged in you should see the same "Log in with Google" button on that page. - In each case the Google button should point to /cgi-bin/koha/svc/auth/googleopenidconnect - If you disable GoogleOpenIDConnect the buttons should disappear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Hi Owen. After applying the patch, updating the css, flush_memcached, restart_all, and a fresh browser with the cache cleared I'm not seeing the changes come through in the OPAC (the login form on the main page and in the header). It's probably something I haven't done.... David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- You populated these preferences? GoogleOAuth2ClientID GoogleOAuth2ClientSecret And turned this one on? GoogleOpenIDConnect Do you have any missing modules under About -> Perl modules? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124862|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 125177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125177&action=edit Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC This patch makes modifications to OPAC templates to make the Google login options more consistent. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - In the staff interface, enable the GoogleOpenIDConnect preference, and populate the GoogleOAuth2ClientID the GoogleOAuth2ClientSecret with values (they don't need to be valid). - On the OPAC main page you should see a "Log in with Google" button above the Koha login form. - If you click the "Log in to your account" link at the top of the page you should see a "Log in with Google" button in the modal window - If you navigate directly to /cgi-bin/koha/opac-user.pl when not logged in you should see the same "Log in with Google" button on that page. - In each case the Google button should point to /cgi-bin/koha/svc/auth/googleopenidconnect - If you disable GoogleOpenIDConnect the buttons should disappear. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #3)
You populated these preferences?
GoogleOAuth2ClientID GoogleOAuth2ClientSecret
And turned this one on?
GoogleOpenIDConnect
Do you have any missing modules under About -> Perl modules?
All worked perfectly today! Must have been me not doing something right..¯\_(ツ)_/¯ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual Text to go in the| |This enhancement improves release notes| |the consistency of the OPAC | |login forms when using | |Google OpenID Connect. A | |"Log in with Google" button | |now appears above the Koha | |login form when logging in | |from the home page, "Log in | |to your account" in the | |navigation menu, and when | |accessed directly | |(/cgi-bin/koha/opac-user.pl | |). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125177|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125314&action=edit Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC This patch makes modifications to OPAC templates to make the Google login options more consistent. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - In the staff interface, enable the GoogleOpenIDConnect preference, and populate the GoogleOAuth2ClientID the GoogleOAuth2ClientSecret with values (they don't need to be valid). - On the OPAC main page you should see a "Log in with Google" button above the Koha login form. - If you click the "Log in to your account" link at the top of the page you should see a "Log in with Google" button in the modal window - If you navigate directly to /cgi-bin/koha/opac-user.pl when not logged in you should see the same "Log in with Google" button on that page. - In each case the Google button should point to /cgi-bin/koha/svc/auth/googleopenidconnect - If you disable GoogleOpenIDConnect the buttons should disappear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Passed QA |Patch doesn't apply --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please resubmit without the changes to opac.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125314|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125486&action=edit Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC This patch makes modifications to OPAC templates to make the Google login options more consistent. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - In the staff interface, enable the GoogleOpenIDConnect preference, and populate the GoogleOAuth2ClientID the GoogleOAuth2ClientSecret with values (they don't need to be valid). - On the OPAC main page you should see a "Log in with Google" button above the Koha login form. - If you click the "Log in to your account" link at the top of the page you should see a "Log in with Google" button in the modal window - If you navigate directly to /cgi-bin/koha/opac-user.pl when not logged in you should see the same "Log in with Google" button on that page. - In each case the Google button should point to /cgi-bin/koha/svc/auth/googleopenidconnect - If you disable GoogleOpenIDConnect the buttons should disappear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #7)
Please resubmit without the changes to opac.css
Whoops, sorry about that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org