https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 122926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122926&action=edit Screenshot of updated checkout note confirmation -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123197&action=edit Bug 28720: Update the process of adding a checkout note in the OPAC This patch moves the entry of checkout notes into a modal window with the goal of making note entry easier. To test, apply the patch and make sure the AllowCheckoutNotes system preference is enabled. - Log in to the OPAC as a user with checkouts. - On the "Your summary" page, confirm that the table listing your checkouts has a "Report a problem" column with "Add note" buttons. - Click an "Add note" button. A modal window should be shown which includes the title of the item, a textarea for writing a note, and a hint, "Your note will be shown to the librarian when the item is checked in." - Add a note and submit it. - The modal should close and a note at the top of the page should tell you your note has been saved. The contents of your note should be shown below that along with an "Edit note" link. - Confirm that the "Edit note" link works as expected. - Confirm that the "Add note" button you clicked in the table of checkouts now reads "Edit note." - You should be able to click this button and edit your note. - Confirm that each note button works to add a note to the correct title. - Confirm that the "Renew selected" and "Renew all" controls work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123197|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 123201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123201&action=edit Bug 28720: Update the process of adding a checkout note in the OPAC This patch moves the entry of checkout notes into a modal window with the goal of making note entry easier. To test, apply the patch and make sure the AllowCheckoutNotes system preference is enabled. - Log in to the OPAC as a user with checkouts. - On the "Your summary" page, confirm that the table listing your checkouts has a "Report a problem" column with "Add note" buttons. - Click an "Add note" button. A modal window should be shown which includes the title of the item, a textarea for writing a note, and a hint, "Your note will be shown to the librarian when the item is checked in." - Add a note and submit it. - The modal should close and a note at the top of the page should tell you your note has been saved. The contents of your note should be shown below that along with an "Edit note" link. - Confirm that the "Edit note" link works as expected. - Confirm that the "Add note" button you clicked in the table of checkouts now reads "Edit note." - You should be able to click this button and edit your note. - Confirm that each note button works to add a note to the correct title. - Confirm that the "Renew selected" and "Renew all" controls work. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I have a few issues and concerns here: 1) I think I'd like to have the note show in the column once it was added. At the moment it's easy to miss it, as you have to click on "Edit note" first to see it. 2) We have export functionality on this table now (I think after this patch was initially written) and instead of the notes we see "Add note" or "Edit note" in the column. 3) I am a little worried if translation tools will pick up on this construct: [% IF ( ISSUE.note ) -%] + [% SET note_action = "Edit note" %] + [% ELSE -%] + [% SET note_action = "Add note" %] + [% END %] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123971&action=edit Bug 28720: (follow-up) Improve string translation This patch fixes the following issues raised by QA: - It modifies the markup so that "Add note" and "Edit note" can be translated more easily. - It adds display of existing notes back to the table of checkouts. - It adds to the table configuration so that a "plain" view of the notes (without buttons) is shown in print view and in CSV export. - It improves handling of notes containing quotation marks which would previously have broken some edit interactions. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123971|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 124631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124631&action=edit Bug 28720: (follow-up) Improve string translation This patch fixes the following issues raised by QA: - It modifies the markup so that "Add note" and "Edit note" can be translated more easily. - It adds display of existing notes back to the table of checkouts. - It adds to the table configuration so that a "plain" view of the notes (without buttons) is shown in print view and in CSV export. - It improves handling of notes containing quotation marks which would previously have broken some edit interactions. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123201|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125681&action=edit Bug 28720: Update the process of adding a checkout note in the OPAC This patch moves the entry of checkout notes into a modal window with the goal of making note entry easier. To test, apply the patch and make sure the AllowCheckoutNotes system preference is enabled. - Log in to the OPAC as a user with checkouts. - On the "Your summary" page, confirm that the table listing your checkouts has a "Report a problem" column with "Add note" buttons. - Click an "Add note" button. A modal window should be shown which includes the title of the item, a textarea for writing a note, and a hint, "Your note will be shown to the librarian when the item is checked in." - Add a note and submit it. - The modal should close and a note at the top of the page should tell you your note has been saved. The contents of your note should be shown below that along with an "Edit note" link. - Confirm that the "Edit note" link works as expected. - Confirm that the "Add note" button you clicked in the table of checkouts now reads "Edit note." - You should be able to click this button and edit your note. - Confirm that each note button works to add a note to the correct title. - Confirm that the "Renew selected" and "Renew all" controls work. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Shouldn't the input in the modal have the focus? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.