[Bug 36595] New: Add patron email to the holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Bug ID: 36595 Summary: Add patron email to the holds queue table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: Laura.escamilla@bywatersolutions.com Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Some libraries would like to see the patron's email address in the Patron holds queue column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 164841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164841&action=edit Bug 36595: Added email address field to the holds queue table To test: 1. Make sure that the system preference ‘HidePatronName’ is set to ‘Show’ 2. Select a patron that has a primary email address set in their contact information. 1. Place a hold for that patron 3. Build the holds queue: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 4. Check the holds queue and notice that the patron column includes the patron’s email 5. Disable the ‘HidePatronName’ system preference 1. Check the holds queue again and notice that no contact information can be seen for the patron 6. Sign off and have an amazing day :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Do we want to wrap the email in a mailto: link like we do on the holds awaiting pickup page? I'm not sure how useful it is in practice, but we usually do that with email addresses. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 164851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164851&action=edit Bug 36595: Updated to add mailto: -- Add patron email to the holds queue table To test: 1. Make sure that the system preference ‘HidePatronName’ is set to ‘Show’ 2. Select a patron that has a primary email address set in their contact information. 1. Place a hold for that patron 3. Build the holds queue: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 4. Check the holds queue and notice that the patron column includes the patron’s email 5. Click on the hyperlinked email. It will open a new email with the subject of "Hold item: (your biblio title)" 6. Disable the ‘HidePatronName’ system preference 1. Check the holds queue again and notice that no contact information can be seen for the patron 7. Sign off and have an amazing day :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164841|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Owen Leonard from comment #2)
Do we want to wrap the email in a mailto: link like we do on the holds awaiting pickup page? I'm not sure how useful it is in practice, but we usually do that with email addresses.
Thanks for the feedback, Owen! I've updated the patch so that it includes a mailto: -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164851|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 164854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164854&action=edit Bug 36595: Updated to add mailto: -- Add patron email to the holds queue table To test: 1. Make sure that the system preference ‘HidePatronName’ is set to ‘Show’ 2. Select a patron that has a primary email address set in their contact information. 1. Place a hold for that patron 3. Build the holds queue: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 4. Check the holds queue and notice that the patron column includes the patron’s email 5. Click on the hyperlinked email. It will open a new email with the subject of "Hold item: (your biblio title)" 6. Disable the ‘HidePatronName’ system preference 1. Check the holds queue again and notice that no contact information can be seen for the patron 7. Sign off and have an amazing day :D Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164854|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166626&action=edit Bug 36595: Updated to add mailto: -- Add patron email to the holds queue table To test: 1. Make sure that the system preference ‘HidePatronName’ is set to ‘Show’ 2. Select a patron that has a primary email address set in their contact information. 1. Place a hold for that patron 3. Build the holds queue: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 4. Check the holds queue and notice that the patron column includes the patron’s email 5. Click on the hyperlinked email. It will open a new email with the subject of "Hold item: (your biblio title)" 6. Disable the ‘HidePatronName’ system preference 1. Check the holds queue again and notice that no contact information can be seen for the patron 7. Sign off and have an amazing day :D Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice little enhancement, no QA issues.. Passing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The "Hold item" here is not translatable: + <p class="patron-email"><a href="mailto:[% itemsloo.patron.email | uri %]?subject=[% "Hold item: " | uri %][% itemsloo.title | uri %]">[% itemsloo.patron.notice_email_address | html %]</a></p> Maybe if you used a variable instead? Would need some testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 169518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169518&action=edit Bug 36595: Updated to make "Hold item:" translatable To test: 1. Make sure that the system preference ‘HidePatronName’ is set to ‘Show’ 2. Select a patron that has a primary email address set in their contact information. 1. Place a hold for that patron 3. Build the holds queue: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 4. Check the holds queue and notice that the patron column includes the patron’s email 5. Click on the hyperlinked email. It will open a new email with the subject of "Hold item: (your biblio title)" 6. Disable the ‘HidePatronName’ system preference 1. Check the holds queue again and notice that no contact information can be seen for the patron 7. Sign off and have an amazing day :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166626|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy, no-sandbox CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169518|0 |1 is obsolete| | --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 169701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169701&action=edit Bug 36595: Updated to make "Hold item:" translatable To test: 1. Make sure that the system preference ‘HidePatronName’ is set to ‘Show’ 2. Select a patron that has a primary email address set in their contact information. 1. Place a hold for that patron 3. Build the holds queue: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 4. Check the holds queue and notice that the patron column includes the patron’s email 5. Click on the hyperlinked email. It will open a new email with the subject of "Hold item: (your biblio title)" 6. Disable the ‘HidePatronName’ system preference 1. Check the holds queue again and notice that no contact information can be seen for the patron 7. Sign off and have an amazing day :D Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169738&action=edit Bug 36595: Added email address field to the holds queue table To test: 1. Make sure that the system preference ‘HidePatronName’ is set to ‘Show’ 2. Select a patron that has a primary email address set in their contact information. 1. Place a hold for that patron 3. Build the holds queue: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 4. Check the holds queue and notice that the patron column includes the patron’s email 5. Click on the hyperlinked email. It will open a new email with the subject of "Hold item: (your biblio title)" 6. Disable the ‘HidePatronName’ system preference 1. Check the holds queue again and notice that no contact information can be seen for the patron 7. Sign off and have an amazing day :D Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169701|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work, thanks Laura. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I see some small issues here. You don't check if the patron actually has an email set. The link will be broken if the email field is empty I believe. This will also not be translatable: ?subject=Hold item: [% itemsloo.title | uri %]"> I think when I looked at this trick in the past, there was also an issue with UTF8/diacritics. As you include the title, it might be worth testing with some Chinese or umlauts as these could happen to occur there. I don't thinks this should be a blocker here, but it might also be worth filing a separate bug for some template trick to show the email address according to EmailFieldPrimary and EmailFieldPrecedence. +1 for adding the class :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, spotted something else: You use itemsloo.patron.email in the link, but itemsloo.patron.notice_email_address in the display text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- This is set to FQA but in main: https://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=4b8bc2efd1fd18f... Why? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #15)
This is set to FQA but in main:
https://git.koha-community.org/gitweb/?p=koha.git;a=commit; h=4b8bc2efd1fd18f74500195966a2f54b719a0b9b
Why?
Because RM needs a better workflow to not forget removing patches from her branch that have failed in testing... could we get a follow-up to avoid revert? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171460&action=edit Bug 36595: (follow-up) Conditionals and consistency Added a conditional to only display email if there's actualy a notice_email_address present. Updated the address used to match the address displayed. Not sure how to resolve the translation issue. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37918 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, no-sandbox, | |release-notes-needed | Text to go in the| |This enhancement adds a release notes| |patron's email address | |(when it exists) to the | |patron column for the holds | |queue table (Circulation > | |Holds and bookings > Holds | |queue). (This requires | |setting the HidePatronName | |system preference to | |'Show'.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org