[Bug 37636] New: Checkout slip prints out of order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Bug ID: 37636 Summary: Checkout slip prints out of order Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com
From bug 19935 - the ordering for checkouts is: ORDER BY `me`.`timestamp` DESC, `issuedate` DESC, `issue_id` DESC
When the automatic_renewals cron updates checkouts it can change the timestamp even if not renewing. We should have an order on the due date, or make this customizable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170496&action=edit Bug 37636: Remove sort of pending_checkouts by timestamp Renewals or automatic renewal attempts can change the timestamp of an issue and cause a sort on this field to functionally randomize the order of checkouts returned. Prior to bug 19935 the GetPendingCheckouts routine returned items in issuedate order. Removing the sort on timestamp will return the previous behaviour and provide a more predictable sorting To test: 1 - Checkout some items to a patron 2 - Print a checkout slip - items are in the order they were checked out 3 - Renew an item,print the slip again it is now at the top of the list 4 - Apply patch, restart_all 5 - Print slip again - the items are now ordered in the order they were checked out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170496|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 170556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170556&action=edit Bug 37636: Remove sort of pending_checkouts by timestamp Renewals or automatic renewal attempts can change the timestamp of an issue and cause a sort on this field to functionally randomize the order of checkouts returned. Prior to bug 19935 the GetPendingCheckouts routine returned items in issuedate order. Removing the sort on timestamp will return the previous behaviour and provide a more predictable sorting To test: 1 - Checkout some items to a patron 2 - Print a checkout slip - items are in the order they were checked out 3 - Renew an item,print the slip again it is now at the top of the list 4 - Apply patch, restart_all 5 - Print slip again - the items are now ordered in the order they were checked out. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170556|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170558&action=edit Bug 37636: Remove sort of pending_checkouts by timestamp Renewals or automatic renewal attempts can change the timestamp of an issue and cause a sort on this field to functionally randomize the order of checkouts returned. Prior to bug 19935 the GetPendingCheckouts routine returned items in issuedate order. Removing the sort on timestamp will return the previous behaviour and provide a more predictable sorting To test: 1 - Checkout some items to a patron 2 - Print a checkout slip - items are in the order they were checked out 3 - Renew an item,print the slip again it is now at the top of the list 4 - Apply patch, restart_all 5 - Print slip again - the items are now ordered in the order they were checked out. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm happy with the change.. but could we get a unit test for the ordering so we prevent future regression pretty please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170558|0 |1 is obsolete| | --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170604&action=edit Bug 37636: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170605&action=edit Bug 37636: Remove sort of pending_checkouts by timestamp Renewals or automatic renewal attempts can change the timestamp of an issue and cause a sort on this field to functionally randomize the order of checkouts returned. Prior to bug 19935 the GetPendingCheckouts routine returned items in issuedate order. Removing the sort on timestamp will return the previous behaviour and provide a more predictable sorting To test: 1 - Checkout some items to a patron 2 - Print a checkout slip - items are in the order they were checked out 3 - Renew an item,print the slip again it is now at the top of the list 4 - Apply patch, restart_all 5 - Print slip again - the items are now ordered in the order they were checked out. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170604|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171453&action=edit Bug 37636: Unit test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170605|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171454&action=edit Bug 37636: Remove sort of pending_checkouts by timestamp Renewals or automatic renewal attempts can change the timestamp of an issue and cause a sort on this field to functionally randomize the order of checkouts returned. Prior to bug 19935 the GetPendingCheckouts routine returned items in issuedate order. Removing the sort on timestamp will return the previous behaviour and provide a more predictable sorting To test: 1 - Checkout some items to a patron 2 - Print a checkout slip - items are in the order they were checked out 3 - Renew an item,print the slip again it is now at the top of the list 4 - Apply patch, restart_all 5 - Print slip again - the items are now ordered in the order they were checked out. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice one Nick, thanks for the unit tests Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37636 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to main |RESOLVED --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org