[Bug 9771] New: Replace YUI buttons on acquisitions basket groups page with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 Bug ID: 9771 Summary: Replace YUI buttons on acquisitions basket groups page with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/basketgroup.pl?booksellerid= OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The toolbar on the acquisitions basket group page uses YUI to generate buttons and menus. It should use Boostrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15984&action=edit Bug 9771 - Replace YUI buttons on acquisitions basket groups page with Bootstrap The acquisitions basket group page has a toolbar with YUI-generated buttons and menus. It should use Bootstrap instead. This patch removes the YUI menu buttons altogether, replacing that functionality with the sidebar menu now included on other acquisitions pages (See Bug 8913). The "New basket group" button is now styled by Bootstrap. Other minor changes: Corrections of invalid markup, improvement to breadcrumbs. To test, view the basket group page and confirm that the toolbar button looks correct and works correctly. Confirm that navigation works and that functionality of the basket group edit page is not affected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- It works like before, but the 2 big blocks are getting larger. I prefer smaller blocks, but maybe you won't agree? I join a screenshot. M. Saby Rennes 2 university -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 15995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15995&action=edit screenshot -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9779 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15984|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16005&action=edit Bug 9771 [Revised] Replace YUI buttons on acquisitions basket groups page with Bootstrap The acquisitions basket group page has a toolbar with YUI-generated buttons and menus. It should use Bootstrap instead. This patch removes the YUI menu buttons altogether, replacing that functionality with the sidebar menu now included on other acquisitions pages (See Bug 8913). The "New basket group" button is now styled by Bootstrap. Other minor changes: Corrections of invalid markup, improvement to breadcrumbs. To test, view the basket group page and confirm that the toolbar button looks correct and works correctly. Confirm that navigation works and that functionality of the basket group edit page is not affected. Revision adds an explicit width to the basket-grouping form columns so that they don't stretch too wide (and far from each other) when the browser window is very wide. This better replicates the layout of the previous version. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16005|0 |1 is obsolete| | --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 16006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16006&action=edit [PATCH] [SIGNED-OFF] Bug 9771 [Revised] Replace YUI buttons on acquisitions basket groups page with Bootstrap Thank you. Everything OK for me, I sign off. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9806 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16006|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16595&action=edit [PASSED QA] Bug 9771 [Revised] Replace YUI buttons on acquisitions basket groups page with Bootstrap The acquisitions basket group page has a toolbar with YUI-generated buttons and menus. It should use Bootstrap instead. This patch removes the YUI menu buttons altogether, replacing that functionality with the sidebar menu now included on other acquisitions pages (See Bug 8913). The "New basket group" button is now styled by Bootstrap. Other minor changes: Corrections of invalid markup, improvement to breadcrumbs. To test, view the basket group page and confirm that the toolbar button looks correct and works correctly. Confirm that navigation works and that functionality of the basket group edit page is not affected. Revision adds an explicit width to the basket-grouping form columns so that they don't stretch too wide (and far from each other) when the browser window is very wide. This better replicates the layout of the previous version. Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script happy. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |katrin.fischer@bsz-bw.de Patch complexity|Trivial patch |--- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9771 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org