[Bug 10245] New: OPAC items table CSS classes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Bug ID: 10245 Summary: OPAC items table CSS classes Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: chrish@catalyst.net.nz The table with the id 'holdingst' in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt lacks some classes which would help in styling and JS manipulation. Robin started in http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9736 Some classes were added in http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 I have added all the classes missing from 8597 that were in Robin's original work for 9736, I made one change which was to change 'vol_no' to 'vol_info' to be consistent with 8597. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |chrish@catalyst.net.nz --- Comment #1 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 18146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18146&action=edit adding OPAC detail items table classes As master is significantly different to 3.10 in this area I will create a separate bug with the 3.10 equivalent of this patch. I also added in the id for barcode of 'item_barcode' as this was in 3.10 and seems to not be in 3.12, I will have to check why it was removed to see if this will cause an issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 --- Comment #2 from Chris Hall <chrish@catalyst.net.nz> --- 3.10 patch attached at http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10246 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18146|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 18733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18733&action=edit Bug 10245 adding OPAC detail items table classes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Classes now appear on <th> as well for easy styling. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18733|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19025&action=edit Bug 10245 adding OPAC detail items table classes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Classes now appear on <th> as well for easy styling. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, template changes only. Adds classes and id's to table headers, makes no other changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Chris! Note: it seems to me that as of master/3.12.x there are still 2 columns without class and id. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org