[Bug 9779] New: Remove global include of YUI assets from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Bug ID: 9779 Summary: Remove global include of YUI assets from the staff client Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org Depends on: 8278, 9690, 9697, 9764, 9769, 9771, 9773 At the time this bug being filed there are only a handful of pages in the staff client which still require YUI assets. Pending patches cover most of these (listed as dependencies on this bug). There is one page, basketgroups.pl, which still doesn't have a patch to re-implement the drag-and-drop functionality in something other than YUI. I propose to remove YUI assets from the global include file and include them explicitly in the basketgroups template until that conversion can be done. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18562&action=edit Bug 9779 - Remove global include of YUI assets from the staff client There are no pages in the staff client which use YUI JS assets other than basketgroups.tt. The links to YUI assets can therefore be removed from the global include and put directly into the basket groups template. To test, view the basketgroups page and confirm using a JS debugger that no JS errors are triggered. Perform various basket group options: Open, close, modify, drag-and-drop. Operations should complete successfully and without JS errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18562|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 18636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18636&action=edit [SIGNED-OFF] Bug 9779 - Remove global include of YUI assets from the staff client There are no pages in the staff client which use YUI JS assets other than basketgroups.tt. The links to YUI assets can therefore be removed from the global include and put directly into the basket groups template. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18636|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19047&action=edit [PASSED QA] Bug 9779 - Remove global include of YUI assets from the staff client There are no pages in the staff client which use YUI JS assets other than basketgroups.tt. The links to YUI assets can therefore be removed from the global include and put directly into the basket groups template. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Really nice to see YUI go. Checked that the drag&drop functionality in basket groups still works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! Besides basketgroup.tt, there are a few remaining references to JavaScript widgets in the YHAOO namespace: - koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt This template is used by a script that is no longer linked to the administration page, and per bug 9819 it looks like there's an active effort underway to remove the last of the legacy stopwords code. - koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt The only reference is in in a FIXME comment that can probably just be removed. - koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-reserves.tt The references are in commented-out code that appears to be the beginning of an attempt to add a course reserve search option to the global search box. This code can probably just be removed; adding such a search option for real can be the topic of a separate bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10522 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org