[Bug 11549] New: After transferring an order, receive and cancel the receipt will delete the order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Bug ID: 11549 Summary: After transferring an order, receive and cancel the receipt will delete the order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 5349 introduces the ability to transfer an order from a basket to another. After a transfer, if an order is received and the receipt is canceled, the order will be deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24274&action=edit Bug 11549: Add regression test test plan: prove t/db_dependent/Acquisition/TransferOrder.t should fail before the patch and success after applying it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24275&action=edit Bug 11549: FIX receive and cancel the receipt after a transfer. To reproduce the issue: - transfer an order from a basket to another. Note the previous ordernumber (X) and the new one (Y). - receive the order - cancel the receipt - verify the order has been deleted: select count(*) from aqorders where ordernumber=Y; select * from aqorders_transfers where ordernumber_from = X; The value for ordernumber_to is null. To test this patch: - apply this patch - transfer an order from a basket to another - receive the order - cancel the receipt - verify the order still exist in the basket where the transfer has been done. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24276&action=edit Bug 11549: Interpolate variables into SQL statements should not be allowed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11552 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #4 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I did several tests of transfers (from a basket, from the receipt page, after a double transfer). Every time, I received the document and cancelled the reception: the document returns as awaiting to be received. The discount of document to be received is OK. Everything is OK for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24274|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24275|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24276|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 24402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24402&action=edit Bug 11549: Add regression test test plan: prove t/db_dependent/Acquisition/TransferOrder.t should fail before the patch and success after applying it. Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 24403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24403&action=edit Bug 11549: FIX receive and cancel the receipt after a transfer. To reproduce the issue: - transfer an order from a basket to another. Note the previous ordernumber (X) and the new one (Y). - receive the order - cancel the receipt - verify the order has been deleted: select count(*) from aqorders where ordernumber=Y; select * from aqorders_transfers where ordernumber_from = X; The value for ordernumber_to is null. To test this patch: - apply this patch - transfer an order from a basket to another - receive the order - cancel the receipt - verify the order still exist in the basket where the transfer has been done. Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 24404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24404&action=edit Bug 11549: Interpolate variables into SQL statements should not be allowed Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 24487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24487&action=edit Bug 11549: [follow-up] Make NewOrder calculate new parent_ordernumber If parent_ordernumber is not set in NewOrder parameter, it is automatically set to ordernumber. This patch only avoid code duplication. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24487|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24503&action=edit Bug 11549: [follow-up] Make NewOrder calculate new parent_ordernumber If parent_ordernumber is not set in NewOrder parameter, it is automatically set to ordernumber. This patch only avoid code duplication. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This solution is better! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24402|0 |1 is obsolete| | Attachment #24403|0 |1 is obsolete| | Attachment #24404|0 |1 is obsolete| | Attachment #24503|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24546&action=edit [PASSED QA] Bug 11549: Add regression test test plan: prove t/db_dependent/Acquisition/TransferOrder.t should fail before the patch and success after applying it. Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Testing notes on last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24547&action=edit [PASSED QA] Bug 11549: FIX receive and cancel the receipt after a transfer. To reproduce the issue: - transfer an order from a basket to another. Note the previous ordernumber (X) and the new one (Y). - receive the order - cancel the receipt - verify the order has been deleted: select count(*) from aqorders where ordernumber=Y; select * from aqorders_transfers where ordernumber_from = X; The value for ordernumber_to is null. To test this patch: - apply this patch - transfer an order from a basket to another - receive the order - cancel the receipt - verify the order still exist in the basket where the transfer has been done. Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24548&action=edit [PASSED QA] Bug 11549: Interpolate variables into SQL statements should not be allowed Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24549&action=edit [PASSED QA] Bug 11549: [follow-up] Make NewOrder calculate new parent_ordernumber If parent_ordernumber is not set in NewOrder parameter, it is automatically set to ordernumber. This patch only avoid code duplication. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This solution is better! Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Also all tests in t/db_dependent/Acquisitions/. Confirmed bug and that the patch fixes it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11744 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11549 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patches pushed to 3.14.x, will be in 3.14.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org