[Bug 12765] New: Capitalization: Catalouguing > Z39.50 search > "Try another search"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 Bug ID: 12765 Summary: Capitalization: Catalouguing > Z39.50 search > "Try another search" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1561 Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Capitalization: |Capitalization: Cataloguing |Catalouguing > Z39.50 |> Z39.50 search > "Try |search > "Try another |another search" |search" | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30821&action=edit Bug 12765: Fix capitalization - "Try another search" To test: - Go to cataloguing - Perform a z39.50 search with no results - Check "Try another search" is displayed - Perform a z39.50 search with results - Verify display is correct as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 George Williams <georgew@latahlibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |georgew@latahlibrary.org --- Comment #2 from George Williams <georgew@latahlibrary.org> --- I couldn't test this patch in the sandboxes. I tried applying this patch in one of the Biblibre sandboxes last night and in one of the PTFS sandboxes this morning and the sandboxes could not apply the patch to Koha. The error message the sandbox e-mailed me in both cases was: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 12765: <h1>Something went wrong !</h1>Applying: Bug 12765: Fix capitalization - Try another search Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt Failed to merge in the changes. Patch failed at 0001 Bug 12765: Fix capitalization - Try another search When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 12765 - Capitalization: Cataloguing > Z39.50 search > Try another search 30821 - Bug 12765: Fix capitalization - Try another search Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-12765-Fix-capitalization---Try-another-search-isbnJe.patch . -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30821|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31270&action=edit Bug 12765: Fix capitalization - "Try another search" To test: - Go to cataloguing - Perform a z39.50 search with no results - Check "Try another search" is displayed - Perform a z39.50 search with results - Verify display is correct as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I rebased the patch, I think it should work now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@ptfs-europe.com --- Comment #5 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Patch tested with a sandbox, by George Williams <georgew@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31270|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 --- Comment #6 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 31271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31271&action=edit Revert "Bug 12176 - Remove HTML from additem.pl" This reverts commit 0033d287bad3344fad0861134d8dd3e03e56ed24. I made a mistake pushing this one before the UTF-8 work. Signed-off-by: George Williams <georgew@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- The current patch seems to be the wrong one. Please correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the sandbox did something weird here - I will upload a patch with the sign-off line later. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31271|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31303&action=edit [SIGNED OFF] Bug 12765: Fix capitalization - "Try another search" To test: - Go to cataloguing - Perform a z39.50 search with no results - Check "Try another search" is displayed - Perform a z39.50 search with results - Verify display is correct as well. Signed-off-by: George Williams <georgew@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have reattached the patch and added the sign off line - thx George! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- The patch does not apply anymore. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31303|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31451&action=edit Bug 12765: Fix capitalization - "Try another search" To test: - Go to cataloguing - Perform a z39.50 search with no results - Check "Try another search" is displayed - Perform a z39.50 search with results - Verify display is correct as well. Signed-off-by: George Williams <georgew@latahlibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Ok I recreated the patch. Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12765 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org