[Bug 12746] New: Remove empty onclick attribute from memberentrygen.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12746 Bug ID: 12746 Summary: Remove empty onclick attribute from memberentrygen.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com As Owen Leonard remarked in Bug 17744, empty onclick attribute should be removed. Git grep 'onclick=""' lists memberentrygen.tt only. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12746 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 30708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30708&action=edit Bug 12746 - Remove empty onclick attribute from memberentrygen.tt This patch removes empty onclick attribute from memberentrygen.tt To test: Apply patch. Use git grep 'onclick=""' to make sure that there are no more empty onlick attributes Go to Home > patrons and click 'New patron' Check HTML of 'Cancel' link Make sure that 'Cancel' link still works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12746 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12746 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12746 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30708|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30745&action=edit [SIGNED-OFF] Bug 12746 - Remove empty onclick attribute from memberentrygen.tt This patch removes empty onclick attribute from memberentrygen.tt To test: Apply patch. Use git grep 'onclick=""' to make sure that there are no more empty onlick attributes Go to Home > patrons and click 'New patron' Check HTML of 'Cancel' link Make sure that 'Cancel' link still works Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30745|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30825&action=edit [PASSED QA] Bug 12746 - Remove empty onclick attribute from memberentrygen.tt This patch removes empty onclick attribute from memberentrygen.tt To test: Apply patch. Use git grep 'onclick=""' to make sure that there are no more empty onlick attributes Go to Home > patrons and click 'New patron' Check HTML of 'Cancel' link Make sure that 'Cancel' link still works Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changes the link to cancel adding a manual restriction. No regressions found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12746 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org