https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Affected would be any templates which include: [% PROCESS options_for_libraries... or [% PROCESS options_for_authorised_value_categories... ...because those blocks are defined in html_helpers.inc. The breakage would only occur if you tried to add [% SET footerjs = 1 %] to any of those templates. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58705&action=edit Bug 17870 - Call to include file incorrectly moved into the footer This patch moves a line of template code from js_includes.inc back into doc-head-close.inc where it belongs. To test, apply the patch and view a page which uses a template that depends on html_helpers.inc being processed. For example: - The set library page - The holds queue report - The new patron form The pages should work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58705|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 58719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58719&action=edit Bug 17870 - Call to include file incorrectly moved into the footer This patch moves a line of template code from js_includes.inc back into doc-head-close.inc where it belongs. To test, apply the patch and view a page which uses a template that depends on html_helpers.inc being processed. For example: - The set library page - The holds queue report - The new patron form The pages should work correctly. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58719|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58720&action=edit Bug 17870 - Call to include file incorrectly moved into the footer This patch moves a line of template code from js_includes.inc back into doc-head-close.inc where it belongs. To test, apply the patch and view a page which uses a template that depends on html_helpers.inc being processed. For example: - The set library page - The holds queue report - The new patron form The pages should work correctly. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- Depends on|17416 | CC| |martin.renvoize@openfifth.c | |o.uk Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 [Bug 17416] Move javascript in doc-head-close.inc into a separate include -- You are receiving this mail because: You are watching all bug changes.