[Bug 17893] New: Move JavaScript to the footer on staff client catalog pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Bug ID: 17893 Summary: Move JavaScript to the footer on staff client catalog pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: claire_gravely@hotmail.com, jonathan.druart@bugs.koha-community.org, testopia@bugs.koha-community.org Depends on: 17870, 17418 Blocks: 17858 This patch will move JavaScript to the footer on a number of pages in the catalog module of the staff client: basket/basket.tt catalogue/ISBDdetail.tt catalogue/MARCdetail.tt catalogue/advsearch.tt catalogue/detail.tt catalogue/imageviewer.tt catalogue/issuehistory.tt catalogue/itemsearch.tt catalogue/labeledMARCdetail.tt catalogue/moredetail.tt catalogue/results.tt catalogue/search-history.tt In the process I will be consolidating JS from several of those templates into one separate JavaScript file. Other modifications will be required in order for JavaScript to be able to be called from catalog-related include files. Since include files are parsed before jQuery is loaded in the footer, jQuery-specific code will have to be adapted or moved. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 [Bug 17870] Call to include file incorrectly moved into the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Bug 17893 depends on bug 17870, which changed state. Bug 17870 Summary: Call to include file incorrectly moved into the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 64603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64603&action=edit Bug 17893 - Move JavaScript to the footer on staff client catalog pages This patch modifies multiple catalog-related pages in order to move embedded JavaScript to the footer. The JavaScript previously embedded in cat-toolbar.inc is moved to a separate file (catalog.js). To test, apply the patch and test JavaScript-driven interactions on all modified pages, including JS which isn't page-specific (menus, help, etc). The functionality of the catalog toolbar should be tested on each page. - Bibliographic detail pages (standard, MARC, labeled MARC, ISBD). - Advanced search page - Local cover image viewer - Item search page - Item detail page - Search history page - Checkout history page https://bugs.koha-community.org/show_bug.cgi?id=17839 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64603|0 |1 is obsolete| | --- Comment #2 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64677&action=edit Bug 17893 - Move JavaScript to the footer on staff client catalog pages This patch modifies multiple catalog-related pages in order to move embedded JavaScript to the footer. The JavaScript previously embedded in cat-toolbar.inc is moved to a separate file (catalog.js). To test, apply the patch and test JavaScript-driven interactions on all modified pages, including JS which isn't page-specific (menus, help, etc). The functionality of the catalog toolbar should be tested on each page. - Bibliographic detail pages (standard, MARC, labeled MARC, ISBD). - Advanced search page - Local cover image viewer - Item search page - Item detail page - Search history page - Checkout history page https://bugs.koha-community.org/show_bug.cgi?id=17839 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64677|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 66950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66950&action=edit Bug 17893 - Move JavaScript to the footer on staff client catalog pages This patch modifies multiple catalog-related pages in order to move embedded JavaScript to the footer. The JavaScript previously embedded in cat-toolbar.inc is moved to a separate file (catalog.js). To test, apply the patch and test JavaScript-driven interactions on all modified pages, including JS which isn't page-specific (menus, help, etc). The functionality of the catalog toolbar should be tested on each page. - Bibliographic detail pages (standard, MARC, labeled MARC, ISBD). - Advanced search page - Local cover image viewer - Item search page - Item detail page - Search history page - Checkout history page https://bugs.koha-community.org/show_bug.cgi?id=17839 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66950|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66962&action=edit Bug 17893 - Move JavaScript to the footer on staff client catalog pages This patch modifies multiple catalog-related pages in order to move embedded JavaScript to the footer. The JavaScript previously embedded in cat-toolbar.inc is moved to a separate file (catalog.js). To test, apply the patch and test JavaScript-driven interactions on all modified pages, including JS which isn't page-specific (menus, help, etc). The functionality of the catalog toolbar should be tested on each page. - Bibliographic detail pages (standard, MARC, labeled MARC, ISBD). - Advanced search page - Local cover image viewer - Item search page - Item detail page - Search history page - Checkout history page https://bugs.koha-community.org/show_bug.cgi?id=17839 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20977 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 [Bug 20979] Error message when deleting bib attached to order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Depends on|17418 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org