[Bug 21296] New: suspend hold ignores system preference on intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Bug ID: 21296 Summary: suspend hold ignores system preference on intranet Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdonna@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Setting the system preference SuspendHoldsIntranet to Don't Allow has no impact. Staff can still suspend patron holds from the staff client. To test: 1. Set SuspendHoldsIntranet to Don't Allow 2. Set SuspendHoldsOPAC to Allow 3. Log in to OPAC and place hold 4. Log in to staff client and pull up patron's account 5. View holds and suspend hold. 6. Date picker window opens and allows suspension of hold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|17.11 |master Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 95624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95624&action=edit Bug 21296: suspend hold ignores system preference on intranet This patch modifies the DataTable configuration for the table of holds which displays under the "Holds" tab on the patron's checkout and details pages. A variable is now defined in the JavaScript with the value of the "SuspendHoldsIntranet" system preference. This variable is passed to the DataTable configuration to determine whether the column is visible or not. One of the changes made in this patch moves a <script> block so that it appears before some of the JS includes on the page. This helps keep the string-defining JS together in one block. To test, apply the patch and set the "SuspendHoldsIntranet" system preference to "Allow." - Open the checkout page for a patron with one or more holds. - Under the "Holds" tab, the table of holds should have a "Suspend" column with controls for suspending or resuming holds. - Check that the same is true on the patron detail page. - Set the "SuspendHoldsIntranet" system preference to "Don't allow." - Test the checkout and detail pages again and confirm that the "Suspend" column does not appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95624|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97579&action=edit Bug 21296: suspend hold ignores system preference on intranet This patch modifies the DataTable configuration for the table of holds which displays under the "Holds" tab on the patron's checkout and details pages. A variable is now defined in the JavaScript with the value of the "SuspendHoldsIntranet" system preference. This variable is passed to the DataTable configuration to determine whether the column is visible or not. One of the changes made in this patch moves a <script> block so that it appears before some of the JS includes on the page. This helps keep the string-defining JS together in one block. To test, apply the patch and set the "SuspendHoldsIntranet" system preference to "Allow." - Open the checkout page for a patron with one or more holds. - Under the "Holds" tab, the table of holds should have a "Suspend" column with controls for suspending or resuming holds. - Check that the same is true on the patron detail page. - Set the "SuspendHoldsIntranet" system preference to "Don't allow." - Test the checkout and detail pages again and confirm that the "Suspend" column does not appear. Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|suspend hold ignores system |Suspend hold ignores system |preference on intranet |preference on intranet CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97579|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97590&action=edit Bug 21296: suspend hold ignores system preference on intranet This patch modifies the DataTable configuration for the table of holds which displays under the "Holds" tab on the patron's checkout and details pages. A variable is now defined in the JavaScript with the value of the "SuspendHoldsIntranet" system preference. This variable is passed to the DataTable configuration to determine whether the column is visible or not. One of the changes made in this patch moves a <script> block so that it appears before some of the JS includes on the page. This helps keep the string-defining JS together in one block. To test, apply the patch and set the "SuspendHoldsIntranet" system preference to "Allow." - Open the checkout page for a patron with one or more holds. - Under the "Holds" tab, the table of holds should have a "Suspend" column with controls for suspending or resuming holds. - Check that the same is true on the patron detail page. - Set the "SuspendHoldsIntranet" system preference to "Don't allow." - Test the checkout and detail pages again and confirm that the "Suspend" column does not appear. Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- This applies to 19.11. branch, but qa tests show this error: Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 287. Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 287. Not backported unless these are not major errors. -joy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- QA tests all show OK, except for nonnumeric error. Pushing to 19.11.x for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.15 CC| |hayleymapley@catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Backported to 18.11.x for 18.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 --- Comment #9 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- This patch in the 18.11 build has caused two tests to fail: _db_dependent_selenium_regressions_t.Display circulation table correctly (476) t_db_dependent_Circulation_t.AddReturn + suspension_chargeperiod (500) Is anyone able to fix these tests for 18.11? Alternatively I can revert the patches for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Hayley Mapley from comment #9)
This patch in the 18.11 build has caused two tests to fail:
_db_dependent_selenium_regressions_t.Display circulation table correctly (476) t_db_dependent_Circulation_t.AddReturn + suspension_chargeperiod (500)
Is anyone able to fix these tests for 18.11? Alternatively I can revert the patches for now.
Hi Hayley, I do recreate the selenium failure locally, not Circulation.t The checkouts table does not display correctly because of a missing columns_settings variable. The following commit is part of 19.05 but 18.11: commit f6599b2c5480d2e096bac71e4e7ac759686b9fbc Bug 17353: Add phone number column to checkout search - columns_settings = [% ColumnsSettings.GetColumns( 'circ', 'circulation', 'issues-table', 'json' ) | $raw %] + columns_settings_issues_table = [% ColumnsSettings.GetColumns( 'circ', 'circulation', 'issues-table', 'json' ) | $raw %] + columns_settings_borrowers_table = [% ColumnsSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100765&action=edit Bug 21296: [18.11.x] Fix wrong resolution conflict On commit a230878b6f3d3afa5d7f33c9d816bd6272c5b1a1 Bug 21296: suspend hold ignores system preference on intranet See comment 10. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 --- Comment #12 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Many thanks Jonathan! I must have removed it in error during the merge. Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org